From: David Marchand <david.marchand@redhat.com>
To: Xiaolong Ye <xiaolong.ye@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: correct xdp frame size
Date: Mon, 8 Jul 2019 10:26:18 +0200 [thread overview]
Message-ID: <CAJFAV8w6T_pB+M-AAoqu0b7hgWUo7DQE8s-TB8t4jF-PRNqD9Q@mail.gmail.com> (raw)
In-Reply-To: <20190707155705.58515-1-xiaolong.ye@intel.com>
On Mon, Jul 8, 2019 at 10:03 AM Xiaolong Ye <xiaolong.ye@intel.com> wrote:
> XSK_UMEM__DEFAULT_FRAME_SIZE has been changed to 4096 in kernel commit
> 123e8da1d330 (xsk: Change the default frame size to 4096 and allow
> controlling it), but we still need to keep ETH_AF_XDP_FRAME_SIZE as 2048 to
> fit most dpdk apps.
>
I might have missed something, but can't you use the mbuf size from the
packet mempool passed at rx_queue_setup?
--
David Marchand
next prev parent reply other threads:[~2019-07-08 8:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 15:57 Xiaolong Ye
2019-07-08 8:26 ` David Marchand [this message]
2019-07-08 9:14 ` Bruce Richardson
2019-07-08 18:08 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8w6T_pB+M-AAoqu0b7hgWUo7DQE8s-TB8t4jF-PRNqD9Q@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).