From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7506E423C3; Fri, 13 Jan 2023 14:46:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 504A642D53; Fri, 13 Jan 2023 14:46:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AEA3A40E03 for ; Fri, 13 Jan 2023 14:46:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673617615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4+tHxzN4TM7G8nMqPlu1wj2FC8g1zgj4Mes1ppcaqjM=; b=XEwkj4QBClvIQnqCFRgHAC4Br55efAKQtidaK49f3rRvlqlfLJCaJH83tP1I3tkD+ElXV9 ry9fTwl1MicP3jGaIxlAEUBSwQ0W3M6592rGgLts//U+CtPe3PG5+xPt+x7pQy4Mjb+bIy UoQ+aQZdMdFcN6B/xuY3O8NO1m1zQww= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-542-tT6FvakJO8yOUxg3rP5KlQ-1; Fri, 13 Jan 2023 08:46:52 -0500 X-MC-Unique: tT6FvakJO8yOUxg3rP5KlQ-1 Received: by mail-pj1-f69.google.com with SMTP id r17-20020a17090aa09100b0021903e75f14so9830090pjp.9 for ; Fri, 13 Jan 2023 05:46:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4+tHxzN4TM7G8nMqPlu1wj2FC8g1zgj4Mes1ppcaqjM=; b=zxCNM/oYO0RgGt6GVPAsafwj4f8ZeSl1nofp1ljJ74yYWncqnglENVb/6n8KGEtsAV 1NR3+6LIr6YivuOnHTsbcckaOT7ZDvCfYNL0lFmtzC7vFUbrEApN2ZNzgmMBJnWAPDdo IhBfajCgJMlDzLYj/ow1lXsB9rfeUVaQ7Inj+pNNTcZ8v56U6vJRLlh/m17+0LyHz3DV cGASRrU52c/lSq0OiX8ulLuaxzgxOIsLud1ZllyVcQFn3sTftttQmTen9ydXFQcinuQf VHyPqA+7A37gfYuv6ZqoA0bNRI9sSgyDgo3hBKtdvoyoKdGfP9t9ex0IXnJ0qydWHNQ7 XWFw== X-Gm-Message-State: AFqh2kryCeEfbgbeuKIkWEorp7UCzYnrrxoRhdyXtMXMuG4TsKjXyE6i GapYEBkviTFAyXI5ItCSNkZvR5r/eMmGMb5h8jIjdlR9D1i26z7Nc4gWF3/PyKXPxVLJrfKkEpk TpdYy0pnAiJhG/9mwzng= X-Received: by 2002:a17:903:11cf:b0:191:283d:6134 with SMTP id q15-20020a17090311cf00b00191283d6134mr5211824plh.106.1673617611105; Fri, 13 Jan 2023 05:46:51 -0800 (PST) X-Google-Smtp-Source: AMrXdXvsEV9hh98Oxquxc1GDZ23hut4soyXGujA7ex8OL9ZN+Z//mAz/syQOam+uU5MpAFOvIG/9aKmeDw7+BjoorgQ= X-Received: by 2002:a17:903:11cf:b0:191:283d:6134 with SMTP id q15-20020a17090311cf00b00191283d6134mr5211816plh.106.1673617610841; Fri, 13 Jan 2023 05:46:50 -0800 (PST) MIME-Version: 1.0 References: <20221212143715.29649-1-david.marchand@redhat.com> <20221213091837.87953-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 13 Jan 2023 14:46:39 +0100 Message-ID: Subject: Re: [PATCH v2] net/i40e: don't check link status on device start To: "Zhang, Helin" Cc: "Zhang, Yuying" , "Xing, Beilei" , "Mcnamara, John" , "dev@dpdk.org" , "stable@dpdk.org" , "Zhang, Qi Z" , Dapeng Yu , Wenxuan Wu X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 13, 2023 at 2:39 PM Zhang, Helin wrote: > > > > > -----Original Message----- > > From: David Marchand > > Sent: Friday, January 13, 2023 9:33 PM > > To: Zhang, Yuying ; Xing, Beilei > > ; Mcnamara, John > > Cc: dev@dpdk.org; stable@dpdk.org; Zhang, Qi Z ; > > Dapeng Yu ; Wenxuan Wu > > > > Subject: Re: [PATCH v2] net/i40e: don't check link status on device start > > > > Hello i40e maintainers, John, > > > > On Mon, Jan 9, 2023 at 10:21 AM David Marchand > > wrote: > > > On Tue, Jan 3, 2023 at 3:02 PM David Marchand > > wrote: > > > > Hi i40e maintainers, > > > > > > > > On Tue, Dec 13, 2022 at 10:19 AM David Marchand > > > > wrote: > > > > > > > > > > The mentioned changes broke existing applications when the link > > > > > status of i40e ports is down at the time the port is started. > > > > > Revert those changes, the original issue will need a different fix. > Hi David > > Does it break all the application or just a specific application? I don't see how it would not affect all applications seeing how the original patch is dumb. > We may need to understand the issue you met, and try to fix it later. Just unplug the cable or fake a link down on your i40e port, start your application or port, then plug the cable back. The max frame size will never get applied to hw. -- David Marchand