* [PATCH] net/iavf: fix pkt len check
@ 2023-10-13 11:41 Dexia Li
2023-10-13 11:47 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Dexia Li @ 2023-10-13 11:41 UTC (permalink / raw)
To: dev; +Cc: qingmin.liu, joey.xing, Dexia Li
App usually encap some bytes in mbuf headroom, for example, tunnel
header. When RTE_MBUF_F_TX_TCP_SEG is set, this check will drop packets.
Since the packet will be cut by hw soon, the out packet will not exceed
mtu.
Signed-off-by: Dexia Li <dexia.li@jaguarmicro.com>
---
drivers/net/iavf/iavf_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index b1d0fbceb6..b6dabed3c8 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -3641,7 +3641,7 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,
/* check the data_len in mbuf */
if (m->data_len < IAVF_TX_MIN_PKT_LEN ||
- m->data_len > max_frame_size) {
+ (!(ol_flags & RTE_MBUF_F_TX_TCP_SEG) && m->data_len > max_frame_size)) {
rte_errno = EINVAL;
PMD_DRV_LOG(ERR, "INVALID mbuf: bad data_len=[%hu]", m->data_len);
return i;
--
2.33.0.windows.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/iavf: fix pkt len check
2023-10-13 11:41 [PATCH] net/iavf: fix pkt len check Dexia Li
@ 2023-10-13 11:47 ` David Marchand
[not found] ` <KL1PR06MB5893D457706C34856FC2781C9FD7A@KL1PR06MB5893.apcprd06.prod.outlook.com>
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2023-10-13 11:47 UTC (permalink / raw)
To: Dexia Li; +Cc: dev, qingmin.liu, joey.xing, Mike Pattrick
Hello Dexia,
On Fri, Oct 13, 2023 at 1:42 PM Dexia Li <dexia.li@jaguarmicro.com> wrote:
>
> App usually encap some bytes in mbuf headroom, for example, tunnel
> header. When RTE_MBUF_F_TX_TCP_SEG is set, this check will drop packets.
> Since the packet will be cut by hw soon, the out packet will not exceed
> mtu.
>
> Signed-off-by: Dexia Li <dexia.li@jaguarmicro.com>
This should be fixed with series:
https://patchwork.dpdk.org/project/dpdk/list/?series=29651&state=%2A&archive=both
Applied in next-net-intel:
https://git.dpdk.org/next/dpdk-next-net-intel/commit/?id=ff67c8a679c2daba282841459d8cd4131b3a85ab
Those patches will make it to the main dpdk repo soon.
Please double check they work for you.
Thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/iavf: fix pkt len check
[not found] ` <KL1PR06MB5893D457706C34856FC2781C9FD7A@KL1PR06MB5893.apcprd06.prod.outlook.com>
@ 2023-10-16 7:30 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2023-10-16 7:30 UTC (permalink / raw)
To: Dexia Li; +Cc: Qingmin Liu, Joey Xing, Mike Pattrick, dev
On Mon, Oct 16, 2023 at 3:37 AM Dexia Li <dexia.li@jaguarmicro.com> wrote:
>
> Thanks for your commit.
> It works for me.
>
Thanks for confirming, I marked this patch as rejected.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-16 7:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-13 11:41 [PATCH] net/iavf: fix pkt len check Dexia Li
2023-10-13 11:47 ` David Marchand
[not found] ` <KL1PR06MB5893D457706C34856FC2781C9FD7A@KL1PR06MB5893.apcprd06.prod.outlook.com>
2023-10-16 7:30 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).