From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 532ACA0556; Thu, 20 Feb 2020 14:25:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BBE311BFD2; Thu, 20 Feb 2020 14:25:46 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 289BC1BFC7 for ; Thu, 20 Feb 2020 14:25:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582205144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QSw39SfoUQh5RPvWRwBHpRhZ00Kuh46NQuTz8vzrzhM=; b=KnHnifAdmmGkAkYoVrEliHb/ELlxoGtbuaI8qp+r9IodkH2BsFjSufE4DV7W6MwN0cu2Dl oWtnNzn8jzNWqIbwvsvVBqv8F1OmMbtjaRV5DCXsWLwkXkS5jazhYSQ34lpcmYavhD8QnX nK7PIjMR5dz+YaW9MkE5PA2Rg+OEv2M= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-maeeaZlSOr2StY_nZ56_0g-1; Thu, 20 Feb 2020 08:25:41 -0500 Received: by mail-vs1-f69.google.com with SMTP id f15so574826vsk.21 for ; Thu, 20 Feb 2020 05:25:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5jy/cLD5R6V8iw9IiiCyC1Hq6YHDCaCCDyGd8OA8l/s=; b=cyP4rEtc1YK/AKznCbkbtIj7BLsB1boTH6tc52uYCsBOwIKh95fgw12TxzsSOIErJL W0h2qBA1C0wHXRcjlVlfhbbmil338cjbfsocpyzoBfGSBXRx3kNuEEmfTt7PZ9sY6KRc Zgc7vSTBvCZIu5zoCfBatWeHmedxTKgiP9LlIxOIPGwjq11jQt9I1kGU8yqzg2UnllGI t/tBd34lVnveZwDtnbPyfl2FrJbjnAKq0Lr0/yVxmKG4RmCDh7D2mEzNOHsrFhoHDyGl BDIvTJ7QhAPB8SFcRlJMZGPC8LpC3NG6mUt0EMT/53SPMgMQkZSPo0gT4vXMpoErCJvP xNVw== X-Gm-Message-State: APjAAAVwunaVzuqYToZiIhtn8BxlIRpZL8WZi3GZp74YpaTdKYhsm3xf F8QIQW+PKhxstFgnh8uOy2dLHgEDYoGW4nX3dD/JGsiCNk+dMhE+MNNj5ApUopVVdqd+KFQxNTi STNJ8bQeDN11ViVwdKKE= X-Received: by 2002:a67:f315:: with SMTP id p21mr17020345vsf.39.1582205141344; Thu, 20 Feb 2020 05:25:41 -0800 (PST) X-Google-Smtp-Source: APXvYqzLCrf3yxrVZR3Ph4LMvFvhC7Xb5q3/bSgrnqrXwccrMZuCH92XrYhqcPTlk5vvSbNMxnZWW/RKJBCV0rLItJ8= X-Received: by 2002:a67:f315:: with SMTP id p21mr17020321vsf.39.1582205141030; Thu, 20 Feb 2020 05:25:41 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Thu, 20 Feb 2020 14:25:29 +0100 Message-ID: To: "Van Haaren, Harry" Cc: Aaron Conole , dev X-MC-Unique: maeeaZlSOr2StY_nZ56_0g-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [RFC] service: stop lcore threads before 'finalize' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Feb 10, 2020 at 3:16 PM Van Haaren, Harry wrote: > > > We need a fix for this issue. > > > > +1 > > > > Interestingly, Stephen patch that joins all pthreads at > > > rte_eal_cleanup [1] makes this issue disappear. > > > So my understanding is that we are missing a api (well, I could not > > > find a way) to synchronously stop service lcores. > > > > Maybe we can take that patch as a fix. I hate to see this segfault > > in the field. I need to figure out what I missed in my cleanup > > (probably missed a synchronization point). > > I haven't easily reproduced this yet - so I'll investigate a way to > reproduce with close to 100% rate, then we can identify the root cause > and actually get a clean fix. If you have pointers to reproduce easily, > please let me know. > ping. I want a fix in 20.05, or I will start considering how to drop this thing. --=20 David Marchand