From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA54341EB1; Thu, 16 Mar 2023 16:55:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 999CB40DF6; Thu, 16 Mar 2023 16:55:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BC66F40DDC for ; Thu, 16 Mar 2023 16:55:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678982154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rak3/N2eIxF3UfDsP0SXRtBOGXIl7J59QE7sI4ePgcg=; b=LyCQoHx/e/vgOD5zoTZiJdeNPMyrltx3PcGz1o1J49qmEJfAbvJs7Uz2ClpTFatz+mZp2s aEjuY9CEVmYHnC/VKSdUIuQQGY3NZu/Pzc4lOm4Ud1oSCogM1/ksWqwWNLraWgj2z9T60n L2RMhyanGRn+7AYGxtH5js5TXpWGelM= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-322-9ue8OZw-MGy-IqXNyhZ-pA-1; Thu, 16 Mar 2023 11:55:53 -0400 X-MC-Unique: 9ue8OZw-MGy-IqXNyhZ-pA-1 Received: by mail-pj1-f70.google.com with SMTP id nm11-20020a17090b19cb00b0023d0c90d851so1109516pjb.1 for ; Thu, 16 Mar 2023 08:55:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678982152; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rak3/N2eIxF3UfDsP0SXRtBOGXIl7J59QE7sI4ePgcg=; b=r8XvAt/57H98g8+51wcivvo8aaNMs/VorwmlLKNgnMd/z75ZNeMBNeDRJ81aZrlQuu O3x+6kcBv9IOzsXLUl1TV6LflcM/X0FZLEZFNXoygMSi7QWxGS8xqfha1tyQ5Zzuhw3i i5zO3bd9fQmlI7tqh6Wj47mEdTmI1DVesPKecyEp1cT9yENY68kLW+/I5Eea2OSa2Go/ aAaG32Z7jSN+DBN+N+ECc5rYsNbFRTv6pq0KpZrdxqi0vwdB0UFDpTpwwIsyRQyu9+Xk W99+mhHXF0SVMsNL1yx6dh5EK+OYcYNo++xll+BiCxZcBx9ijpmsuLUIo6/It+7IbkE8 d51A== X-Gm-Message-State: AO0yUKXeghN6W3c04hihtiLPl2c83K5CRhJwB2pEUdBH27FzYHeMcHNV j6Hz3+S3WxuYR9cz8RKa7QLYCi7qqorkUzpVn6VRmnTXlFEkq0sU6eFJRkmo3Y282olG2Ppd8x/ Lqp40HjVBFUFTnuqRWPU= X-Received: by 2002:a65:438d:0:b0:50b:e523:3cd2 with SMTP id m13-20020a65438d000000b0050be5233cd2mr996045pgp.11.1678982152285; Thu, 16 Mar 2023 08:55:52 -0700 (PDT) X-Google-Smtp-Source: AK7set/ngIsJ9w8PaE27VCSbGB06R8f/bvjmuw1wsCDdQIOHnfyehgR/VVDbFluCR6MzsKKNAa+C9I5oSSuoGwNileA= X-Received: by 2002:a65:438d:0:b0:50b:e523:3cd2 with SMTP id m13-20020a65438d000000b0050be5233cd2mr996041pgp.11.1678982152061; Thu, 16 Mar 2023 08:55:52 -0700 (PDT) MIME-Version: 1.0 References: <20230313093450.2560058-1-vfialko@marvell.com> <20230313130428.2650232-1-vfialko@marvell.com> In-Reply-To: <20230313130428.2650232-1-vfialko@marvell.com> From: David Marchand Date: Thu, 16 Mar 2023 16:55:41 +0100 Message-ID: Subject: Re: [PATCH v2] reorder: fix registration of dynamic field in mbuf To: Volodymyr Fialko Cc: dev@dpdk.org, Reshma Pattan , Andrew Rybchenko , jerinj@marvell.com, anoobj@marvell.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Mar 13, 2023 at 2:05=E2=80=AFPM Volodymyr Fialko wrote: > > It's possible to initialize reorder buffer with user allocated memory via > rte_reorder_init() function. In such case rte_reorder_create() is not > required and reorder dynamic field in rte_mbuf will not be registered. > > Both reorder lib and mbuf dynamic field are using `rte_mcfg_tailq` > read/write lock for synchronization, to avoid deadlocking move reorder > buffer initialization before queue insertion. > > Fixes: 01f3496695b5 ("reorder: switch sequence number to dynamic mbuf fie= ld") > Cc: stable@dpdk.org > > Signed-off-by: Volodymyr Fialko Applied, thanks Volodymyr. --=20 David Marchand