From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDB70A046B for ; Fri, 28 Jun 2019 21:20:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA6C31B9B5; Fri, 28 Jun 2019 21:20:37 +0200 (CEST) Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by dpdk.org (Postfix) with ESMTP id E509E1B9B3 for ; Fri, 28 Jun 2019 21:20:36 +0200 (CEST) Received: by mail-ua1-f54.google.com with SMTP id j2so2602892uaq.5 for ; Fri, 28 Jun 2019 12:20:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xKwA1PgxFS6wSmOLwLtOW7Z7Gye02g8nOgc6zM8d6iM=; b=bxLJG8fZVndByhy+tciRyYpSNSS8En24YYhc0rDLYkl1qh0l0EWw8eM0bxsc3oW9pK egpkAIi+dBzC5mZOGdQR2BqyWhgIvPk/+GJaKflRL6Sc5PFbNoJhGq4N+XT9C0l9NeJK oMbkvosqD2iFwU+APO9rQRXsniYMA6HB2Q8nxJXBjFje7gYbKwxtYo3dctISjuniVrUC erCyJnfeu4htwOvrnrqwPZBKscIw/kl6/K2XmWYxRSUPsS3Y1JzQ/1qQyeRNc2kZ2BMu q1jQXcG73NGZKksd9FjHvUGRDd93XRxpzaDkplB5mpq3cmFjx6mSs8vUbNv5hKI4U6NE 9d6w== X-Gm-Message-State: APjAAAX3DTTQQJfGVswHP8SPUHW/gGUlrUd2/8TANNuVclpY2WLBzBXr y1KEmirvbZMeZsrMGWBSwG76QNrya2ueIhiKKTmfxQ== X-Google-Smtp-Source: APXvYqx83Bz38XeeMcUIu/543RMcHXtOAAQ3Ok4xxpE3fOQA/k12r4WscVfwRkVitcwG5IoJ47nIM6Ul02kPN3NXoB0= X-Received: by 2002:ab0:2bc6:: with SMTP id s6mr6827345uar.86.1561749636306; Fri, 28 Jun 2019 12:20:36 -0700 (PDT) MIME-Version: 1.0 References: <1561635235-22238-1-git-send-email-david.marchand@redhat.com> <1561635235-22238-9-git-send-email-david.marchand@redhat.com> <2284715.k64COaWSDv@xps> In-Reply-To: <2284715.k64COaWSDv@xps> From: David Marchand Date: Fri, 28 Jun 2019 21:20:25 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Neil Horman , Aaron Conole , John McNamara , Marko Kovacevic , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Konstantin Ananyev , Amr Mokhtar , Fiona Trahe , Pablo de Lara , Ashish Gupta , Declan Doherty , Anatoly Burakov , Harry van Haaren , Bruce Richardson , Ferruh Yigit , Andrew Rybchenko , Adrien Mazarguil , Cristian Dumitrescu , Nikhil Rao , Jerin Jacob , Bernard Iremonger , Yipeng Wang , Sameh Gobriel , Olivier Matz , David Hunt , Honnappa Nagarahalli , Akhil Goyal , Kevin Laatz , Robert Sanford , Erik Gabriel Carrillo , Maxime Coquelin , Tiwei Bie , Zhihong Wang Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 8/9] remove experimental tags from all symbol definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 28, 2019 at 5:57 PM Thomas Monjalon wrote: > 27/06/2019 13:33, David Marchand: > > We had some inconsistencies between functions prototypes and actual > > definitions. > > Let's avoid this by only adding the experimental tag to the prototypes. > > Tests with gcc and clang show it is enough. > > > > git grep -l __rte_experimental |grep \.c$ |while read file; do > > sed -i -e '/^__rte_experimental$/d' $file; > > sed -i -e 's/ *__rte_experimental//' $file; > > sed -i -e 's/__rte_experimental *//' $file; > > done > > There is one miss: > > rte_telemetry_parse is not flagged as experimental > but is listed in version map > Please add __rte_experimental to the definition of rte_telemetry_parse > Not sure I get you. How did you get this warning? -- David Marchand