From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32E6C43CA0; Wed, 13 Mar 2024 15:13:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E713B40A84; Wed, 13 Mar 2024 15:13:06 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E44D5402B8 for ; Wed, 13 Mar 2024 15:13:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710339184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rof+zzyDDtJdAlR33Ln3zKtqR/0OLRkLtVu7GCWNHXo=; b=Olsfq5SMKkKAY7Fq23Jl2/+eA3p5itpBi0/BPQURuInESHlVNuSMbKch2YWOYaqVnl7Sez Rft3peVcbcwRqGSyVZPAm/k2sGeg1VDvFBOOwseu01ZvK5ARSsFonhb+dj0frQXDcVygNM jEV8VRDc7deeT7YyGL3106OWnH/1kFU= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-3ePyQIIiP6KYVbzXSby4zw-1; Wed, 13 Mar 2024 10:13:03 -0400 X-MC-Unique: 3ePyQIIiP6KYVbzXSby4zw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2d416cc9d5cso53462021fa.2 for ; Wed, 13 Mar 2024 07:13:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710339181; x=1710943981; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rof+zzyDDtJdAlR33Ln3zKtqR/0OLRkLtVu7GCWNHXo=; b=sLH9yDcdi4Av1kLfhXJ2dmAOfAb+JrtGJHzKwYgXej/MsQ94lXvANA9BzVUlRhj+lC r2coYZVGvCCm13s+tA9smdeMKcFfUhw/Tplwy510io/VdObG3rgawqPsIHPQKtK0YXWi frOy3mKokyuCNFZgkl/puRegG3YwNRoHPFSzKPjQ9PO1yjRxEE93uEhTCjKb5A+4HpVT zfeIov+T08sn+0CdflGsL6GfFCc1uO9KLhUIDez6vLlU8hlkFxK8MRe7XSaHElwTvKAU yOfuxzyyrJ3TWW3/JstfGLurambBN23AsOdI5pJHQCeA8JMuZ4hth37U7LhmfuXfosop 5olQ== X-Gm-Message-State: AOJu0YzPusM0z6CBNpHb51N8TOfaPh80rnwUEUVapKEKmJCC+4sUWgWS 7p4YnaxQFVSifW47TDsiJELcel7+qSiIUOAiamVhP/c8KEZ2atr9Ywygpef05v5lRmjWZ0d2kyz 9OmiUr5mjVAX3gidMzqH8ZrGo5jgAOa7KV+6U1FOmGXIFcNW5BKNr1sdo30rp2Fv7V2BGGjnzrl IXpZiK7nKfH/7Yhd8= X-Received: by 2002:ac2:58c3:0:b0:513:a766:4643 with SMTP id u3-20020ac258c3000000b00513a7664643mr3294593lfo.11.1710339181470; Wed, 13 Mar 2024 07:13:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnGfCh6XoqSwcm6ctlg6loCdQeOy3VvfXXNyqKHhO1M2MG+0B1Df+5VdPlMqszZQe7fBVxNSfQYdJhciGz2XM= X-Received: by 2002:ac2:58c3:0:b0:513:a766:4643 with SMTP id u3-20020ac258c3000000b00513a7664643mr3294578lfo.11.1710339181165; Wed, 13 Mar 2024 07:13:01 -0700 (PDT) MIME-Version: 1.0 References: <20240313125932.1878279-1-maxime.coquelin@redhat.com> <20240313125932.1878279-2-maxime.coquelin@redhat.com> In-Reply-To: <20240313125932.1878279-2-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 13 Mar 2024 15:12:49 +0100 Message-ID: Subject: Re: [PATCH v2 1/2] net/virtio: fix vDPA device init advertising control queue To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com, schalla@marvell.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 13, 2024 at 1:59=E2=80=AFPM Maxime Coquelin wrote: > > If the vDPA device advertises control queue support, but > the user neither passes "cq=3D1" as devarg nor requests > multiple queues, the initialization fails because the > driver tries to setup the control queue without negotiating > related feature. > > This patch enables the control queue at driver level as > soon as the device claims to support it, and not only when > multiple queue pairs are requested. Also, enable the > control queue event if multiqueue feature has not been > negotiated and device start time, and disable it at device > stop time. > > Fixes: b277308e8868 ("net/virtio-user: advertise control VQ support with = vDPA") > Cc: stable@dpdk.org > > Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand --=20 David Marchand