From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D401A00C2; Thu, 6 Oct 2022 09:57:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33EAF42B88; Thu, 6 Oct 2022 09:57:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B13EC41153 for ; Thu, 6 Oct 2022 09:57:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665043068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dJPqR40YoNJ3Pq60+Sk2nJcSwaN53x9zdZUia7bzb4s=; b=TmlPDmzoLVTZwqJ5Vv9KzudsxRO4q+sL3uXnIuYdEfHXpU7GQnsEINCdHWvaxNegdus4Pq IfTp2woEqeFQ0KdnAieq7yWqJ/C5+nx19L0xOledJYIST5ggSZxuymTjKOfugSkp9NzYfP 4vYqwe8fmYjchqaJY2fqkjpRGCvnwMA= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-160-fSlxEbiZNDSTi4TPZaDJfQ-1; Thu, 06 Oct 2022 03:57:47 -0400 X-MC-Unique: fSlxEbiZNDSTi4TPZaDJfQ-1 Received: by mail-pg1-f197.google.com with SMTP id h2-20020a656382000000b0044b0f6c572fso737735pgv.20 for ; Thu, 06 Oct 2022 00:57:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=dJPqR40YoNJ3Pq60+Sk2nJcSwaN53x9zdZUia7bzb4s=; b=4Q+Yzgxz6avSznXVHWFlPNl4tNP3a6pVx6KTaqg0NtWGUIM8i4HQ6l34+xs3GLdwcj ItgB7qODfZ2y3GRgi8W9h3bKCD4gKK63D2l3H+1j8m9XXtmvPEvoGOJIYhXv8ue+S1o3 5mLvasbqGs+K1z2m8QNTUdEWcGFVvwToTAJW4ArCarywtvM1hyfa0ZFYNAsZx/k8DuMU D7x2Fld6sPk6/AlmqFD3iNGaD/b3wZP9e+bFZIKfugArSmPQ7Wh6SmR0gOp5Q4pldgg0 eJCjCE3xkSgTiQx0CZrKQkfliQpKKh68MhXmSx1OAMdxY9GVZDiKP9hpjqlogsa82OPQ desQ== X-Gm-Message-State: ACrzQf1LKBJKFBGJCW8xyY8LdKnIyujnrOctJNrc1NqBVp1wanaj/Eoq 8ba7gDCnzIPrbuHv4jSw66jaPUr+VH9WtU7DL9OhNGKFemPR/EsQxAJ2P8R6QunUcwij+pzWgDd oOEGkKfMcYkK+v7Q1ESw= X-Received: by 2002:aa7:86cf:0:b0:561:4b7b:4745 with SMTP id h15-20020aa786cf000000b005614b7b4745mr3855258pfo.29.1665043066045; Thu, 06 Oct 2022 00:57:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Hg+Gp9SeyNg0posg8adjB7BRYc3XpQj7UQVUgeMrP9hP8OofAM6tzO59SnECGNUchx/9c4LYKyvLdf8mUndU= X-Received: by 2002:aa7:86cf:0:b0:561:4b7b:4745 with SMTP id h15-20020aa786cf000000b005614b7b4745mr3855241pfo.29.1665043065782; Thu, 06 Oct 2022 00:57:45 -0700 (PDT) MIME-Version: 1.0 References: <20220804134430.6192-1-adwivedi@marvell.com> <20220929102936.5490-1-adwivedi@marvell.com> <20220929102936.5490-2-adwivedi@marvell.com> <6bee8943-408e-a930-f053-541af8bed6d0@oktetlabs.ru> <7369fc89-6588-8898-ed2d-91329248e2b6@oktetlabs.ru> In-Reply-To: From: David Marchand Date: Thu, 6 Oct 2022 09:57:34 +0200 Message-ID: Subject: Re: [EXT] Re: [PATCH v2 1/4] ethdev: add trace points To: Andrew Rybchenko , Jerin Jacob Kollanukkaran Cc: Ankur Dwivedi , "dev@dpdk.org" , Thomas Monjalon , Ferruh Yigit , Ray Kinsella X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 6, 2022 at 9:50 AM Andrew Rybchenko wrote: > >>>>> diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map index > >>>>> 3def7bfd24..e3d603cc9a 100644 > >>>>> --- a/lib/ethdev/version.map > >>>>> +++ b/lib/ethdev/version.map > >>>>> @@ -288,6 +288,150 @@ EXPERIMENTAL { > >>>>> > >>>>> # added in 22.11 > >>>>> rte_flow_async_action_handle_query; > >>>>> + __rte_eth_trace_add_first_rx_callback; > >>>> > >>>> Why is it in EXPERIMENTAL section, but not INTERNAL? > >>> [Ankur] Because the functions for which trace is added are not internal > >> functions. > >> > >> Sorry, but I don't understand. I agree that tracing of public inline functions > >> must be part of ABI, but why everything else should be a part of ABI? > > [Ankur] I see that there are some already existing trace functions added in EXPERIMENTAL in version.map like __rte_ethdev_trace_configure, __rte_ethdev_trace_rxq_setup. So not sure will it be internal or experimental. > > > > But you are right the trace function will not be called as a public api. Should I make the newly added trace as internal then? > > @David, do I understand correctly that trace points in > EXPERIMENTAL is a mistake in majority of cases? The trace point global variables (__rte_trace_foo) are only exposed for inline helpers that might call their associated trace point helper (rte_trace_foo()). An application is not supposed to directly manipulate them. Any tp manipulation should be through the rte_trace_point_* API. Jerin, do you see any other uses for them? If not, I agree we can mark all those INTERNAL. I can send a cleanup post rc1. -- David Marchand