DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check
@ 2019-09-17 22:24 Tianfei zhang
  2019-10-24 19:22 ` David Marchand
  2019-10-25  2:40 ` Ye Xiaolong
  0 siblings, 2 replies; 8+ messages in thread
From: Tianfei zhang @ 2019-09-17 22:24 UTC (permalink / raw)
  To: dev; +Cc: Tianfei zhang, stable

Add pointer null check before dereference.

Coverity issue: 344976
Fixes: 12f92a51 ("raw/ifpga/base: fix retimer link status")
Cc: stable@dpdk.org

Signed-off-by: Tianfei zhang <tianfei.zhang@intel.com>
---
 drivers/raw/ifpga/base/opae_eth_group.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/raw/ifpga/base/opae_eth_group.c b/drivers/raw/ifpga/base/opae_eth_group.c
index d189dd578..be28954e0 100644
--- a/drivers/raw/ifpga/base/opae_eth_group.c
+++ b/drivers/raw/ifpga/base/opae_eth_group.c
@@ -308,9 +308,8 @@ struct eth_group_device *eth_group_probe(void *base)
 
 void eth_group_release(struct eth_group_device *dev)
 {
-	eth_group_hw_uinit(dev);
-
 	if (dev) {
+		eth_group_hw_uinit(dev);
 		dev->status = ETH_GROUP_DEV_NOUSED;
 		opae_free(dev);
 	}
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-10-28  5:51 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-17 22:24 [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check Tianfei zhang
2019-10-24 19:22 ` David Marchand
2019-10-25  1:05   ` Xu, Rosen
2019-10-25  2:40 ` Ye Xiaolong
2019-10-25 10:29   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-10-25 11:47     ` David Marchand
2019-10-25 12:16       ` Thomas Monjalon
2019-10-28  5:47         ` Ye Xiaolong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).