From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1447845B9F; Tue, 22 Oct 2024 12:08:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEA684029B; Tue, 22 Oct 2024 12:08:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 297854029A for ; Tue, 22 Oct 2024 12:08:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729591718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BkcpGY3yatiobGekNkrF4KpOP1ZZ3+ClBdNjP6d5azQ=; b=YJgurx7eawmB3ls34OufhVAOGw0EoPiWdKTckbK8WTAwL/1Ora31JjyFtJJsmqxIPPU9pn n8wg4HLAskFnZaWg+G1QNPggJiZ3uFjc/jg6aVePeESCjiAQSyGzHIi4GGJkHS+gYIprHF s9d/LcOAI8g0+qkLLNTJw95FiGr0GMM= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-lEykL99ROFGAfKOBWcqVBw-1; Tue, 22 Oct 2024 06:08:35 -0400 X-MC-Unique: lEykL99ROFGAfKOBWcqVBw-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-539ead6c504so3198085e87.3 for ; Tue, 22 Oct 2024 03:08:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729591714; x=1730196514; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BkcpGY3yatiobGekNkrF4KpOP1ZZ3+ClBdNjP6d5azQ=; b=XI7Cv9V/Dd9Ah0NfWXeMlmyBSgV5vib2GYk4f/9WLmWfSVR9L978BN0QsExaWLV71q w9tohUVzgiN7R383aLgHm9QdcmhIVCxqp8Um9gdDERER/Klno1MPAjT/3ZPXfy59NFCf 6GC0JC2wUbrOHhmc/G/WxbOtBtKvXoVGJPaX+XkQZhBxrSCN1urPDYkedcTColjXRfUb gWYeiSGKGzwDzsErW1qN9HivuuPVOG68erfq1I6JgCQjY727Uy4++ExUFZYaIuJJyQa/ QfUxKmIpvZhXI7Ma6VKhTvpA/ZPQMuOpIbu5BbF1AAS+Qq2+v9L6kHBXtqb6DXc2aCqn RWSQ== X-Forwarded-Encrypted: i=1; AJvYcCVIbudIOC+SgnIwBWHhEvIDDwfkatkQvr/5k+Nah/nG4RVArPQy+tVxGScIlmpy6NACjY4=@dpdk.org X-Gm-Message-State: AOJu0YxzwabUI8hJ/ucjXXietueHBfIv6qW93TY5OxTzIJSrOPxKOg44 h6S09EYcn4DmWiurj46nm8nAXG8ZH59LolzWCrpSx5gfMFtKakX1mkFIG2juQ38+pJh4/N8UFza vZIYbwIGt9x4swNMRCUlnU0RdesW1NC71sMEXsD5zFGGcs4jMrywzHN0/kla/3q8YuPQTiMo90T Ck6dkNNCR8mNxnSn4= X-Received: by 2002:a05:6512:3b06:b0:539:8ad5:5093 with SMTP id 2adb3069b0e04-53a15231e1cmr8365322e87.35.1729591713655; Tue, 22 Oct 2024 03:08:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHU+jYIOw4CA06Uafl+sy6Gj2kggYlsthvNM3W0LW6OMvFjkyHa1vGKJeIG2AE32ibOvze/mkEaoBSn4gQUAXE= X-Received: by 2002:a05:6512:3b06:b0:539:8ad5:5093 with SMTP id 2adb3069b0e04-53a15231e1cmr8365292e87.35.1729591713235; Tue, 22 Oct 2024 03:08:33 -0700 (PDT) MIME-Version: 1.0 References: <20241008105415.1026962-1-gakhil@marvell.com> <20241008184915.1356089-1-gakhil@marvell.com> <20241008184915.1356089-4-gakhil@marvell.com> <86546386.BzKH3j3Lxt@thomas> In-Reply-To: From: David Marchand Date: Tue, 22 Oct 2024 12:08:22 +0200 Message-ID: Subject: Re: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses To: Akhil Goyal Cc: Jerin Jacob , Thomas Monjalon , "dev@dpdk.org" , Jerin Jacob , Harman Kalra , Stephen Hemminger , Bruce Richardson , Hemant Agrawal , Sachin Saxena , Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 22, 2024 at 8:06=E2=80=AFAM Akhil Goyal wr= ote: > > The rational to NOT pull "Hardware abstraction library using the BAR > > address" to DPDK are > > -Yet another 200K of driver C++ code which does not make sense to keep > > in dpdk.org > > -It can not implemenent any of the current subsystems > > > > In this context, let me know what you think? This hardware abstraction library will have to call some driver specific API (like the added raw/cnxk_rvu API). Can this library directly use the PCI driver API, and call the cnxk common driver? If so, there is no need to add another driver API (that breaks layers), and the rawdev driver is only about adding the mailbox features. > > Just to add one more point. > Even if we don=E2=80=99t use this API, we can still get the BAR addresses= as David mentioned in another mail chain > rte_rawdev_info_get() -> get rte_device -> RTE_DEV_TO_PCI -> get bar addr > > This we can get for each raw PCI device, not just cnxk_rvu_lf. Right? Any PCI driver can do this (via bus_pci_driver.h header, exported with the enable_driver_sdk meson option). That's not exposed to application. Your abstraction library may cache this info if you think it will have an impact on fast path. --=20 David Marchand