From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Yipeng Wang <yipeng1.wang@intel.com>,
mb@smartsharesystems.com, fengchengwen@huawei.com,
Dodji Seketeli <dodji@redhat.com>
Subject: Re: [PATCH v2 0/4] more replacement of zero length array
Date: Fri, 16 Feb 2024 11:14:27 +0100 [thread overview]
Message-ID: <CAJFAV8wBoL9hgr6XBsGdsfmvN56OjAj=XaFZOVm_=Wzb6ZUDvg@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8w49GYAgsiPLEoBdyeAFDa5uneO-NwNdyc8yFhceONKHQ@mail.gmail.com>
On Wed, Feb 14, 2024 at 8:36 AM David Marchand
<david.marchand@redhat.com> wrote:
> > I'm okay with the change being merged but if there is concern I can drop
> > this patch from the series.
>
> At least, we can't merge it in the current form.
>
> If libabigail gets a fix quickly, DPDK CI will still need a released version.
> So for this patch to be merged now, we need a libabigail suppression rule.
> I don't see a way to precisely waive this issue, so my suggestion is
> to silence any change on the concerned structure here (which should be
> ok, as the pipeline library data struct have been super stable for a
> couple of years).
> Something like:
>
> $ git diff
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index 21b8cd6113..d667157909 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -33,3 +33,5 @@
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> ; Temporary exceptions till next major ABI version ;
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> +[suppress_type]
> + name = rte_pipeline_table_entry
Dodji confirmed the issue in libabigail and prepared a fix.
DPDK still needs a suppression rule (like the one proposed above) if
we want to merge this change before the libabigail fix makes it to all
distribs.
Please resubmit this series with my proposal and a comment pointing at
libabigail bz squashed in patch 4.
--
David Marchand
next prev parent reply other threads:[~2024-02-16 10:14 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 22:17 [PATCH 0/2] " Tyler Retzlaff
2024-01-24 22:17 ` [PATCH 1/2] hash: replace zero length array with flex array Tyler Retzlaff
2024-01-24 22:57 ` Honnappa Nagarahalli
2024-01-25 7:16 ` Morten Brørup
2024-01-24 22:17 ` [PATCH 2/2] rcu: " Tyler Retzlaff
2024-01-24 22:57 ` Honnappa Nagarahalli
2024-01-25 7:14 ` Morten Brørup
2024-01-25 12:57 ` [PATCH 0/2] more replacement of zero length array fengchengwen
2024-02-12 22:36 ` [PATCH v2 0/4] " Tyler Retzlaff
2024-02-12 22:36 ` [PATCH v2 1/4] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-12 22:36 ` [PATCH v2 2/4] rcu: " Tyler Retzlaff
2024-02-12 22:36 ` [PATCH v2 3/4] fib: " Tyler Retzlaff
2024-02-12 22:36 ` [PATCH v2 4/4] pipeline: " Tyler Retzlaff
2024-02-12 22:57 ` [PATCH v2 0/4] more replacement of zero length array Stephen Hemminger
2024-02-13 8:31 ` Morten Brørup
2024-02-13 13:14 ` David Marchand
2024-02-13 19:20 ` Tyler Retzlaff
2024-02-14 7:36 ` David Marchand
2024-02-16 10:14 ` David Marchand [this message]
2024-02-16 20:46 ` Tyler Retzlaff
2024-02-18 12:31 ` Dodji Seketeli
2024-02-27 23:56 ` [PATCH v3 0/6] " Tyler Retzlaff
2024-02-27 23:56 ` [PATCH v3 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-27 23:56 ` [PATCH v3 2/6] rcu: " Tyler Retzlaff
2024-02-27 23:56 ` [PATCH v3 3/6] fib: " Tyler Retzlaff
2024-02-27 23:56 ` [PATCH v3 4/6] pipeline: " Tyler Retzlaff
2024-02-27 23:56 ` [PATCH v3 5/6] lpm: " Tyler Retzlaff
2024-02-28 7:26 ` Morten Brørup
2024-02-27 23:56 ` [PATCH v3 6/6] table: " Tyler Retzlaff
2024-02-28 7:27 ` Morten Brørup
2024-02-29 22:58 ` [PATCH v4 0/6] more replacement of zero length array Tyler Retzlaff
2024-02-29 22:58 ` [PATCH v4 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-29 22:58 ` [PATCH v4 2/6] rcu: " Tyler Retzlaff
2024-02-29 22:58 ` [PATCH v4 3/6] fib: " Tyler Retzlaff
2024-02-29 22:58 ` [PATCH v4 4/6] pipeline: " Tyler Retzlaff
2024-02-29 22:58 ` [PATCH v4 5/6] lpm: " Tyler Retzlaff
2024-03-01 8:12 ` Morten Brørup
2024-02-29 22:58 ` [PATCH v4 6/6] table: " Tyler Retzlaff
2024-03-01 8:13 ` Morten Brørup
2024-03-06 19:39 ` [PATCH v4 0/6] more replacement of zero length array Tyler Retzlaff
2024-03-06 20:13 ` [PATCH v5 " Tyler Retzlaff
2024-03-06 20:13 ` [PATCH v5 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-03-06 20:52 ` Medvedkin, Vladimir
2024-03-06 20:13 ` [PATCH v5 2/6] rcu: " Tyler Retzlaff
2024-03-06 20:13 ` [PATCH v5 3/6] fib: " Tyler Retzlaff
2024-03-06 20:53 ` Medvedkin, Vladimir
2024-03-06 20:13 ` [PATCH v5 4/6] pipeline: " Tyler Retzlaff
2024-03-06 20:13 ` [PATCH v5 5/6] lpm: " Tyler Retzlaff
2024-03-06 20:53 ` Medvedkin, Vladimir
2024-03-06 20:13 ` [PATCH v5 6/6] table: " Tyler Retzlaff
2024-06-11 15:15 ` [PATCH v5 0/6] more replacement of zero length array David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wBoL9hgr6XBsGdsfmvN56OjAj=XaFZOVm_=Wzb6ZUDvg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=dodji@redhat.com \
--cc=fengchengwen@huawei.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
--cc=sameh.gobriel@intel.com \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).