From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3356943B30; Fri, 16 Feb 2024 11:14:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A37DB4064A; Fri, 16 Feb 2024 11:14:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D4044402DD for ; Fri, 16 Feb 2024 11:14:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708078483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XLCZl8QSNinm7J+aSVSgBlirJfZ17SA97C+WQ6NPjhM=; b=QjLXvmywt0pyALFnekXz1dnqqfQzFfagk0fhgm76EKw3bHU7/CxagYeVVomFWs9IzgSq7q rkyl3RHueZehtljICg6GAh1WYzqKTlcdAkRa0TiVA5McoNkGG3daRxzO5vLgep4z9XikQR TG5lojuK6ZWWh+d+PErdBjSCkDEpnUA= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-wGv2sQuHP0OBS_MtPa5WQg-1; Fri, 16 Feb 2024 05:14:41 -0500 X-MC-Unique: wGv2sQuHP0OBS_MtPa5WQg-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2d218f545aaso3431851fa.2 for ; Fri, 16 Feb 2024 02:14:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708078480; x=1708683280; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XLCZl8QSNinm7J+aSVSgBlirJfZ17SA97C+WQ6NPjhM=; b=esYVerA+7+WmCJjjTnbKcLk11EJHlMjWEgKQ9Qp4bw31plwfU/Q/LZokOMxLHdNRNt a4nTsx/OcKJRQL0yNporaRFrjCsQ5JuLPKbyoTZk8PYWIC5Lfo938hoMBT13jQMNiste hkbMU0ygfi41b5mPlN4yajg0E3vPBh88Y1k9MAFHknCZ7nHKDJRTaBMsNsOrqZRd5rQa 3viFDOnYxTxXnHTFnysoMfQYvHHzttIHc5wtWlLYGFedlVqWIVADVaDFAouL29zLGLoB Tm/+/XH8HibVHPSNobKsuVUqsQI/dVtRqkc2/JgQBoGwIsmXMV8oVSnhOAJUxyDhfW5J drag== X-Gm-Message-State: AOJu0Yy++szItq86+m3ZIUaj1TE9DKbL6flSxcEeKyn0wfNdg7JkA4l8 4tHnjcFPqqaplcHiCzBVS0Q41BrHP23UC/UngdSPdEQtX0LRqBX90sROOrwG+8EQfIPyYaV8XMv 2HwDyzMoR9XKRdS/8cYWFgUlw6JMoL1+p5LIQUvo8xfixlcdnMT3RtDcPxAgXWCx3SLM0vogK5o e6Y1rZJaq+pthkQKw= X-Received: by 2002:a2e:9156:0:b0:2d0:c37b:edc3 with SMTP id q22-20020a2e9156000000b002d0c37bedc3mr3017363ljg.33.1708078480425; Fri, 16 Feb 2024 02:14:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGl2kyRN55gWNqGz7gB0lYtGmYBgvSDPpVmRjqGNU9lpMAdxtGlszO3DKyPUiXqLcFF7JUC8LlGUEiG8JGxA8g= X-Received: by 2002:a2e:9156:0:b0:2d0:c37b:edc3 with SMTP id q22-20020a2e9156000000b002d0c37bedc3mr3017349ljg.33.1708078480127; Fri, 16 Feb 2024 02:14:40 -0800 (PST) MIME-Version: 1.0 References: <1706134657-17446-1-git-send-email-roretzla@linux.microsoft.com> <1707777366-26000-1-git-send-email-roretzla@linux.microsoft.com> <20240213192042.GA24086@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: From: David Marchand Date: Fri, 16 Feb 2024 11:14:27 +0100 Message-ID: Subject: Re: [PATCH v2 0/4] more replacement of zero length array To: Tyler Retzlaff Cc: dev@dpdk.org, Bruce Richardson , Cristian Dumitrescu , Honnappa Nagarahalli , Sameh Gobriel , Vladimir Medvedkin , Yipeng Wang , mb@smartsharesystems.com, fengchengwen@huawei.com, Dodji Seketeli X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 14, 2024 at 8:36=E2=80=AFAM David Marchand wrote: > > I'm okay with the change being merged but if there is concern I can dro= p > > this patch from the series. > > At least, we can't merge it in the current form. > > If libabigail gets a fix quickly, DPDK CI will still need a released vers= ion. > So for this patch to be merged now, we need a libabigail suppression rule= . > I don't see a way to precisely waive this issue, so my suggestion is > to silence any change on the concerned structure here (which should be > ok, as the pipeline library data struct have been super stable for a > couple of years). > Something like: > > $ git diff > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index 21b8cd6113..d667157909 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -33,3 +33,5 @@ > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > ; Temporary exceptions till next major ABI version ; > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > +[suppress_type] > + name =3D rte_pipeline_table_entry Dodji confirmed the issue in libabigail and prepared a fix. DPDK still needs a suppression rule (like the one proposed above) if we want to merge this change before the libabigail fix makes it to all distribs. Please resubmit this series with my proposal and a comment pointing at libabigail bz squashed in patch 4. --=20 David Marchand