From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A176145C11; Wed, 30 Oct 2024 09:22:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 860504333C; Wed, 30 Oct 2024 09:22:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 841314332E for ; Wed, 30 Oct 2024 09:22:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730276548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NHx/4vmQYXETqvlUy2VxBDNR9ww0BtXN5ViO9PzqoA8=; b=P90fYMwFOVCyhy3+X9vqrNiwaiQsyXYHNQgxhA8DQNQ+6SZZ0u4RWlpquNjiW3t+7nF4Tx SscuAalWMRioITHKRvunLDpACLEzpMyZCsma+SLT885jzxYUVx9wAJEI1vep9zHo/3sebD go+nY4zHyrNpcD8ZaabXDAi2usf5zJU= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-tVFrlIGmPmK7FxIAa_z40Q-1; Wed, 30 Oct 2024 04:22:24 -0400 X-MC-Unique: tVFrlIGmPmK7FxIAa_z40Q-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2fb5bd1c324so41819541fa.3 for ; Wed, 30 Oct 2024 01:22:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730276543; x=1730881343; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NHx/4vmQYXETqvlUy2VxBDNR9ww0BtXN5ViO9PzqoA8=; b=WUfMt213RjuQA/bwMj0kGuP2fWLoVeAyzrnsd3VDNCcAD79UBUeIbJtq5hwxGccuDM rDDPWkzydvQT4kF26UAW65f54WHVx9W6VYQBuPsUDmHyWwEkY+S6gpgveGHFwiuUN1LP 2SOQvTRcVv2OOCp1jKoxjlBkDlCcQ92UAATbG+IQz6QDyfjuKiJfZOfMzxiLScYjf6CF GH4czyiyMZZ7nUIjHtgYgzN+6/9zRlvPVmoElyJBVyWz5J/kWW0gTi7tjoIcBF8jUZos rfuejqE46nDsTUkx2JZmilKyVzudOS8hUx3pke8H9J1Jwi79jvWR9ANg76xmC/XpNiIE LVTA== X-Gm-Message-State: AOJu0YwZXZ1p1mPuEUHPPK5psCNFOD7QylfC+3URiK2J/j9YgR1YWM1P otc6GbxEcCAJcCEIhZD8OXcmPV/2byuZAp/LqXyPlk7KSR40tSWrqKyJfbCfCua74ub6HYR+8wU ooa3ZKz/mIpYFcQiipYp+xUiMMnGKdSzbcBSQk/ReYD4MuRf30dTrR/37jTke/HsoADXelw2WA3 VT5JENoMisboCRyTM= X-Received: by 2002:a2e:515a:0:b0:2fa:be1a:a4b0 with SMTP id 38308e7fff4ca-2fcbdfd8152mr55088101fa.21.1730276543011; Wed, 30 Oct 2024 01:22:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF79CsZ9y0duw7wMqFSKWUyITmpyHBdU/dcav9Wdw82umRI3/4ft2odfFf1RYRfOYWuM2hlj94M4A8E9rUH1rQ= X-Received: by 2002:a2e:515a:0:b0:2fa:be1a:a4b0 with SMTP id 38308e7fff4ca-2fcbdfd8152mr55087991fa.21.1730276542596; Wed, 30 Oct 2024 01:22:22 -0700 (PDT) MIME-Version: 1.0 References: <20241017142214.1669370-1-bruce.richardson@intel.com> <20241025165020.1856733-1-bruce.richardson@intel.com> In-Reply-To: <20241025165020.1856733-1-bruce.richardson@intel.com> From: David Marchand Date: Wed, 30 Oct 2024 09:22:11 +0100 Message-ID: Subject: Re: [PATCH v2 0/6] Reduce scope address-of-packed-member warning To: Bruce Richardson Cc: dev@dpdk.org, Stephen Hemminger , Konstantin Ananyev , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Chengwen Feng X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 25, 2024 at 6:51=E2=80=AFPM Bruce Richardson wrote: > > The warning for address-of-packed-member was being disabled globally in > DPDK. While for drivers which need to access hardware-defined > data-structures the use of packed may make sense, for normal libs and > applications the use of packed data should be generally avoided. > > This patchset initially applies some fixes for cases where we are > unnecessarily causing the warning to trigger. Thereafter the 6th patch > removes the global enabling of the warning and replaces it with more > selective disabling for drivers and for a couple of other components > which have not yet been fixed. > > v2: > * rebase on latest main (rte_ip.h -> rte_ip4.h) > * remove unnecessary 0-check in IP checksum calc > > Bruce Richardson (6): > ip_frag: remove use of unaligned variable > efd: remove unnecessary packed attributes > bus/ifpga: remove packed attribute > pipeline: remove packed attribute > net: add smaller IPv4 cksum function for simple cases > build: limit scope of packed member warning disabling > > app/test-eventdev/test_pipeline_common.c | 25 +----------- > app/test-pmd/icmpecho.c | 23 +---------- > app/test-pmd/txonly.c | 22 +---------- > app/test/packet_burst_generator.c | 49 +----------------------- > app/test/test_reassembly_perf.c | 29 +------------- > config/meson.build | 1 - > drivers/bus/ifpga/bus_ifpga_driver.h | 2 +- > drivers/meson.build | 9 +++-- > examples/ipsec-secgw/meson.build | 6 +++ > lib/efd/rte_efd.c | 4 +- > lib/ip_frag/rte_ipv4_reassembly.c | 4 +- > lib/net/rte_ip4.h | 32 ++++++++++++++++ > lib/pipeline/rte_table_action.c | 2 +- > lib/vhost/meson.build | 5 ++- > 14 files changed, 59 insertions(+), 154 deletions(-) Series applied, thanks Bruce. --=20 David Marchand