From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4ACFBA04B5; Thu, 29 Oct 2020 13:36:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95787CAF8; Thu, 29 Oct 2020 13:36:02 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id A65A9CAB6 for ; Thu, 29 Oct 2020 13:36:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603974960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Cr6b0CuP/xn5sFKv9eICCLpq4tgidc4o5J6Oon/oW4g=; b=Eat3b1gDiwOKnPC9KoN9258RYJOsuMiIm6MIJscERlLhJjkiOxfaFqBStoA5XY2UTnJsuH SSZDlrutWBAJcyX1oj5lRcZ6060YxS/k5BS3coPb72eLgSNraeRCSqDFaJItqSdJHCRRd4 STWgRzvnZ65BszW/roI46cJ3dXn31d4= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-302-prheQ_rzMs6nWJ3egOxVfA-1; Thu, 29 Oct 2020 08:35:57 -0400 X-MC-Unique: prheQ_rzMs6nWJ3egOxVfA-1 Received: by mail-vk1-f197.google.com with SMTP id l7so713491vki.0 for ; Thu, 29 Oct 2020 05:35:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cr6b0CuP/xn5sFKv9eICCLpq4tgidc4o5J6Oon/oW4g=; b=LW3FXp6XNBvcdqsIUj2rzmPqvVgU1VQpxNiIVZJHHwmhrrxunEElqyqCV/m5XYBWgL KCP+E4vF73AgRBV1AJdOcFpFAQyusPovInbq2TjI2FNdADAOQDxYJsb7ZbXYTWdZCgc6 LAlpPxbfK58zQWwSHfxhEwyFHte3UHnbzRGrjqz6WF9ERTTkFZAW+ch6KFxhF/2kEGx+ PEqQvy06OJdJcFhNQI1KOeEfo9/QPOu1YCQdjBqbwH0xVftaIK6EDrTf7X86s13Ge/lL poqAkNIdb+uq6wY+JBvXbJs785DbKKQ5sezjTard6RRf+D1jb1qsnKUlx6XheE8gIwl8 x+yg== X-Gm-Message-State: AOAM533FZ3xLJVTIri9Z/7L4+7+0yAHs7CUGwZhpL4I44jsb1RE9joNK 3hAqIUPULdKCmFC4vXglenSn0zd8WAkY0B/Ek4ZMP5LrUHGmH1k6rOSWntnDYi/g1S74glVZf10 xUE8d2GoFUSwPqVDXr+k= X-Received: by 2002:a67:d78b:: with SMTP id q11mr2503658vsj.17.1603974957086; Thu, 29 Oct 2020 05:35:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVUUFiTIM7hG3JKvlQ5pEsgcyKZ76cy2iUmjFY1Ful8GyljhhZOSci3SNBD3DytAlRfhGpGkDhCApN3KRqGBc= X-Received: by 2002:a67:d78b:: with SMTP id q11mr2503643vsj.17.1603974956861; Thu, 29 Oct 2020 05:35:56 -0700 (PDT) MIME-Version: 1.0 References: <20200224203931.21256-1-honnappa.nagarahalli@arm.com> <20201025054556.14277-1-honnappa.nagarahalli@arm.com> <20201025054556.14277-6-honnappa.nagarahalli@arm.com> In-Reply-To: From: David Marchand Date: Thu, 29 Oct 2020 13:35:45 +0100 Message-ID: To: Honnappa Nagarahalli Cc: "Ananyev, Konstantin" , dev , Stephen Hemminger , Dharmik Thakkar , "Ruifeng Wang (Arm Technology China)" , Olivier Matz , nd Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 5/8] doc/ring: add zero copy peek APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 29, 2020 at 12:29 PM Ananyev, Konstantin wrote: > > On Sun, Oct 25, 2020 at 6:46 AM Honnappa Nagarahalli > > wrote: > > > +.. code-block:: c > > > + > > > + /* Reserve space on the ring */ > > > + n = rte_ring_enqueue_zc_burst_start(r, 32, &zcd, NULL); > > > + /* Pkt I/O core polls packets from the NIC */ > > > + if (n != 0) { > > > + nb_rx = rte_eth_rx_burst(portid, queueid, zcd->ptr1, zcd->n1); > > > + if (nb_rx == zcd->n1 && n != zcd->n1) > > > + nb_rx = rte_eth_rx_burst(portid, queueid, zcd->ptr2, > > > + n - zcd->n1); > > > > Should it be nb_rx += ? > > Yes, it should. > Good catch No need for a respin, I can fix. -- David Marchand