From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) by dpdk.org (Postfix) with ESMTP id 1ADFE11A4 for ; Sun, 24 Mar 2019 18:13:29 +0100 (CET) Received: by mail-ua1-f44.google.com with SMTP id b8so2253488uaq.7 for ; Sun, 24 Mar 2019 10:13:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TsCU2/oz9r3Fe2w5NltouffR6pztG4R+8BhUtwnRkdc=; b=pjLnboDcDQaBSOjuGMVSyX0CEzJewssGk7f5EUEfDJ7SgRW1Ov50YBD21xxcx8P3qD uZSWx7eX0ZFhG51Y3xo3vCVaXe7Q+lN6oSR3IcioxbxvO4+I4wov5LoCX+byG0JX+MCA 5DrxmtuF4T+GksQF+sA/8ITRuXkmJ73nJDZL+9AzXNfCNaH+ihPLIbBwn5a0MD1JdMOb hJwUB5inMskSERpr9OnCo44HbGRf0DPQBGUTSjOWshS4z+t8OG25fHDefxk83T8izHj5 xL6jXi9a7SirjJ9sUfj46pI9X/eVQZxVQ6vzg8KZY7Clu5L1hNJ6WxrVWhOWEdKPaW+2 Rs6g== X-Gm-Message-State: APjAAAXmvC9o7clRv5RidtsUapYEdJEym3gdAL+iTBWAlLCDuunNL2cI ZKX2xakdyxXJXbHouhF8lDXKYLUM08GZbxksz7uGTw== X-Google-Smtp-Source: APXvYqx2XJeTGwTi2siWASb0oSJKfYIgwcEmaHb2stxoRFHtW0g6Hq8sWtvpXiYhCPiAtkJzsJ4pdiPL73f4QqQMz3s= X-Received: by 2002:ab0:6419:: with SMTP id x25mr7203707uao.86.1553447608530; Sun, 24 Mar 2019 10:13:28 -0700 (PDT) MIME-Version: 1.0 References: <1553200094-5487-1-git-send-email-david.marchand@redhat.com> <8001e759-dfc7-28f7-3a14-80d6af8943a5@gmail.com> In-Reply-To: <8001e759-dfc7-28f7-3a14-80d6af8943a5@gmail.com> From: David Marchand Date: Sun, 24 Mar 2019 18:13:17 +0100 Message-ID: To: Chas Williams <3chas3@gmail.com> Cc: dev , "Yigit, Ferruh" , chas3@att.com, "Zhaohui (zhaohui, Polestar)" , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/2] net/bonding: fix more incorrect slave id types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Mar 2019 17:13:29 -0000 On Sun, Mar 24, 2019 at 2:28 PM Chas Williams <3chas3@gmail.com> wrote: > See inline. > > On 3/21/19 4:28 PM, David Marchand wrote: > > From: Zhaohui > > > > mode_bond_id and mode_band_id are slave ids, stored on 16bits. > > Please change mode_bond_id to mode_count_id in this commit message. > Otherwise, this looks fine. > Indeed... I should have gone to bed earlier ;-) -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 07857A05D3 for ; Sun, 24 Mar 2019 18:13:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3ED73137D; Sun, 24 Mar 2019 18:13:31 +0100 (CET) Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) by dpdk.org (Postfix) with ESMTP id 1ADFE11A4 for ; Sun, 24 Mar 2019 18:13:29 +0100 (CET) Received: by mail-ua1-f44.google.com with SMTP id b8so2253488uaq.7 for ; Sun, 24 Mar 2019 10:13:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TsCU2/oz9r3Fe2w5NltouffR6pztG4R+8BhUtwnRkdc=; b=pjLnboDcDQaBSOjuGMVSyX0CEzJewssGk7f5EUEfDJ7SgRW1Ov50YBD21xxcx8P3qD uZSWx7eX0ZFhG51Y3xo3vCVaXe7Q+lN6oSR3IcioxbxvO4+I4wov5LoCX+byG0JX+MCA 5DrxmtuF4T+GksQF+sA/8ITRuXkmJ73nJDZL+9AzXNfCNaH+ihPLIbBwn5a0MD1JdMOb hJwUB5inMskSERpr9OnCo44HbGRf0DPQBGUTSjOWshS4z+t8OG25fHDefxk83T8izHj5 xL6jXi9a7SirjJ9sUfj46pI9X/eVQZxVQ6vzg8KZY7Clu5L1hNJ6WxrVWhOWEdKPaW+2 Rs6g== X-Gm-Message-State: APjAAAXmvC9o7clRv5RidtsUapYEdJEym3gdAL+iTBWAlLCDuunNL2cI ZKX2xakdyxXJXbHouhF8lDXKYLUM08GZbxksz7uGTw== X-Google-Smtp-Source: APXvYqx2XJeTGwTi2siWASb0oSJKfYIgwcEmaHb2stxoRFHtW0g6Hq8sWtvpXiYhCPiAtkJzsJ4pdiPL73f4QqQMz3s= X-Received: by 2002:ab0:6419:: with SMTP id x25mr7203707uao.86.1553447608530; Sun, 24 Mar 2019 10:13:28 -0700 (PDT) MIME-Version: 1.0 References: <1553200094-5487-1-git-send-email-david.marchand@redhat.com> <8001e759-dfc7-28f7-3a14-80d6af8943a5@gmail.com> In-Reply-To: <8001e759-dfc7-28f7-3a14-80d6af8943a5@gmail.com> From: David Marchand Date: Sun, 24 Mar 2019 18:13:17 +0100 Message-ID: To: Chas Williams <3chas3@gmail.com> Cc: dev , "Yigit, Ferruh" , chas3@att.com, "Zhaohui (zhaohui, Polestar)" , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/2] net/bonding: fix more incorrect slave id types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190324171317.wJh_-r1AByjXpezKp7ARgjs7e8qLLaEJDaa0zHIav0Q@z> On Sun, Mar 24, 2019 at 2:28 PM Chas Williams <3chas3@gmail.com> wrote: > See inline. > > On 3/21/19 4:28 PM, David Marchand wrote: > > From: Zhaohui > > > > mode_bond_id and mode_band_id are slave ids, stored on 16bits. > > Please change mode_bond_id to mode_count_id in this commit message. > Otherwise, this looks fine. > Indeed... I should have gone to bed earlier ;-) -- David Marchand