DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Beilei Xing <beilei.xing@intel.com>, Qi Zhang <qi.z.zhang@intel.com>
Cc: dpdk stable <stable@dpdk.org>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/i40e: fix dropped packets statistics name
Date: Tue, 11 Jun 2019 13:15:57 +0200	[thread overview]
Message-ID: <CAJFAV8wCiwnVr+sk0cX4empFJGo1XPkzawZ0h=-0aiPx+3Kdkw@mail.gmail.com> (raw)
In-Reply-To: <1559550688-9290-1-git-send-email-david.marchand@redhat.com>

Hello guys,

Can you review this patch please?

Thanks.

On Mon, Jun 3, 2019 at 10:32 AM David Marchand <david.marchand@redhat.com>
wrote:

> i40e and i40evf currently use two different names for the statistic on
> dropped packets on the rx and tx sides.
> Let's prefer i40evf so that all statistics are suffixed with _packets.
>
> This also avoids a statistic name conflict in OVS.
>
> Fixes: f4a91c38b4ad ("i40e: add extended stats")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c
> b/drivers/net/i40e/i40e_ethdev.c
> index 7fa9e1b..2384d4d 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -526,13 +526,13 @@ struct rte_i40e_xstats_name_off {
>         {"rx_unicast_packets", offsetof(struct i40e_eth_stats,
> rx_unicast)},
>         {"rx_multicast_packets", offsetof(struct i40e_eth_stats,
> rx_multicast)},
>         {"rx_broadcast_packets", offsetof(struct i40e_eth_stats,
> rx_broadcast)},
> -       {"rx_dropped", offsetof(struct i40e_eth_stats, rx_discards)},
> +       {"rx_dropped_packets", offsetof(struct i40e_eth_stats,
> rx_discards)},
>         {"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats,
>                 rx_unknown_protocol)},
>         {"tx_unicast_packets", offsetof(struct i40e_eth_stats,
> tx_unicast)},
>         {"tx_multicast_packets", offsetof(struct i40e_eth_stats,
> tx_multicast)},
>         {"tx_broadcast_packets", offsetof(struct i40e_eth_stats,
> tx_broadcast)},
> -       {"tx_dropped", offsetof(struct i40e_eth_stats, tx_discards)},
> +       {"tx_dropped_packets", offsetof(struct i40e_eth_stats,
> tx_discards)},
>  };
>
>  #define I40E_NB_ETH_XSTATS (sizeof(rte_i40e_stats_strings) / \
> --
> 1.8.3.1
>
>

-- 
David Marchand

  parent reply	other threads:[~2019-06-11 11:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03  8:31 [dpdk-dev] " David Marchand
2019-06-03  8:31 ` [dpdk-dev] [PATCH 2/2] net/ice: " David Marchand
2019-06-03  8:52   ` [dpdk-dev] [dpdk-stable] " Eelco Chaudron
2019-06-18 14:02     ` Zhang, Qi Z
2019-06-03  8:52 ` [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/i40e: " Eelco Chaudron
2019-06-11 11:15 ` David Marchand [this message]
2019-06-12  1:34 ` [dpdk-dev] " Xing, Beilei
2019-06-18 13:59   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8wCiwnVr+sk0cX4empFJGo1XPkzawZ0h=-0aiPx+3Kdkw@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).