From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7C1CAA00E6 for ; Tue, 11 Jun 2019 13:16:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C59E01C3D2; Tue, 11 Jun 2019 13:16:09 +0200 (CEST) Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id 1A92B1C3C3 for ; Tue, 11 Jun 2019 13:16:09 +0200 (CEST) Received: by mail-vk1-f194.google.com with SMTP id x129so2397649vkc.11 for ; Tue, 11 Jun 2019 04:16:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gI9ItzrSNAo+lozWU/3O0evLtjMOpiThpoMBruwRiOo=; b=cuNdWZNWencFxYr2ro91wtOO1WaMI3IWzbUDN6xRhF5nOIyKz9u/V1EYkSIqyfhico GacCk36g4K0CdD22N05muPAOZht9EDTAxFnYW7cIl53z24rVN+2tUpze4AWzFoSJVAJ+ CiT/sPqosQ2YO4p/zIdVXa2B3MVv8X1OQb6ASzCF0JjtvpWDTGz2NN8wpo4UJlGYk5US 2Q+wGV1iE9kRyuFZ9Kxxh5pmJ56S5tKBP2OsF/0ZJ1xyOTRJQNg0o+7JsakLKfibrEm8 XeTL9gnVgf2uF+yfYNynlO3p2HJAD8vhDd2vJqpROCu2FhYMUH4SIk8SGc7jAS+LV3Jd 73TA== X-Gm-Message-State: APjAAAUgocBAB7t3x7/zMBvbM7mGYAfkpMGMvTjwl9DOapsg5nEJDq8q GzqkN85JRJ0GMaG2FlOFF/0rEQvuuAycKdSJXDBREg== X-Google-Smtp-Source: APXvYqzS8CV/f/8OcPvHg6aA/fjdB3281r+sY1Ym3CoC4Y7gnR0ZKMVcUe9Gruysa6T3ftx7nw6vOBxrcFKuSlvtZlg= X-Received: by 2002:a1f:a54f:: with SMTP id o76mr29260650vke.86.1560251768483; Tue, 11 Jun 2019 04:16:08 -0700 (PDT) MIME-Version: 1.0 References: <1559550688-9290-1-git-send-email-david.marchand@redhat.com> In-Reply-To: <1559550688-9290-1-git-send-email-david.marchand@redhat.com> From: David Marchand Date: Tue, 11 Jun 2019 13:15:57 +0200 Message-ID: To: Beilei Xing , Qi Zhang Cc: dpdk stable , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/i40e: fix dropped packets statistics name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello guys, Can you review this patch please? Thanks. On Mon, Jun 3, 2019 at 10:32 AM David Marchand wrote: > i40e and i40evf currently use two different names for the statistic on > dropped packets on the rx and tx sides. > Let's prefer i40evf so that all statistics are suffixed with _packets. > > This also avoids a statistic name conflict in OVS. > > Fixes: f4a91c38b4ad ("i40e: add extended stats") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > drivers/net/i40e/i40e_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c > b/drivers/net/i40e/i40e_ethdev.c > index 7fa9e1b..2384d4d 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -526,13 +526,13 @@ struct rte_i40e_xstats_name_off { > {"rx_unicast_packets", offsetof(struct i40e_eth_stats, > rx_unicast)}, > {"rx_multicast_packets", offsetof(struct i40e_eth_stats, > rx_multicast)}, > {"rx_broadcast_packets", offsetof(struct i40e_eth_stats, > rx_broadcast)}, > - {"rx_dropped", offsetof(struct i40e_eth_stats, rx_discards)}, > + {"rx_dropped_packets", offsetof(struct i40e_eth_stats, > rx_discards)}, > {"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats, > rx_unknown_protocol)}, > {"tx_unicast_packets", offsetof(struct i40e_eth_stats, > tx_unicast)}, > {"tx_multicast_packets", offsetof(struct i40e_eth_stats, > tx_multicast)}, > {"tx_broadcast_packets", offsetof(struct i40e_eth_stats, > tx_broadcast)}, > - {"tx_dropped", offsetof(struct i40e_eth_stats, tx_discards)}, > + {"tx_dropped_packets", offsetof(struct i40e_eth_stats, > tx_discards)}, > }; > > #define I40E_NB_ETH_XSTATS (sizeof(rte_i40e_stats_strings) / \ > -- > 1.8.3.1 > > -- David Marchand