* [dpdk-dev] [PATCH] net/ixgbe: fix rss_conf sizeof argument
@ 2019-08-07 7:47 Congwen Zhang
2019-08-07 8:40 ` Ye Xiaolong
2019-08-07 8:41 ` David Marchand
0 siblings, 2 replies; 5+ messages in thread
From: Congwen Zhang @ 2019-08-07 7:47 UTC (permalink / raw)
To: wenzhuo.lu, konstantin.ananyev; +Cc: dev, Congwen Zhang
The type of rss_conf is struct ixgbe_rte_flow_rss_conf *,
not struct rte_eth_rss_conf *.
Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
---
drivers/net/ixgbe/ixgbe_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index 92377b8..b2a2bfc 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
/* check if the next not void item is END */
act = next_no_void_action(actions, act);
if (act->type != RTE_FLOW_ACTION_TYPE_END) {
- memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
+ memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf));
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION,
act, "Not supported action.");
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix rss_conf sizeof argument
2019-08-07 7:47 [dpdk-dev] [PATCH] net/ixgbe: fix rss_conf sizeof argument Congwen Zhang
@ 2019-08-07 8:40 ` Ye Xiaolong
2019-08-07 8:41 ` David Marchand
1 sibling, 0 replies; 5+ messages in thread
From: Ye Xiaolong @ 2019-08-07 8:40 UTC (permalink / raw)
To: Congwen Zhang; +Cc: wenzhuo.lu, konstantin.ananyev, dev
On 08/07, Congwen Zhang wrote:
>The type of rss_conf is struct ixgbe_rte_flow_rss_conf *,
> not struct rte_eth_rss_conf *.
Please add the fix tag and cc stable@dpdk.org.
>
>Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
>---
> drivers/net/ixgbe/ixgbe_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
>index 92377b8..b2a2bfc 100644
>--- a/drivers/net/ixgbe/ixgbe_flow.c
>+++ b/drivers/net/ixgbe/ixgbe_flow.c
>@@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
> /* check if the next not void item is END */
> act = next_no_void_action(actions, act);
> if (act->type != RTE_FLOW_ACTION_TYPE_END) {
>- memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
>+ memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf));
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ACTION,
> act, "Not supported action.");
>--
>1.8.3.1
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix rss_conf sizeof argument
2019-08-07 7:47 [dpdk-dev] [PATCH] net/ixgbe: fix rss_conf sizeof argument Congwen Zhang
2019-08-07 8:40 ` Ye Xiaolong
@ 2019-08-07 8:41 ` David Marchand
2019-08-07 8:57 ` Ye Xiaolong
1 sibling, 1 reply; 5+ messages in thread
From: David Marchand @ 2019-08-07 8:41 UTC (permalink / raw)
To: Congwen Zhang; +Cc: Wenzhuo Lu, Ananyev, Konstantin, dev
On Wed, Aug 7, 2019 at 10:28 AM Congwen Zhang <zhang.congwen@zte.com.cn> wrote:
>
> The type of rss_conf is struct ixgbe_rte_flow_rss_conf *,
> not struct rte_eth_rss_conf *.
What is the actual issue?
Does it deserve a Fixes: tag?
>
> Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
> ---
> drivers/net/ixgbe/ixgbe_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> index 92377b8..b2a2bfc 100644
> --- a/drivers/net/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> @@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
> /* check if the next not void item is END */
> act = next_no_void_action(actions, act);
> if (act->type != RTE_FLOW_ACTION_TYPE_END) {
> - memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
> + memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf));
Not sure what the maintainer prefers, but I would go with:
+ memset(rss_conf, 0, sizeof(*rss_conf));
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ACTION,
> act, "Not supported action.");
> --
> 1.8.3.1
>
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix rss_conf sizeof argument
2019-08-07 8:41 ` David Marchand
@ 2019-08-07 8:57 ` Ye Xiaolong
2019-08-07 8:58 ` David Marchand
0 siblings, 1 reply; 5+ messages in thread
From: Ye Xiaolong @ 2019-08-07 8:57 UTC (permalink / raw)
To: David Marchand; +Cc: Congwen Zhang, Wenzhuo Lu, Ananyev, Konstantin, dev
On 08/07, David Marchand wrote:
>On Wed, Aug 7, 2019 at 10:28 AM Congwen Zhang <zhang.congwen@zte.com.cn> wrote:
>>
>> The type of rss_conf is struct ixgbe_rte_flow_rss_conf *,
>> not struct rte_eth_rss_conf *.
>
>What is the actual issue?
>Does it deserve a Fixes: tag?
>
>>
>> Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
>> ---
>> drivers/net/ixgbe/ixgbe_flow.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
>> index 92377b8..b2a2bfc 100644
>> --- a/drivers/net/ixgbe/ixgbe_flow.c
>> +++ b/drivers/net/ixgbe/ixgbe_flow.c
>> @@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
>> /* check if the next not void item is END */
>> act = next_no_void_action(actions, act);
>> if (act->type != RTE_FLOW_ACTION_TYPE_END) {
>> - memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
>> + memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf));
>
>Not sure what the maintainer prefers, but I would go with:
>+ memset(rss_conf, 0, sizeof(*rss_conf));
>
Since all other occurrences of memset in ixgbe_flow.c are using
memset(aaa, 0, sizeof(struct bbb))
format, maybe it's better to make it consistent with others.
Thanks,
Xiaolong
>> rte_flow_error_set(error, EINVAL,
>> RTE_FLOW_ERROR_TYPE_ACTION,
>> act, "Not supported action.");
>> --
>> 1.8.3.1
>>
>
>--
>David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix rss_conf sizeof argument
2019-08-07 8:57 ` Ye Xiaolong
@ 2019-08-07 8:58 ` David Marchand
0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2019-08-07 8:58 UTC (permalink / raw)
To: Ye Xiaolong; +Cc: Congwen Zhang, Wenzhuo Lu, Ananyev, Konstantin, dev
On Wed, Aug 7, 2019 at 10:57 AM Ye Xiaolong <xiaolong.ye@intel.com> wrote:
>
> On 08/07, David Marchand wrote:
> >On Wed, Aug 7, 2019 at 10:28 AM Congwen Zhang <zhang.congwen@zte.com.cn> wrote:
> >>
> >> The type of rss_conf is struct ixgbe_rte_flow_rss_conf *,
> >> not struct rte_eth_rss_conf *.
> >
> >What is the actual issue?
> >Does it deserve a Fixes: tag?
> >
> >>
> >> Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
> >> ---
> >> drivers/net/ixgbe/ixgbe_flow.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> >> index 92377b8..b2a2bfc 100644
> >> --- a/drivers/net/ixgbe/ixgbe_flow.c
> >> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> >> @@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
> >> /* check if the next not void item is END */
> >> act = next_no_void_action(actions, act);
> >> if (act->type != RTE_FLOW_ACTION_TYPE_END) {
> >> - memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
> >> + memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf));
> >
> >Not sure what the maintainer prefers, but I would go with:
> >+ memset(rss_conf, 0, sizeof(*rss_conf));
> >
>
> Since all other occurrences of memset in ixgbe_flow.c are using
> memset(aaa, 0, sizeof(struct bbb))
> format, maybe it's better to make it consistent with others.
Yes, fine with me.
A better commitlog is still needed though.
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-07 8:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07 7:47 [dpdk-dev] [PATCH] net/ixgbe: fix rss_conf sizeof argument Congwen Zhang
2019-08-07 8:40 ` Ye Xiaolong
2019-08-07 8:41 ` David Marchand
2019-08-07 8:57 ` Ye Xiaolong
2019-08-07 8:58 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).