From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 817E0A00E6 for ; Wed, 7 Aug 2019 10:58:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F94A3257; Wed, 7 Aug 2019 10:58:58 +0200 (CEST) Received: from mail-vs1-f65.google.com (mail-vs1-f65.google.com [209.85.217.65]) by dpdk.org (Postfix) with ESMTP id 2E6893256 for ; Wed, 7 Aug 2019 10:58:56 +0200 (CEST) Received: by mail-vs1-f65.google.com with SMTP id 190so60194392vsf.9 for ; Wed, 07 Aug 2019 01:58:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S48BBVu2+w+Hx5CPRzGNmvRgDo/QHTK7E0cy5/HBzAc=; b=WGP3JpJYVL64NQtbDhog1vb0dvKqQREnQkdHsWcaCCIXa3yathAXapX37aJ/uV2M5O BmCdZpS3Qk6QJhUvTRQIgA+5gxNDD9PVV9H+hvl24vdaUaWRdzxHUnzgXxgmAamyoWR7 UAM+HxoknvD6ERvhRkTabxMH8K/mac3cNfM+GO88CLxQ3BRz4QXmLPgBPH827HcZ2T1T NsVcrZKVrNT423vPYMngxlP5xEiJFXYRCDsOIbGA/a4kwBcZXVDxYeKKx6zfl7nUTjkX p3cd3ELzvCU/CEd3gAhAUel0/JDryJCwhGJA3EKvFoaYF64ENunfHQavuXcDtQ3arCSn rcig== X-Gm-Message-State: APjAAAW84H3RxleIAAcn+dyFCKkktj+oeB1jc8JKekYLT7uVBnsE6cMc XlkvgDale7dJ7j+MCRoE5l6rlWRlg/ErFoEIW30R5g== X-Google-Smtp-Source: APXvYqzjHkqcSkw1C+3P63cPdMBxffoL5vzvQjt5+tR9ngbqyEMNCgsnAbxSAI/1HOJL/td9lbQpm4e9c1ea30lc87A= X-Received: by 2002:a67:2ec8:: with SMTP id u191mr5398141vsu.39.1565168335601; Wed, 07 Aug 2019 01:58:55 -0700 (PDT) MIME-Version: 1.0 References: <1565164045-27992-1-git-send-email-zhang.congwen@zte.com.cn> <20190807085703.GC73775@intel.com> In-Reply-To: <20190807085703.GC73775@intel.com> From: David Marchand Date: Wed, 7 Aug 2019 10:58:44 +0200 Message-ID: To: Ye Xiaolong Cc: Congwen Zhang , Wenzhuo Lu , "Ananyev, Konstantin" , dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix rss_conf sizeof argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 7, 2019 at 10:57 AM Ye Xiaolong wrote: > > On 08/07, David Marchand wrote: > >On Wed, Aug 7, 2019 at 10:28 AM Congwen Zhang wrote: > >> > >> The type of rss_conf is struct ixgbe_rte_flow_rss_conf *, > >> not struct rte_eth_rss_conf *. > > > >What is the actual issue? > >Does it deserve a Fixes: tag? > > > >> > >> Signed-off-by: Congwen Zhang > >> --- > >> drivers/net/ixgbe/ixgbe_flow.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c > >> index 92377b8..b2a2bfc 100644 > >> --- a/drivers/net/ixgbe/ixgbe_flow.c > >> +++ b/drivers/net/ixgbe/ixgbe_flow.c > >> @@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[]) > >> /* check if the next not void item is END */ > >> act = next_no_void_action(actions, act); > >> if (act->type != RTE_FLOW_ACTION_TYPE_END) { > >> - memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf)); > >> + memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf)); > > > >Not sure what the maintainer prefers, but I would go with: > >+ memset(rss_conf, 0, sizeof(*rss_conf)); > > > > Since all other occurrences of memset in ixgbe_flow.c are using > memset(aaa, 0, sizeof(struct bbb)) > format, maybe it's better to make it consistent with others. Yes, fine with me. A better commitlog is still needed though. -- David Marchand