From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B800241C49; Thu, 9 Feb 2023 08:41:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2FEA40DDA; Thu, 9 Feb 2023 08:41:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B97854067B for ; Thu, 9 Feb 2023 08:41:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675928503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1RiC7F6MBQQs9jCfcg6AsvbCgYlOW5P65SWrE8GOwUo=; b=g79gvJQwPuRHeLvMD4fgCOhjIsYvTOF0CIrjzk+uMywy6JHa2U/xHMA/LANYwxx5rsiIkj 5yDujBAijWoxkFdurDxjTG2AvCDOCYI5VxOh77Fki3zvecOgdxsKQ/2fjuqFsihvXrV7G7 NNrDsL1RIQTCMK6U8iNhKhlzx1bpR/k= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-458-r7e5MHQYPL2px8qrHv4rqg-1; Thu, 09 Feb 2023 02:41:32 -0500 X-MC-Unique: r7e5MHQYPL2px8qrHv4rqg-1 Received: by mail-pj1-f71.google.com with SMTP id oa13-20020a17090b1bcd00b0023120cf3c2dso1632580pjb.3 for ; Wed, 08 Feb 2023 23:41:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1RiC7F6MBQQs9jCfcg6AsvbCgYlOW5P65SWrE8GOwUo=; b=aQyrSu3bKs6jeL5DYwAC1hYiXaWt+IoNTJDzAKnflaipmK/OsU2KVI6OVCPbuwXuGG sozWCUhG9wzRbfKe1sQDOkUizYjg4ih1DPFGX8GCJJgCiD5IHHx3BZJs7+ExBkLEgf4l QkfKvYhsJw6jGnNSZD/a2MzolWq8smPF1wfAUd5hr1sLRUNPSGCBqcsitytfPZGkUlyK 3gJjYWmKpOHm9TJjANtpeXijRM9D7cHHo7AZwJLKT6ZIFMx+hQjVLIPLzdqXCLZWYUO+ bUpWkyyEV38aahIAh0020O1Gv4grgsbfy4u1vlevXyKNEN3YpYGVeO8pnNK0V96x0g3d AxGg== X-Gm-Message-State: AO0yUKUJjtyENvgl8q5LR7fCGs5HGz4ehvveelCb9Ebvgok7+dXYBOK2 70RTBHVsYLL6chrL0EbPO6HafnCgY85Ni8OIde1qUqc2/5WekN8zk6sxkg/tPcvw1ZcxgRAR+06 U37npKpidw8c625HktPI= X-Received: by 2002:a62:1dcc:0:b0:593:f5e4:8d93 with SMTP id d195-20020a621dcc000000b00593f5e48d93mr2550966pfd.4.1675928491502; Wed, 08 Feb 2023 23:41:31 -0800 (PST) X-Google-Smtp-Source: AK7set/mX9ZxxrTyi/cSNznpPoSDKAvsu8W4Kf2RZD7pVL4ay68X7hkd7EU1IF3qPXQyrXeEF/lA3EsFkd/7MLkWd4c= X-Received: by 2002:a62:1dcc:0:b0:593:f5e4:8d93 with SMTP id d195-20020a621dcc000000b00593f5e48d93mr2550955pfd.4.1675928491212; Wed, 08 Feb 2023 23:41:31 -0800 (PST) MIME-Version: 1.0 References: <20230209012533.45962-1-fengchengwen@huawei.com> In-Reply-To: <20230209012533.45962-1-fengchengwen@huawei.com> From: David Marchand Date: Thu, 9 Feb 2023 08:41:19 +0100 Message-ID: Subject: Re: [PATCH] telemetry: fix repeat display when callback don't init dict To: Chengwen Feng Cc: thomas@monjalon.net, ferruh.yigit@amd.com, dev@dpdk.org, ciara.power@intel.com, bruce.richardson@intel.com, Robin Jarry X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 9, 2023 at 2:31 AM Chengwen Feng wrote: > > When a telemetry callback doesn't initialize the telemetry data > structure and returns a non-negative number, the telemetry will repeat > to display the last result. This patch zero the data structure to avoid > the problem. > > Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > Reviewed-by: Bruce Richardson Applied, thanks. -- David Marchand