From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1946A04DC; Sat, 31 Oct 2020 18:09:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 854224CA6; Sat, 31 Oct 2020 18:09:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 4A8C04C96 for ; Sat, 31 Oct 2020 18:09:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604164174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K6WnuitjtvfQkKCY59WoUkYTwQGMIDMqgfuWkhAaSy0=; b=Nt/aUmQs1eGi1Vm9lDelErSQx1Bw2sg4kI6ZFpRQgc7gsGGZmwYpSQjq3sjaMoBLZDWt/i JGcEuEywD+DRUTUvfqhWSq2sUtT2mUjm+mW9aL9UjFzyo36BiEm8/1zVl4eftNPBa2d5sA bM8WjQmABnNojXzbg7SislV7yWnLgYs= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-232-ZHt3wC9uNMS9Z67Rjelvxw-1; Sat, 31 Oct 2020 13:09:32 -0400 X-MC-Unique: ZHt3wC9uNMS9Z67Rjelvxw-1 Received: by mail-vs1-f70.google.com with SMTP id u14so909917vsp.2 for ; Sat, 31 Oct 2020 10:09:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K6WnuitjtvfQkKCY59WoUkYTwQGMIDMqgfuWkhAaSy0=; b=eWtFzSLee2fPmlOQPpN9Bit2udwkqbycBooYOlgMObeWX7RGQOfOkOQIqBYPAF5YLu k5m7WLYNhYNxCcZtga61qIzxbDuKHnRU+ZY5zd+t4qRYvUO4w5kwWLcvAdvQ3Wnd6OB9 w9uABVwJVDv1ORcv2TEFYpDWs9/fPNjXaNyRfbz4zwxpO1SKXuN2nziT+4TJCLLeDBfH Pqs1WNyXvVfsorgCtYNAjoK7QSHSBGRDPGCDSuZ2nrUiWxajmuKKteafD0zBJl+OMpF4 sP5RhlLWZ7eBJs58POOup6JP8hMQHQ1A9t7os+s+BjMCG1ez3fd7nCBTrrjOxtlrAyZl g62g== X-Gm-Message-State: AOAM530fRFvdgB+RhdLSud/w2OioXqg71ylLCLSZGYHfv+FcDCl+gsiz 94xTJpQ23CDlxZS/TfPU3KZLaZwfrTgsBw1KHx8/jbKoHqDd9d1g6jEB/+568orLHgSmdb+0fBW 5kbg5pgkNifiM8ouEDv0= X-Received: by 2002:ab0:7313:: with SMTP id v19mr4338868uao.87.1604164172512; Sat, 31 Oct 2020 10:09:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHe3vHIro55LASHBH9/oBLYrWNTPWuugQx7e6UQ8v+RRZYnZVpp67WwP36iu22PtH1I845Q6Z5DzrIQJJrzlI= X-Received: by 2002:ab0:7313:: with SMTP id v19mr4338859uao.87.1604164172276; Sat, 31 Oct 2020 10:09:32 -0700 (PDT) MIME-Version: 1.0 References: <20201028153808.103328-1-ciara.power@intel.com> <20201030153700.267200-1-ciara.power@intel.com> In-Reply-To: <20201030153700.267200-1-ciara.power@intel.com> From: David Marchand Date: Sat, 31 Oct 2020 18:09:21 +0100 Message-ID: To: Ciara Power Cc: dev , Fan Zhang , Marko Kovacevic Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] examples/fips_validation: fix checking return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 30, 2020 at 4:37 PM Ciara Power wrote: > > The return value was not being checked when calling the > get_writeback_data function in the AES test case. On failure, this led > to a NULL dereference when using memcpy later. The return value is now > checked to avoid this NULL dereference. > > Coverity issue: 363463 > Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list") > > Signed-off-by: Ciara Power Reviewed-by: David Marchand Applied, thanks. -- David Marchand