From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 690A043731; Wed, 20 Dec 2023 09:26:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D0F140266; Wed, 20 Dec 2023 09:26:59 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9D9DA400EF for ; Wed, 20 Dec 2023 09:26:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703060817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eaY8Z1QlKrTfCpwvMMYfXEBARzCpjWOqdCYeKyFK+IA=; b=c2hcVW7C8QjWUq50T+Kb7BUiV3PFRi+rMSQqcG5kwJbF8dOZuhK1PQ+lhHS6IWCXpPNR86 8Hfqa/g3tCWb+b2eOrDOZDBEmeRwEJSKvld3jKI7th9wNtxnGb10c/zccmfdDtmlrS2Y34 GQgpuzPZgU0otSvHPWMHYjXnsF6g1x4= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-tTeULW10OOWRLQyjvfhe1Q-1; Wed, 20 Dec 2023 03:26:54 -0500 X-MC-Unique: tTeULW10OOWRLQyjvfhe1Q-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-50e40d1a6fbso1816719e87.3 for ; Wed, 20 Dec 2023 00:26:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703060813; x=1703665613; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eaY8Z1QlKrTfCpwvMMYfXEBARzCpjWOqdCYeKyFK+IA=; b=FVIuDDpZtJgk2LWxtrGaTzUP+HXcKnjuX6hvOdWtvaB1BKlIlBCW1uQ5+sfMiYTrF0 s2O3EimWBwDSay9C9fhzkjf45ew+wAf4Nw+AN6Qt9Muf8iTm2EgFA7g8hc2Afvn4lrPe Ese8iFG4ODT4tK3jVjkUFvtDleGkOkrx+TkzcbaRckzK6qGG9F7vJvNDmv17nQpgnWC9 EFNNdPsMp8fn3OR3jgUCFc1arUtwvhZcP6XtxYrWdH6d083QkrkgvLfb7WGqz2UQcVTx upOlr4tbEX7nxOc+o+CL1kp6DMq127C5rl62tyCiPeGzvqaEaorBgZAEbWVYVJmNJwBd R/EQ== X-Gm-Message-State: AOJu0Yz4t1q5FgbJzdQN2KsyYJ7IMmi2vaRpMynOUSfNZD4DDloVphAp SlhWiWBq0xzw9TQ+kjBe3+BWgUdRnEGkqJ70zPzpmXCNW/5VEsx8/9n/yEZZI2Zf8/mc9pNwV1b kOYkhdmHYHI7ow3pcN44= X-Received: by 2002:a05:6512:3b87:b0:50e:2cbd:cc50 with SMTP id g7-20020a0565123b8700b0050e2cbdcc50mr4103122lfv.23.1703060813533; Wed, 20 Dec 2023 00:26:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IGcy2W5MzQYlGQTqKSN60XIJw2n2OSM6HluDj/BjxlwJWaHWj44hLVNAFx5EnG0+nr23YBsMTifS+vVvnjYggM= X-Received: by 2002:a05:6512:3b87:b0:50e:2cbd:cc50 with SMTP id g7-20020a0565123b8700b0050e2cbdcc50mr4103111lfv.23.1703060813225; Wed, 20 Dec 2023 00:26:53 -0800 (PST) MIME-Version: 1.0 References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231218143805.1500121-1-david.marchand@redhat.com> <20231218143805.1500121-12-david.marchand@redhat.com> <3969116.88bMQJbFj6@thomas> <20231219091652.50ee264f@hermes.local> In-Reply-To: <20231219091652.50ee264f@hermes.local> From: David Marchand Date: Wed, 20 Dec 2023 09:26:41 +0100 Message-ID: Subject: Re: [PATCH v4 11/14] log: add a per line log helper To: Stephen Hemminger , Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@amd.com, bruce.richardson@intel.com, mb@smartsharesystems.com, Chengwen Feng X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 19, 2023 at 6:16=E2=80=AFPM Stephen Hemminger wrote: > > On Tue, 19 Dec 2023 16:45:19 +0100 > Thomas Monjalon wrote: > > > 18/12/2023 15:38, David Marchand: > > > +#ifdef RTE_TOOLCHAIN_GCC > > > +#define RTE_LOG_CHECK_NO_NEWLINE(fmt) \ > > > + static_assert(!__builtin_strchr(fmt, '\n'), \ > > > + "This log format string contains a \\n") > > > +#else > > > +#define RTE_LOG_CHECK_NO_NEWLINE(...) > > > +#endif > > > > No support in clang? > > clang has static assert, but probably not builtin_strchr clang seems to have support for __builtin_strchr (which was not obvious to me when I first looked at it). Testing with clang ("thanks" to net/mlx4), I realised that this check relies on some gnu extension (constant folding) which breaks compilation with -pedantic. An additional check on PEDANTIC is needed, and I can then add support for c= lang. --=20 David Marchand