From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AB4E7A0096 for ; Wed, 5 Jun 2019 12:32:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B68941B9B6; Wed, 5 Jun 2019 12:32:20 +0200 (CEST) Received: from mail-ua1-f68.google.com (mail-ua1-f68.google.com [209.85.222.68]) by dpdk.org (Postfix) with ESMTP id DEDE31B9AA for ; Wed, 5 Jun 2019 12:32:19 +0200 (CEST) Received: by mail-ua1-f68.google.com with SMTP id j2so5022474uaq.5 for ; Wed, 05 Jun 2019 03:32:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C+LnKJ+zPG+YVvDDbOgQdRqqLsrAzP8+TlgF6X9TUN4=; b=jfxWwxk+2j1UD5WOlI+1PCDcTouKn8ZoQ/gPM+6ZXlu+vI0CNdUTGqcoYq3ChG06Lx oBhULpXGQnEfRJNn4qzXBsJ8JsXD377H3pmL3s4u89g5mcVl0GxXgJoucE9EQKu+ZvCw 7A+gzShA+CnXotonQK8aVxmkt5K1jpxTsi/eIBaYvdrXeBSOjynK+/9/63MR8SbjdE8+ lP0uSQde12ph6tTN2JsndGQsX6DkBB0+Gq6aq5cEx0CVorK9x+vd9Ei/VKX6WE1TGe68 3YCGAu9f10H4AGK3xRPjY9HF0+AYqjHLsOFkGLiPb82N/bwqNo+g5PVin/oKmvF8PrbF gChw== X-Gm-Message-State: APjAAAVtLlqhwjCHyG184WsnLyzVXZw3LVgiKKGQlrmgu/Rt9IBT5e5z Rl6R2qO5eWv4ZCorFYEmxZUCaw/uy6H3dbIUrC6NdA== X-Google-Smtp-Source: APXvYqxaYlgn9EVMi2eT7P8nAbpWJQUin9aZt/0Tbd/65vlidCHkbHoIR8ki71s7C8N149vF7d0LRr+VsCttW5hx85s= X-Received: by 2002:ab0:168a:: with SMTP id e10mr5296385uaf.87.1559730739259; Wed, 05 Jun 2019 03:32:19 -0700 (PDT) MIME-Version: 1.0 References: <1559725576-6427-1-git-send-email-david.marchand@redhat.com> <2833528.hd4umUYrtg@xps> <1644587.V9St9GoDxq@xps> In-Reply-To: <1644587.V9St9GoDxq@xps> From: David Marchand Date: Wed, 5 Jun 2019 12:32:08 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Bruce Richardson , Anatoly Burakov Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] examples/multi_process: fix compilation error on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 5, 2019 at 11:52 AM Thomas Monjalon wrote: > 05/06/2019 11:36, David Marchand: > > On Wed, Jun 5, 2019 at 11:26 AM Thomas Monjalon > wrote: > > > > > 05/06/2019 11:06, David Marchand: > > > > Caught on FreeBSD 12: > > > > > > > > /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete > > > type > > > > struct in_addr ip_src,ip_dst; /* source and dest address */ > > > > ^~~~~~ > > > > > > > > POSIX defines netinet/in.h as the right header for in_addr. > > > > Linux seems fine without it but let's include it explicitly. > > > > > > > > Signed-off-by: David Marchand > > > > > > Please could you add a "Fixes:" tag with Cc stable? > > > > > > > We did not build the examples before. > > Not sure what to tag as the "culprit". > > The one that adds FreeBSD support ? > > I was thinking about the patch using in_addr so we can have a meaningful > backport. > I can't find the reason why this header is included and it goes back to the initial release. Removed this header include with a 1.2.3r0 and it builds fine :-) -- David Marchand