From: David Marchand <david.marchand@redhat.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Andre Muezerie <andremue@linux.microsoft.com>
Cc: Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
dev@dpdk.org, Raslan Darawsheh <rasland@nvidia.com>,
stable@dpdk.org
Subject: Re: [PATCH] net/mlx5: fix matcher flags in counter offset detection
Date: Wed, 27 Aug 2025 11:15:57 +0200 [thread overview]
Message-ID: <CAJFAV8wF0PT58zVDJDcmLcLz6Jt99rjexJOkFHBOmXNAhMw+vw@mail.gmail.com> (raw)
In-Reply-To: <20250820084521.1088620-1-dsosnowski@nvidia.com>
On Wed, 20 Aug 2025 at 10:47, Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:
>
> This patch fixes a bug in
> mlx5_flow_dv_discover_counter_offset_support()
> uncovered by a warning reported by MSVC:
>
> ../drivers/net/mlx5/mlx5_flow_dv.c(19636): warning C5287:
> operands are different enum types 'ibv_flow_attr_type' and
> 'ibv_flow_flags';
> use an explicit cast to silence this warning
>
> IBV_FLOW_ATTR_FLAGS_EGRESS was incorrectly passed in to
> type field of mlx5dv_flow_matcher_attr struct,
> instead of flags field.
> As a result counter offset support discovery returned a false positive
> result on application with old rdma-core.
>
> Bugzilla ID: 1758
> Fixes: 4fd5e1484887 ("net/mlx5: fix counter offset detection")
> Cc: suanmingm@nvidia.com
> Cc: stable@dpdk.org
>
> Reported-by: Andre Muezerie <andremue@linux.microsoft.com>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
I did not test the patch, but on the principle this lgtm.
Andre, can you confirm it solves the build warning you were seeing with MSVC?
--
David Marchand
prev parent reply other threads:[~2025-08-27 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 8:45 Dariusz Sosnowski
2025-08-27 9:15 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wF0PT58zVDJDcmLcLz6Jt99rjexJOkFHBOmXNAhMw+vw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=andremue@linux.microsoft.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).