From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8A86A04C4; Wed, 20 Nov 2019 23:31:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E725727D; Wed, 20 Nov 2019 23:31:12 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 4E536271 for ; Wed, 20 Nov 2019 23:31:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574289070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g+5DBFpjGdREQvt48Cz8V6FXIbUsd2FvhVhjQBFReY0=; b=CObMcpThxVI+aA2/ey5P5n9rC5eBoB+BkC6WyXb22XOqSgEYVQdSDbvzJM6D647zP+Rz89 id0cjxyMy73ecTiGUba5qxg2JbIUttyXK50oWafnPvAjW4gUuD9vitKp3HBh3q7ZJxdHmf YbNEmLkyrU5a1/OZSroV6Nj2fP/+DzM= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-OoCh3I47OdOZKS6o_6dFIw-1; Wed, 20 Nov 2019 17:31:05 -0500 Received: by mail-vk1-f199.google.com with SMTP id y75so512777vkc.0 for ; Wed, 20 Nov 2019 14:31:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=g+5DBFpjGdREQvt48Cz8V6FXIbUsd2FvhVhjQBFReY0=; b=MEso1BU1i5afVWiaKQcqaT/5nymZWRkYsbGbwUrxwvjU9SdiyZ4VDHVG6oNuZIGRdi n20xeAh9abLXMtp7xUgCC+zJmKchl4csla/rVFzOqfv/54HF7rLoOUMiOwqLFLMr/w6S IB1ufyt7Q9+BBN6xYVK8gCraQeQVfBmOSjrqXhIf8mj7FTjx4xBCebnck/DOMkn0bySD 2yawFSR1mk4+86IAmNjjic4b0wDAOpI/rZNrf48+hCBem0R2BpA9vlJx3Dx24gsD2RXC INoy56lGdut4uS55q2JJV9khWaBBJPYgf8+AdzYGKQFiQAAielyV2JT0EWpy/VQB0MIr 8IeA== X-Gm-Message-State: APjAAAWMmEtfBUzqFFN05BBpBf6OoBg02iz2YMtqrEFfIdD8JrpmGnqW XzFMrGp8Oa8gLDQ87wq+2zOZMQlJ+KYxnlOAvrE+JnDJ4DnC1sWZH66eCV0AVMsgZGG3Ppvy8Vl 1GpBmgf1lTwr+9ZIFGeI= X-Received: by 2002:a67:cfcc:: with SMTP id h12mr3803354vsm.198.1574289064955; Wed, 20 Nov 2019 14:31:04 -0800 (PST) X-Google-Smtp-Source: APXvYqy0qlW3n0Rd4frZaHu20adZdtyvRE0v+JF85drzVKEUSSb20xmr1ndyYo038yWQDOkmU0RHQpaB++1F7gGbs1A= X-Received: by 2002:a67:cfcc:: with SMTP id h12mr3803322vsm.198.1574289064520; Wed, 20 Nov 2019 14:31:04 -0800 (PST) MIME-Version: 1.0 References: <20191120160009.46270-1-ferruh.yigit@intel.com> <20191120172227.42798-1-ferruh.yigit@intel.com> In-Reply-To: From: David Marchand Date: Wed, 20 Nov 2019 23:30:53 +0100 Message-ID: To: Vamsi Attunuru , Jerin Jacob Cc: John McNamara , Marko Kovacevic , dev , Kiran Kumar K , Igor Ryzhov , Ferruh Yigit X-MC-Unique: OoCh3I47OdOZKS6o_6dFIw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] kni: increase kernel version requirement for VA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 20, 2019 at 6:28 PM David Marchand wrote: > > On Wed, Nov 20, 2019 at 6:22 PM Ferruh Yigit wro= te: > > > > A build error reported related to the selected > > 'get_user_pages_remote()' kernel API: > > > > .../kernel/linux/kni/kni_dev.h:113:8: > > error: too few arguments to function =E2=80=98get_user_pages_remote= =E2=80=99 > > ret =3D get_user_pages_remote(tsk, tsk->mm, iova, 1 > > ^~~~~~~~~~~~~~~~~~~~~ > > > > Currently there are three version of the 'get_user_pages_remote()' > > supported, based on kernel version > > < 4.9, =3D 4.9, > 4.9 > > > > These version based checks are not working fine with the distro kernels > > which is the cause of reported build error. The error reported by the > > kernel version 4.8, but it is using API defined in > 4.9. > > > > To be able to take control of this, and possible more, related build > > error, increasing the minimum supported kernel version for iova=3Dva wi= th > > KNI to kernel version 4.9. > > > > This leaves us with single version of the kernel API and more > > manageable. > > > > Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand We need this change to fix compilation issues for -rc3. Applied, thanks. --=20 David Marchand