From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3B5F4611D; Wed, 29 Jan 2025 16:57:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67894402AE; Wed, 29 Jan 2025 16:57:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8CBEE40274 for ; Wed, 29 Jan 2025 16:57:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738166252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=acNtL7W5Qm4BZ3G/QrZCvtWkQVurEQq+sPSoDMDseQs=; b=NfUbMfW5Tfwgm265EtLVS2xdkf/YlAqzEyLOS22D9MFhiqf47dMMF0PZhAa39kkdVkyuPq YsIaBtKXZcAZ9pGabGlGq0eu66scmbW0Z4/DNLUq81KgEDwxgCQ3IB/D2KQJPWP1tU1jXV HjEsJjMHrgh4C52WpA0GK5x/syKm4js= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-Bcx76R-nMAqWrsEaAJhZTQ-1; Wed, 29 Jan 2025 10:57:30 -0500 X-MC-Unique: Bcx76R-nMAqWrsEaAJhZTQ-1 X-Mimecast-MFC-AGG-ID: Bcx76R-nMAqWrsEaAJhZTQ Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-53e3a872187so4485496e87.1 for ; Wed, 29 Jan 2025 07:57:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738166249; x=1738771049; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=acNtL7W5Qm4BZ3G/QrZCvtWkQVurEQq+sPSoDMDseQs=; b=SA+Hjn991tXG4NcSPnu9E5ub0BvHvf3HUUy/HGJ0eVWnGpr25Whb3Ldgak63Kwc+me sixDwl5UXOyXNATW5Z9aV1X0N2wdg7sVWkFibiWW2OVePm21aK2EzGg19ASwH1Ihyura QLXtGutFa12jgMtZuXd6uZktLuLUsmz3j62MuDuXMdeSNY65+F/sIKK7SXIbf55eOarZ BvIuAesdwExWfmUTYPU4rTY+dTtnafAT4ReyazubJwLmIUlQ6Yf8l6efZxjvnh3KfEzt ts0jBZPleIUxVrUAmbgOsa/dWDersrBtpdRYgnGwzqrC6PH6WB9iOpk2iNGbqGL3NVTR F3fg== X-Forwarded-Encrypted: i=1; AJvYcCV9qEPv+7bqjY30Ryfz6x3OzfHjiqdb9gpt5l25XQYT6ZLLJBM4h0DkrGPXGnzqz/WA3gs=@dpdk.org X-Gm-Message-State: AOJu0Yy3TrjKG3gHB1L99ugw4989hs7VEnQZDWvTJnqtJRvRcp7p3+NH weCRAUu7ZynqMzH8zFecp65Ujx+/f4lkQneWxYeF2By8vOXGntQM6qFF+AEJin1gr2KI5lDPgZa van0zxlknK6jdexjqPEOBG9C/UCgZwDL0RFvqOwpc1kCyCElS7qEWv1fT/JM1mG4dQylfkZr+7Q MmYVpSKXzL4vPbQbk= X-Gm-Gg: ASbGncu4AG6APamIqa6mNUykLSpcoF/Cm96PhzigSrxVy2VSMQXDEdRaI7XjcXSJ9f8 2VM+qi5cIHNP03oAn7TpDyZUgtuPa3UIRdJjS04p0geLPmOD3UghiOnVtyb2jpQZN X-Received: by 2002:a05:6512:2254:b0:540:1b53:d413 with SMTP id 2adb3069b0e04-543e4c313a2mr1028492e87.40.1738166249233; Wed, 29 Jan 2025 07:57:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+uRLBMA4sQsOm1vzMJZ/pDcU/3SyZsrhCyt4cOVYKdIDfgwBZilEcTpxApkk2yNKhfY+fz+g6csaKcvp69bY= X-Received: by 2002:a05:6512:2254:b0:540:1b53:d413 with SMTP id 2adb3069b0e04-543e4c313a2mr1028481e87.40.1738166248826; Wed, 29 Jan 2025 07:57:28 -0800 (PST) MIME-Version: 1.0 References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1736821958-3295-1-git-send-email-andremue@linux.microsoft.com> <20250123163759.GA29129@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20250123163759.GA29129@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Wed, 29 Jan 2025 16:57:16 +0100 X-Gm-Features: AWEUYZnYxjXE28Whz63sQnVJfGiPEy6G58AR7nttZk990zYfDEtpwdKZUwWhtIk Message-ID: Subject: Re: [PATCH v16 00/60] remove use of VLAs for Windows To: Andre Muezerie Cc: Bruce Richardson , dev@dpdk.org, konstantin.ananyev@huawei.com, thomas@monjalon.net X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mcFPv_XEvUjUOhq5bexogtNBQL2_dOCB4AlcUIZ-yOU_1738166249 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 23, 2025 at 5:38=E2=80=AFPM Andre Muezerie wrote: > > > I see there is some back and forth on the topic of passing -Wvla. > > > It would be less fragile to put a -Wla in a upper level meson.build > > > (like config/meson.build for example), then disable explicitly in the > > > parts that are not ready. > > > > > > Something like: > > > diff --git a/config/meson.build b/config/meson.build > > > index 6aaad6d8a4..be603bd45b 100644 > > > --- a/config/meson.build > > > +++ b/config/meson.build > > > @@ -348,6 +348,17 @@ foreach arg: warning_flags > > > endif > > > endforeach > > > > > > +if cc.has_argument('-Wvla') > > > + add_project_arguments('-Wvla', language: 'c') > > > + if not is_windows > > > + no_vla_cflag =3D '-Wno-vla' > > > + else > > > + no_vla_cflag =3D [] > > > + endif > > > +else > > > + no_vla_cflag =3D [] > > > +endif > > > + > > > > Minor simplification suggestion, put "no_vla_cflag =3D []" outside the > > conditionals at the start, as the default value. Save having multiple > > copies of that assignment, and having to do "else" legs. > > These look like great improvements. I especially like the idea of using -= Wvla from the very top. Ok, can you work on a new revision and send it for the CI to have a try? Thanks. --=20 David Marchand