DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Somalapuram Amaranath <asomalap@amd.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
	Akhil Goyal <gakhil@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v4] crypto/ccp: moving vdev to PCI driver
Date: Fri, 16 Jul 2021 14:11:49 +0200	[thread overview]
Message-ID: <CAJFAV8wFUOFvv=Hh68grP4X1P5MfsX7HMNSVkey68X+_g=e7hA@mail.gmail.com> (raw)
In-Reply-To: <20210716120255.3475871-1-asomalap@amd.com>

On Fri, Jul 16, 2021 at 2:03 PM <asomalap@amd.com> wrote:
>
> From: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
>
> drop all the code duplicating the PCI bus driver
> develped for Enable IOMMU in vdev.
>
> Signed-off-by: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>

Title does not follow DPDK convention.
https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line

Commitlog has typos.

Please maintain a changelog to track changes between revisions.
https://doc.dpdk.org/guides/contributing/patches.html#creating-patches

We are already at v4 just for trivial checks.
It is easy to setup a github fork to at least pass github Actions checks.
Check your patch _before_ sending to the mailing list, the
contributing guide also contains hints for this.


Thanks.

-- 
David Marchand


  reply	other threads:[~2021-07-16 12:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16 12:02 asomalap
2021-07-16 12:11 ` David Marchand [this message]
2021-07-19  4:46 ` [dpdk-dev] [PATCH v5] " asomalap
2021-07-19 18:55   ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-26  9:08   ` [dpdk-dev] [PATCH v6] crypto/ccp: move device from vdev to PCI asomalap
2021-07-27 17:39     ` [dpdk-dev] [EXT] " Akhil Goyal
2023-10-06 11:06     ` [dpdk-dev] " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8wFUOFvv=Hh68grP4X1P5MfsX7HMNSVkey68X+_g=e7hA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=asomalap@amd.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).