From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>, dev <dev@dpdk.org>,
Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH] kni: fix build with 4.9.x
Date: Thu, 28 Nov 2019 15:16:00 +0100 [thread overview]
Message-ID: <CAJFAV8wFy1TTiFg+v-MFv2A-YXfT9bMQZSJV3C4QoiNJnivsZQ@mail.gmail.com> (raw)
In-Reply-To: <ae59ae75-65e3-8a95-ac31-dcef243e8a0a@solarflare.com>
On Thu, Nov 28, 2019 at 2:43 PM Andrew Rybchenko
<arybchenko@solarflare.com> wrote:
> On 11/28/19 3:15 PM, Ferruh Yigit wrote:
> > The 'get_user_pages_remote()' API is updated in kernel 4.10.0 [1],
> > but the check added as > 4.9.0,
> > this logic is broken for kernels 4.9.x, because they justify
> >> 4.9.0 check but have the old API.
> > Fixing the check as >= 4.10.0
> >
> > [1]
> > commit 5b56d49fc31d ("mm: add locked parameter to get_user_pages_remote()")
> >
> > Fixes: d965af9e8ae1 ("kni: increase kernel version requirement for VA")
> >
> > Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > Suggested-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2019-11-28 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 12:15 Ferruh Yigit
2019-11-28 13:43 ` Andrew Rybchenko
2019-11-28 14:16 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wFy1TTiFg+v-MFv2A-YXfT9bMQZSJV3C4QoiNJnivsZQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).