From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 038C042D2F; Fri, 23 Jun 2023 12:25:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C56D40EE4; Fri, 23 Jun 2023 12:25:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A9E7C40E09 for ; Fri, 23 Jun 2023 12:25:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687515953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lQPuYQg/J/sOoLkvtX2mO8CqW3viKILIUoNtRUUtzPo=; b=cDLEp4/CV7DOcXsjEMrvKUlKXRMbaSo336Oz2HDyPXXz1BPomHqlAivlmpEWMzZ6jNHnWk 3l4gI8/L5NwXV6AxeH4YSAAduS+vIsJdZkKlgMOhJ2YSjp8ywD893hT2hl+n0c51e1cN27 xjWfSi2hzZRWf+bOfSqvsgw+IpSRYLg= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-132-WJO0EbVLN5OCNfuoECvPjQ-1; Fri, 23 Jun 2023 06:25:51 -0400 X-MC-Unique: WJO0EbVLN5OCNfuoECvPjQ-1 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-1b561edde47so11239265ad.1 for ; Fri, 23 Jun 2023 03:25:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687515951; x=1690107951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lQPuYQg/J/sOoLkvtX2mO8CqW3viKILIUoNtRUUtzPo=; b=VSdb65G+bTccXDpQ8EDc8p0g74NzVHBrLlE9zQEF2l+qmSUZN+kqJG53dgqI28Dxdh guBq7Q3dGAEYB61aMmwUGe9SECcnPVsmmlJBeNM+Td9fY9rc6n7fgdus+PSWWFJ+/yTP o4BjcYyVi0bVy9r9jpd+Uchfk5MK3F9HItGF6cKkbGLUjgWB7y/TM6C4OBn6hFKfNZc8 T4HMiBQJZh1X5sMMWcTPbqePUrJJ7Qr+2qwRp12+VPKtj+yJ53k4rwMBeFOhfoDEyvU0 o1piHm2PiO8kx1ymGmiTU1zW5AL4oxfYBU1gnobdoN/Yg5GJ9bcbBPBEWKVW24ILkASt 3C5g== X-Gm-Message-State: AC+VfDwLiOHo1KvMjCvfbwPwuym/YXoYHhm9b/BZDGqaHFiJ8EkyObY1 1QgCIOSAunMi04RxTW52DTP6r6Uin4i48lvVrOUzLoUBgpRWpaYMQcHmUiQjRQe9Kt+TSql/GlM FGzkP/iO3yqUftF20Fds= X-Received: by 2002:a17:902:e5cc:b0:1b6:b445:36d0 with SMTP id u12-20020a170902e5cc00b001b6b44536d0mr6003274plf.26.1687515950914; Fri, 23 Jun 2023 03:25:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ46LPG73rI1sqUInGFuRxPwhYdVHMqA52sKi7OlGxz7VXKAN0TrPtIY44ArXLmBAdzZuiYWolRy88Figz7lUXw= X-Received: by 2002:a17:902:e5cc:b0:1b6:b445:36d0 with SMTP id u12-20020a170902e5cc00b001b6b44536d0mr6003260plf.26.1687515950525; Fri, 23 Jun 2023 03:25:50 -0700 (PDT) MIME-Version: 1.0 References: <20230622134840.3225975-1-bruce.richardson@intel.com> <20230622150522.3228294-1-bruce.richardson@intel.com> In-Reply-To: <20230622150522.3228294-1-bruce.richardson@intel.com> From: David Marchand Date: Fri, 23 Jun 2023 12:25:39 +0200 Message-ID: Subject: Re: [PATCH v2 0/7] expand list of optional libraries To: Bruce Richardson Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 22, 2023 at 5:13=E2=80=AFPM Bruce Richardson wrote: > > DPDK still has many libraries which cannot be disabled as part of a > build. With the ongoing work to make it easier to only build a subset > of the libraries in DPDK, we can also work to expand the list of > libraries which can be enabled/disabled as desired. > > This patch addresses a number of the "low-hanging fruit" libraries, > where only the unit test builds need minor changes to support > making the library optional. The rest of the build system is already > well set up for selective disabling of libraries. > > For better support of enabling components, especially those more > integrated into DPDK unit tests, rework of the test meson.build file > is likely needed. For example, it could probably be better rewritten > to use a dictionary of files and the dependencies of each file, and > the unit test commands each provides. However, such rework is a > significant effort, and outside the scope of this patchset. > > V2: fix checkpatch issues, since checkpatch doesn't like empty commit > messages (even if the title is pretty self-explanatory!) > > Bruce Richardson (7): > build: make most device classes optional > build: make membership library optional > build: make bpf library optional > build: make efd library optional > build: make distributor library optional > build: make fragmentation library optional > build: make reorder library optional > > app/test/meson.build | 81 +++++++++++++++++++++++++++----------------- > lib/meson.build | 13 +++++++ > 2 files changed, 63 insertions(+), 31 deletions(-) There is a trivial conflict on the main repo (after lib/graph change), so the CI did not run this v2 revision. The v1 looked fine but there was a strange error in Intel report: http://mails.dpdk.org/archives/test-report/2023-June/415672.html Could you rebase please? --=20 David Marchand