From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39B9945ADE; Tue, 8 Oct 2024 12:15:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09DE84025C; Tue, 8 Oct 2024 12:15:43 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 98D6E4021F for ; Tue, 8 Oct 2024 12:15:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728382541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tDf7N8p1hKzWnM4ZAEKeXjn2FzOk0Z0EmIVEimwI/lY=; b=inPM7abDuYOmXe/r1rRqvDC9qstZ9OD3Lj+sfHWZ6aKNXE1sAQhx5AGQ4d1AqyTVNAcm41 b7OEkbcvTO1QKvm9402QEBasV4UJVjAHdwp/6SFv6WF0rJV6lxO9tw3sVCMlHR8/FX2KC1 SB8gTs+ssES7yGCKPkR5G+Qesp7Usfs= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-qA-qMd5YMfOc9cchXEYkWw-1; Tue, 08 Oct 2024 06:15:40 -0400 X-MC-Unique: qA-qMd5YMfOc9cchXEYkWw-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5398f3bdc88so4397613e87.0 for ; Tue, 08 Oct 2024 03:15:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728382538; x=1728987338; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tDf7N8p1hKzWnM4ZAEKeXjn2FzOk0Z0EmIVEimwI/lY=; b=nycem0NqC60s+bNjUbFCTOsUHd7ryhym1Vh3iOsBhi0vlT7/Aj3MrvJwRSTgF8r42w o3jyXJH7kB++FtE6iBcQzZkTBYyDUiqF2Jh0D5Oe2KMDLDwXKoKlv80Pl0Kkj6KLcCjS hjEaDAHsQNGcmJFqf59vW6KTr2ikiHa0qf0NYoG0TKFLn3CFjKctzup+wtM0tSaslxzL 6gf2r0x18u0DlcX95VnIHhgTiKKs4AOwDrdgW1vyWCfmha4kirz8Eh5Pjr7nP9OdxoAA tA44A0VbVHhkyx3LvRN0R3I23SfcRvhSfi2mmfHNS/Fg7upA/r0k6X7LwmpEMPM1jFVz SmOg== X-Forwarded-Encrypted: i=1; AJvYcCWX+pNvIdUFE7TAEV9FUwm08eSnHpxQ1T1LZZIWy7AJnNC7MoMcWKPFMqagIDVLDt4sqhk=@dpdk.org X-Gm-Message-State: AOJu0YxVAPe/37SK2Eo3bnT7GdoJxAkrTNquSBViu8mQpgb8BcFbPvc1 yLVVURew7KbY8U3GEqLBdZz+e+ieNsqNM8jWWeHCqeeUCRUBfcxKOJLmTJKDGCJSOXZt+uhBaKB IeTOz3GADsvyQmiP541Os96nPZPD26/lIW4hiUlPI5LmheCRDSgFG4Pm1gQa0BG2ZW1yB243QY0 AowaoJapGIWubgcMs= X-Received: by 2002:a05:6512:4023:b0:52c:e012:efad with SMTP id 2adb3069b0e04-539ab84e3b3mr6961633e87.12.1728382538565; Tue, 08 Oct 2024 03:15:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYhW5Cu9J4sRqbVFZgaUu2TD5+PxS9Vkf3VOHYC2WHActxV7YksrI7uLtgeqahovMvFcKaYq8k+qTRUPcdLKs= X-Received: by 2002:a05:6512:4023:b0:52c:e012:efad with SMTP id 2adb3069b0e04-539ab84e3b3mr6961610e87.12.1728382538098; Tue, 08 Oct 2024 03:15:38 -0700 (PDT) MIME-Version: 1.0 References: <20240918085551.231015-1-mb@smartsharesystems.com> <20241007114601.2921507-1-mb@smartsharesystems.com> In-Reply-To: <20241007114601.2921507-1-mb@smartsharesystems.com> From: David Marchand Date: Tue, 8 Oct 2024 12:15:26 +0200 Message-ID: Subject: Re: [PATCH v9] eal: add build-time option to omit trace To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Jerin Jacob , Sunil Kumar Kori , dev@dpdk.org, Stephen Hemminger X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 7, 2024 at 1:46=E2=80=AFPM Morten Br=C3=B8rup wrote: > > Some applications want to omit the trace feature. > Either to reduce the memory footprint, to reduce the exposed attack > surface, or for other reasons. > > This patch adds an option in rte_config.h to include or omit trace in the > build. Trace is included by default. > > Omitting trace works by omitting all trace points. > For API and ABI compatibility, the trace feature itself remains. > > Furthermore, a public function to determine if trace is build time enable= d > is added; mainly for the benefit of the dpdk-test application. > > Signed-off-by: Morten Br=C3=B8rup > Acked-by: Stephen Hemminger > Acked-by: Jerin Jacob Series applied. Thanks Morten. --=20 David Marchand