From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35373A04DD; Wed, 18 Nov 2020 15:12:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D1F06C90A; Wed, 18 Nov 2020 15:12:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 6CA9BC8CC for ; Wed, 18 Nov 2020 15:12:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605708723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b8h+jqcitpIjnnrXkS+uxHuCaQ0WTphHThCFhEFU3BQ=; b=Xw3XEd0GwXN1UDr+n7DnDJho5q3DsU60nwcJ3zLYhlbmdhNbz+KSG0diFg0oFipDZXGJKk PfMK9Xn6oqDrXJwMnUwnfp+N4lEv+btJV7/QYlMAX7Zdo/Jjgcg00k2vWvzDIvdDAub5Fk cnMc70RZ3LR7FiFdZq2GeHURc7oecaY= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-451-Tb1xmx7rMo6VID5iERQSRQ-1; Wed, 18 Nov 2020 09:12:01 -0500 X-MC-Unique: Tb1xmx7rMo6VID5iERQSRQ-1 Received: by mail-vk1-f197.google.com with SMTP id q62so744710vka.22 for ; Wed, 18 Nov 2020 06:12:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b8h+jqcitpIjnnrXkS+uxHuCaQ0WTphHThCFhEFU3BQ=; b=iBe7FqVgh2E4ePV8G5yEyJjIltBxEROFGOH2GGzpfYe2NzH0QdmyP9PGo7LmG0XK6v 8WQD36/lCJtaktwcsqIitoWvmDpazgQ5/hloyNqnXgpB3mG0GPjBKPsqhxvOPiPym1TZ QNpyRCdjE1h6IbGaTj8V+XqTkTWtejiMsgF2X0mIw47jfPUY4Ko2EPqhxETPrtJvP61s aQIQVQuEymUAI+tnsq6jTeZmEcaJhfJAVWF6wYNiECrvFCBwFVRvBB4er6OAeI2frwWy +2KICn+ik9p817KX+GtJTGL475q6hxMcX3j2C/mxtqiWT70sGdP5TD2BzEteEcdUq2Y2 +Asg== X-Gm-Message-State: AOAM530xHL1tl9drYZQVoNjx7UO+vP5JnkMGkYpySaQSCmnworV7nIDG zDgWth1H1QncS+2tr9LvC7g3aYfYogvKBSJXlEMvoQX/ccHUt6qhVSndOMiLnCRp91DzZrSrwUO 7zVJc2vAHRjg/o7rXrmI= X-Received: by 2002:a67:fd46:: with SMTP id g6mr3254417vsr.27.1605708721292; Wed, 18 Nov 2020 06:12:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyN+53vvWaDczhJn1vMpw+J8q2scKGnFOI0Zl2uPzB5b1o/83ODmp39eUm/cGSDxfEhVgCbxvafjqSGhju11Wo= X-Received: by 2002:a67:fd46:: with SMTP id g6mr3254395vsr.27.1605708721136; Wed, 18 Nov 2020 06:12:01 -0800 (PST) MIME-Version: 1.0 References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201118114525.99053-1-ferruh.yigit@intel.com> <20201118114525.99053-6-ferruh.yigit@intel.com> In-Reply-To: <20201118114525.99053-6-ferruh.yigit@intel.com> From: David Marchand Date: Wed, 18 Nov 2020 15:11:49 +0100 Message-ID: To: Ferruh Yigit Cc: Juhamatti Kuusisaari , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 5/7] net/pcap: remove local variable shadown outer one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 18, 2020 at 12:47 PM Ferruh Yigit wrote: > > 'ret' is already defined in the function scope, removing the 'ret' in > the block scope. > > Fixes: c9507cd0cada ("net/pcap: support physical interface MAC address") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- > Cc: juhamatti.kuusisaari@coriant.com > --- > drivers/net/pcap/rte_eth_pcap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c > index 4930d7d382..dd9ef33c85 100644 > --- a/drivers/net/pcap/rte_eth_pcap.c > +++ b/drivers/net/pcap/rte_eth_pcap.c > @@ -1324,7 +1324,7 @@ eth_from_pcaps(struct rte_vdev_device *vdev, > > /* phy_mac arg is applied only only if "iface" devarg is provided */ > if (rx_queues->phy_mac) { > - int ret = eth_pcap_update_mac(rx_queues->queue[0].name, > + ret = eth_pcap_update_mac(rx_queues->queue[0].name, > eth_dev, vdev->device.numa_node); > if (ret == 0) > internals->phy_mac = 1; It is not used after, why not simply check eth_pcap_update_mac() == 0 ? -- David Marchand