From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 486CBA04B5; Wed, 16 Sep 2020 18:17:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9A101C435; Wed, 16 Sep 2020 18:17:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 5CB341C300 for ; Wed, 16 Sep 2020 18:17:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600273071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hVABJja+XWkIp01+wHw+MG7S7qZOlAENIsxlz9R/9o0=; b=GyX2ESe+hBEk3XbLtZ6C5rcOqVFhhWJkpYLOnL3CbczpFEYmBdyBPC8XLTZlh6EPOA1LCa 9D0uNNl5nXgcKMO+hD48Gr9TLUdvIf24plN/tdMAQ3HmrGJxMmKUlURzhXamGWCzrmDsht gOJtflFuamHTXREtuPP3difm3ZTbUfY= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-JL5Wg9lGNR2SUlWXlI88DA-1; Wed, 16 Sep 2020 12:17:49 -0400 X-MC-Unique: JL5Wg9lGNR2SUlWXlI88DA-1 Received: by mail-vs1-f70.google.com with SMTP id s68so2327193vss.3 for ; Wed, 16 Sep 2020 09:17:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hVABJja+XWkIp01+wHw+MG7S7qZOlAENIsxlz9R/9o0=; b=eB10XRkXrn0eZMdrGWdAB+vm9c/TIWUbdKHWPk3YKBdn0RiEeaodq/oVdouF/RyTe4 HtOcnBL1X4/83DFDh5HaPeIK8hijLy3MsY5sijiGM6fAO9tTfxqPiwxk+rRyAfVVhRLv lLbt9iTr7z+IG45BWsT+m5KfHxtOnTAYABzvrq/wDgnW9Fl2ICNlprnOMDdH5AWzTG4O z7b4aClZwOUnHkVAEVxITz2Rttnx2vmpU0Q3dJqqGIFXiCqp8asuS0bKEdbfsSZ+q/kS kWkZG8z0ClHPZqyQphn5lQ/H/o4pJegGDgQZc/8HuqgBXn0zg0iDESizd/n7zw+ftPWc zQcw== X-Gm-Message-State: AOAM533xrD7ytgWn8JWvMMiIpZm95i7PTH/sgUGYENJ5ltZI9Lu/jrFb t5BFYG6naucrK9y5VKinC5viIt/j2a7r4HLepTtkKI65Oc8NyWXfwCIhwWGLlwN9aHDeifBeh5z SVpdxYFA3GDX9cCGhMxw= X-Received: by 2002:a67:e2c2:: with SMTP id i2mr15066492vsm.27.1600273069303; Wed, 16 Sep 2020 09:17:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0ccuaoE7XiDHHXYVGXt5QZRunnG65/kdrDJvOgHiPKXbuf82w45gRt+0cWIjkVLGQ8mX/n+aULmL86pgYw0A= X-Received: by 2002:a67:e2c2:: with SMTP id i2mr15066473vsm.27.1600273069110; Wed, 16 Sep 2020 09:17:49 -0700 (PDT) MIME-Version: 1.0 References: <20200902111030.731593-1-christian.ehrhardt@canonical.com> In-Reply-To: <20200902111030.731593-1-christian.ehrhardt@canonical.com> From: David Marchand Date: Wed, 16 Sep 2020 18:17:38 +0200 Message-ID: To: Christian Ehrhardt Cc: dev , Bruce Richardson , Thomas Monjalon , Luca Boccassi Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] avoid libfdt checks adding full paths to pkg-config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 2, 2020 at 1:10 PM Christian Ehrhardt wrote: > > The checks for libfdt try dependency() first which would only work if > a pkg-config would be present but libfdt has none. > Then it probes for the lib path itself via cc.find_library. > > But later it adds the result of either probe to ext_deps which ends up > in build and also the resulting pkg-config to contain toolchain versioned > paths in Libs.private like: > /usr/lib/gcc/x86_64-linux-gnu/9/../../../x86_64-linux-gnu/libfdt.so > which obviously breaks on toolchain updates. > > In general libs used multiple times - ipn3ke + ifpga in this case - are > checked centrally in config/meson.build so move it there and fix the > adding of dependencies to not use the full file path. > > The result is libfdt in pkg-config now showing up as: > Libs.private: -pthread -lm -ldl -lnuma -lfdt -lpcap > > Signed-off-by: Christian Ehrhardt > Reviewed-by: Luca Boccassi Reviewed-by: Bruce Richardson Ignored v2 as mentioned before. Applied, thanks. -- David Marchand