* [dpdk-dev] [PATCH v7] eal/arm64: fix rdtsc precise version
@ 2020-03-12 1:08 Linhaifeng
2020-03-13 10:06 ` David Marchand
0 siblings, 1 reply; 2+ messages in thread
From: Linhaifeng @ 2020-03-12 1:08 UTC (permalink / raw)
To: Jerin Jacob
Cc: Gavin Hu, dev, thomas, chenchanghu, xudingke, Lilijun (Jerry),
Honnappa Nagarahalli, Steve Capper, nd
In order to get more accurate the cntvct_el0 reading,
SW must invoke isb.
Fixes: ccad39ea0712 ("eal/arm: add cpu cycle operations for ARMv8")
Cc: stable@dpdk.org
Reviewed-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Jerin Jacob <jerinjacobk@gmail.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
Signed-off-by: Haifeng Lin <haifeng.lin@huawei.com>
---
lib/librte_eal/common/include/arch/arm/rte_cycles_64.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/include/arch/arm/rte_cycles_64.h b/lib/librte_eal/common/include/arch/arm/rte_cycles_64.h
index 68e7c7338..da557b6a1 100644
--- a/lib/librte_eal/common/include/arch/arm/rte_cycles_64.h
+++ b/lib/librte_eal/common/include/arch/arm/rte_cycles_64.h
@@ -62,7 +62,7 @@ rte_rdtsc(void)
static inline uint64_t
rte_rdtsc_precise(void)
{
- rte_mb();
+ asm volatile("isb" : : : "memory");
return rte_rdtsc();
}
--
2.24.1.windows.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH v7] eal/arm64: fix rdtsc precise version
2020-03-12 1:08 [dpdk-dev] [PATCH v7] eal/arm64: fix rdtsc precise version Linhaifeng
@ 2020-03-13 10:06 ` David Marchand
0 siblings, 0 replies; 2+ messages in thread
From: David Marchand @ 2020-03-13 10:06 UTC (permalink / raw)
To: Linhaifeng
Cc: Jerin Jacob, Gavin Hu, dev, thomas, chenchanghu, xudingke,
Lilijun (Jerry),
Honnappa Nagarahalli, Steve Capper, nd
On Thu, Mar 12, 2020 at 2:09 AM Linhaifeng <haifeng.lin@huawei.com> wrote:
>
> In order to get more accurate the cntvct_el0 reading,
> SW must invoke isb.
>
> Fixes: ccad39ea0712 ("eal/arm: add cpu cycle operations for ARMv8")
> Cc: stable@dpdk.org
>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> Signed-off-by: Haifeng Lin <haifeng.lin@huawei.com>
Applied.
--
David Marchand
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-13 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-12 1:08 [dpdk-dev] [PATCH v7] eal/arm64: fix rdtsc precise version Linhaifeng
2020-03-13 10:06 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).