From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by dpdk.org (Postfix) with ESMTP id AF3B75F21 for ; Tue, 9 Apr 2019 11:57:15 +0200 (CEST) Received: by mail-vs1-f41.google.com with SMTP id j184so9405277vsd.11 for ; Tue, 09 Apr 2019 02:57:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HWGLWpwtekdCxOO09sq5aJNsSySBK7xM65il/X+ZGMI=; b=LqHum03TeuktAQQr45ptOsLr6788WG6fUuZXZCxv/77MEoTILyMZu3DlhVk2zt2frc fWy4Pi5ahg+s0wCuoG6W34Wq7izUugf4C5kKx0Wsb3xZPgiO2Es5yi5XP1zKWQWvexPc 6RAEE1m1FbmO35knfJMq6wWRioSlpjoptbjKkViRB+xKhH8YLp+xBxcyKPHvoXez3Qk7 uYUKT4rplxA/BEqoZXoX7UuECXGI65kaKROntrdA9lA/LG82yzU7SPU3hA6ZSlzaGtpu GjF5RZ8Aboj84pf3n4BOdiO3qckQBlLUJPJPql6xDxiYxXfjGnwW7DNMPtyyZ55qkFg2 ha5g== X-Gm-Message-State: APjAAAV/PKJ65vnzoLjWb0R61li7BTgkjqCgPHeQoH6orGYDoyqQCLNr oorut0pzm4ujP/ygsjS9pn2vflOyVtZv0TWG4rsG3EJ4 X-Google-Smtp-Source: APXvYqxyW+uji6L06HT6TK81sv5wB15UDCDYWjFLW4dtjc0kLqrt6xDlsyaH34AoD1mjFA3kpiseWIs0oazkBCfCszs= X-Received: by 2002:a67:f607:: with SMTP id k7mr17013892vso.137.1554803835136; Tue, 09 Apr 2019 02:57:15 -0700 (PDT) MIME-Version: 1.0 References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-6-bruce.richardson@intel.com> In-Reply-To: <20190409092933.55356-6-bruce.richardson@intel.com> From: David Marchand Date: Tue, 9 Apr 2019 11:57:04 +0200 Message-ID: To: Bruce Richardson Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 5/5] devtools/test-meson-builds: fix support for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 09:57:16 -0000 On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson wrote: > The pipefile option does not seem to exist on FreeBSD, giving an error > when running the script. > > Fixes: 5d9176673008 ("devtools: fix meson build test to exit on failure") > > Signed-off-by: Bruce Richardson > --- > devtools/test-meson-builds.sh | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index b3b5cfbb5..1fd23fac7 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -7,7 +7,10 @@ > # * if a build-directory already exists we assume it was properly > configured > # Run ninja after configuration is done. > > -set -o pipefail > +# this option gives an error on BSD > +if [ "`uname`" == "Linux" ] ; then > + set -o pipefail > +fi > == is a bashism, can't you just use = ? -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A8CB2A0096 for ; Tue, 9 Apr 2019 11:57:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 754A45F29; Tue, 9 Apr 2019 11:57:17 +0200 (CEST) Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by dpdk.org (Postfix) with ESMTP id AF3B75F21 for ; Tue, 9 Apr 2019 11:57:15 +0200 (CEST) Received: by mail-vs1-f41.google.com with SMTP id j184so9405277vsd.11 for ; Tue, 09 Apr 2019 02:57:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HWGLWpwtekdCxOO09sq5aJNsSySBK7xM65il/X+ZGMI=; b=LqHum03TeuktAQQr45ptOsLr6788WG6fUuZXZCxv/77MEoTILyMZu3DlhVk2zt2frc fWy4Pi5ahg+s0wCuoG6W34Wq7izUugf4C5kKx0Wsb3xZPgiO2Es5yi5XP1zKWQWvexPc 6RAEE1m1FbmO35knfJMq6wWRioSlpjoptbjKkViRB+xKhH8YLp+xBxcyKPHvoXez3Qk7 uYUKT4rplxA/BEqoZXoX7UuECXGI65kaKROntrdA9lA/LG82yzU7SPU3hA6ZSlzaGtpu GjF5RZ8Aboj84pf3n4BOdiO3qckQBlLUJPJPql6xDxiYxXfjGnwW7DNMPtyyZ55qkFg2 ha5g== X-Gm-Message-State: APjAAAV/PKJ65vnzoLjWb0R61li7BTgkjqCgPHeQoH6orGYDoyqQCLNr oorut0pzm4ujP/ygsjS9pn2vflOyVtZv0TWG4rsG3EJ4 X-Google-Smtp-Source: APXvYqxyW+uji6L06HT6TK81sv5wB15UDCDYWjFLW4dtjc0kLqrt6xDlsyaH34AoD1mjFA3kpiseWIs0oazkBCfCszs= X-Received: by 2002:a67:f607:: with SMTP id k7mr17013892vso.137.1554803835136; Tue, 09 Apr 2019 02:57:15 -0700 (PDT) MIME-Version: 1.0 References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-6-bruce.richardson@intel.com> In-Reply-To: <20190409092933.55356-6-bruce.richardson@intel.com> From: David Marchand Date: Tue, 9 Apr 2019 11:57:04 +0200 Message-ID: To: Bruce Richardson Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 5/5] devtools/test-meson-builds: fix support for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409095704.NS1AdYT6Lbpi6oejzcdWbiS_eCMSeu5sp4RZWPFilH0@z> On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson wrote: > The pipefile option does not seem to exist on FreeBSD, giving an error > when running the script. > > Fixes: 5d9176673008 ("devtools: fix meson build test to exit on failure") > > Signed-off-by: Bruce Richardson > --- > devtools/test-meson-builds.sh | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index b3b5cfbb5..1fd23fac7 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -7,7 +7,10 @@ > # * if a build-directory already exists we assume it was properly > configured > # Run ninja after configuration is done. > > -set -o pipefail > +# this option gives an error on BSD > +if [ "`uname`" == "Linux" ] ; then > + set -o pipefail > +fi > == is a bashism, can't you just use = ? -- David Marchand