From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F77CA04A2; Tue, 5 Nov 2019 20:36:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B48E1BEF5; Tue, 5 Nov 2019 20:36:12 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 670DA1BEE8 for ; Tue, 5 Nov 2019 20:36:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572982570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/nuPA3h7H95Z+E04weBWz4gQnEmqIAXW/X1HfZfO+QE=; b=L8JrlY0FKx8DI90Vz/haCaXm6IgyJTtcKepUoa5KMx0YzgDKRy6gDMCjvlzPRAMXoeXum8 zgPtsl6Fb9w1B3mdawQgGfK0oD2XrkGe+4JWLnx0ZChUO1sxfVgwiWeqmim5GiGI40EAal uxgsr3i/4SQfToQUIzt1QMxKPvfsbI4= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-YSbYgWakPPuvtVXAmq7JnA-1; Tue, 05 Nov 2019 14:36:08 -0500 Received: by mail-vk1-f199.google.com with SMTP id v188so4792642vkv.18 for ; Tue, 05 Nov 2019 11:36:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lE8XhD3rioQapLXUtVEsVOQaSNiaflsXATuY1tjUNTQ=; b=T8zas79J2WDHB9pFIfk1XLL5OIRbb6EgGjRwvvNAD2NohWXGAqSDtCOrgb95eSTb72 ZOCJ4/VQUurBKie27E3m8Tkws0fh0s/4WuzonMT2rOd9W+1UvyYwfG6t7mpsOn2TDez0 9SQFWY1kMSHhpH1AylpgNfpWINHi9Gau/Y3ufB/dwXUa8/IAiNi/OBEkDtQfXPqO4jck Tpy1s58j2MfN50ifEitDs5QXgijxXwpPru10i01j09GKo+k3t2aSHA18XzFw9Y7eOLfp q1ERLOq0ffvKEERwGpIN00hu8mvALjdescfVpSWZgwlXgpnUozFSwCMW+TCcTZEct4+P crjw== X-Gm-Message-State: APjAAAU087tH63nxUbXEGhHRcBYTKCh46cvozZiVqOWUCnYvYt2Dspha 6AvrSFSaNktJZO2hxPjhnxQuOnguFGljOxxg3detE2HmWTpDv0kY7Z9Fz5txmOBg1idsXmvnYNw goJkhQ9RKS5uwgRiY4k0= X-Received: by 2002:a67:fa99:: with SMTP id f25mr4892875vsq.141.1572982567887; Tue, 05 Nov 2019 11:36:07 -0800 (PST) X-Google-Smtp-Source: APXvYqzFV4QTeo9VAslKDVcV6e8D3/e+iXd69WXGNmXRrnIP+OxQlbU9HW+Dlg2L9s28unV10gloctR0duhlL6VK0lI= X-Received: by 2002:a67:fa99:: with SMTP id f25mr4892851vsq.141.1572982567379; Tue, 05 Nov 2019 11:36:07 -0800 (PST) MIME-Version: 1.0 References: <20191105181640.3714-1-Devyn.Johnson@BanduraCyber.com> In-Reply-To: <20191105181640.3714-1-Devyn.Johnson@BanduraCyber.com> From: David Marchand Date: Tue, 5 Nov 2019 20:35:56 +0100 Message-ID: To: devyn.johnson@banduracyber.com Cc: dev X-MC-Unique: YSbYgWakPPuvtVXAmq7JnA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] Working Towards Making DPDK Compile with Additional Warning Flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, On Tue, Nov 5, 2019 at 7:17 PM wrote: > > From: Devyn Collier Johnson > > Signed-off-by: Devyn Collier Johnson > --- > lib/librte_cryptodev/rte_cryptodev.c | 4 ++-- > lib/librte_eal/common/eal_common_cpuflags.c | 4 ++-- > lib/librte_eal/common/eal_common_errno.c | 2 +- > lib/librte_eal/common/eal_common_hexdump.c | 4 ++-- > lib/librte_eal/common/eal_common_lcore.c | 10 +++++----- > lib/librte_eal/common/eal_common_log.c | 10 +++++----- > lib/librte_eal/common/eal_common_memalloc.c | 8 ++++---- > lib/librte_eal/common/eal_common_memory.c | 2 +- > lib/librte_eal/common/eal_common_proc.c | 2 +- > lib/librte_eal/common/eal_common_tailqs.c | 2 +- > lib/librte_eal/common/eal_memalloc.h | 8 ++++---- > lib/librte_eal/common/eal_private.h | 2 +- > lib/librte_eal/common/include/rte_bitmap.h | 20 ++++++++++---------- > lib/librte_eal/common/include/rte_common.h | 2 +- > lib/librte_eal/common/include/rte_errno.h | 2 +- > lib/librte_eal/common/include/rte_hexdump.h | 2 +- > lib/librte_eal/common/include/rte_lcore.h | 10 +++++----- > lib/librte_eal/common/include/rte_log.h | 8 ++++---- > lib/librte_eal/common/malloc_elem.c | 4 ++-- > lib/librte_eal/linux/eal/eal.c | 2 +- > lib/librte_ethdev/rte_class_eth.c | 2 +- > lib/librte_ethdev/rte_mtr.c | 2 +- > lib/librte_ethdev/rte_tm.c | 2 +- > lib/librte_mbuf/rte_mbuf.c | 4 ++-- > lib/librte_mbuf/rte_mbuf_dyn.c | 4 ++-- > lib/librte_mempool/rte_mempool.c | 2 +- > lib/librte_ring/rte_ring.c | 2 +- > lib/librte_timer/rte_timer.c | 20 ++++++++++---------- > 28 files changed, 73 insertions(+), 73 deletions(-) Thanks for the patch. It is missing a commitlog describing the problem that you faced, and explaining how this patch fixes this problem. It touches a lot of different parts of the dpdk, which will make it harder to review and (if applicable) harder to backport in stable branches. Before submitting new patches, please take the time to read our contributing guide that you can find here: http://doc.dpdk.org/guides/contributing/patches.html --=20 David Marchand