From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 200D645480; Mon, 17 Jun 2024 12:02:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA6AF402CA; Mon, 17 Jun 2024 12:02:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D7C34402AC for ; Mon, 17 Jun 2024 12:02:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718618544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Cq4uGeOkG4ybtPuTSIv+ze8reE9Z/rs7G6LWXh1tSk=; b=Op6G8VwTWUNdpN6xHxMBcW+ta/4Y32o6XqoE4EClgZkt2DpSvVf/xrG4yqiGtFlDtQVjSQ 1/D91CGpg+JPnBV4+uvjzxKoFna69IA6lQ3GsmbnuXWEH3YPAeOxqIKL2eJQtzIsGk4F/j DEn2fUae4nMEKZLvHV4Jgv+nfYHDsHg= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-3RBSAkx5PtCAqI_MGmgf9w-1; Mon, 17 Jun 2024 06:02:22 -0400 X-MC-Unique: 3RBSAkx5PtCAqI_MGmgf9w-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-52c989652e6so3110738e87.0 for ; Mon, 17 Jun 2024 03:02:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718618541; x=1719223341; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4Cq4uGeOkG4ybtPuTSIv+ze8reE9Z/rs7G6LWXh1tSk=; b=fCN3g7MzMzqaK148BRElylvEFWcp7QwCUIIO+6kUscaHJGRcY0u9IcjwwX5e9NGGtq aoGVxyodqjrYby1qpJ0HiXFlasjQ6wZUbvyhpDICw2+aJJm0ZunmJTM8EOUBPfOS4LbB 3vDyqsROcnHRgVCpRCDdmcjScSSNxABKnqZWIjXeiTdjrzglQM9Nl1rUeNQ50o9B9RuR qfC41CNx96+qqh4qBkXVX73k1biIU06HPiYyYg+IYltsBS62QmitgoelxFxyMTdzX5Kz gT766CgvBGKB/e6zLNIPXtLDm9dazc4XW6pzhJBCDwnOyhtxD9KX7vvFy4Gpu0kus1nv 0Dng== X-Gm-Message-State: AOJu0Yyzd7X6G19ywYYSOndHNyex79VwK4+PncsXIZQ0b/Hm+DRBR9Y6 CuPrplyQ+dc+DALwHgSJHBxszIxs7yVeE944L/C6+1JBy56hY8ldO1JJzXaATh+LOQDYUTNJSMo TjVTrwnEuIZ9jzs/udPZhRQszm/SZCj58B+lIU9tHBZMJjf7oepRVQTENqsqzJbRPeBQkvDAYCw z/MW/Ch/khrd1WCvQ= X-Received: by 2002:a05:6512:70c:b0:52c:8fce:5f5b with SMTP id 2adb3069b0e04-52ca6e9b0c1mr6669609e87.60.1718618541317; Mon, 17 Jun 2024 03:02:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHS7hFIuX7mrnCjQSwx9S7QGQv6cuQuQyI/svlmUBJkHMtO4l0i9OilfP4lCpBaJg1e2nkGzZcsBZhzAKY4I34= X-Received: by 2002:a05:6512:70c:b0:52c:8fce:5f5b with SMTP id 2adb3069b0e04-52ca6e9b0c1mr6669580e87.60.1718618540860; Mon, 17 Jun 2024 03:02:20 -0700 (PDT) MIME-Version: 1.0 References: <20230927150854.3670391-1-paul.szczepanek@arm.com> <20240611125947.511243-1-paul.szczepanek@arm.com> In-Reply-To: From: David Marchand Date: Mon, 17 Jun 2024 12:02:09 +0200 Message-ID: Subject: Re: [PATCH v15 0/6] add pointer compression API To: Paul Szczepanek Cc: dev@dpdk.org, Honnappa Nagarahalli , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Konstantin Ananyev , Bruce Richardson , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Paul, On Fri, Jun 14, 2024 at 12:28=E2=80=AFPM David Marchand wrote: > Even if this library only contains a header, with no tie to other > public DPDK API, this library should be optional. > If no objection, please work on this change for -rc2, We have a build error on armv7 (tested in OBS). https://build.opensuse.org/public/build/home:bluca:dpdk/openSUSE_Factory_AR= M/armv7l/dpdk/_log [ 395s] [1730/2037] cc -Iapp/dpdk-test.p -Iapp -I../app -Ilib/cmdline -I../lib/cmdline -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/arm/include -I../lib/eal/arm/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Idrivers/net/ring -I../drivers/net/ring -Ilib/ethdev -I../lib/ethdev -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/acl -I../lib/acl -Ilib/argparse -I../lib/argparse -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -Ilib/bitratestats -I../lib/bitratestats -Ilib/bpf -I../lib/bpf -Ilib/compressdev -I../lib/compressdev -Ilib/cryptodev -I../lib/cryptodev -Ilib/security -I../lib/security -Ilib/dispatcher -I../lib/dispatcher -Ilib/eventdev -I../lib/eventdev -Ilib/timer -I../lib/timer -Ilib/dmadev -I../lib/dmadev -Ilib/distributor -I../lib/distributor -Ilib/efd -I../lib/efd -Ilib/fib -I../lib/fib -Ilib/rib -I../lib/rib -Ilib/table -I../lib/table -Ilib/port -I../lib/port -Ilib/sched -I../lib/sched -Ilib/ip_frag -I../lib/ip_frag -Ilib/lpm -I../lib/lpm -Ilib/graph -I../lib/graph -Ilib/pcapng -I../lib/pcapng -Ilib/ipsec -I../lib/ipsec -Ilib/latencystats -I../lib/latencystats -Idrivers/net/bonding -I../drivers/net/bonding -Ilib/member -I../lib/member -Ilib/pdcp -I../lib/pdcp -Ilib/reorder -I../lib/reorder -Ilib/pdump -I../lib/pdump -Ilib/power -I../lib/power -Ilib/ptr_compress -I../lib/ptr_compress -Ilib/rawdev -I../lib/rawdev -Ilib/stack -I../lib/stack -Ilib/pipeline -I../lib/pipeline -Idrivers/crypto/scheduler -I../drivers/crypto/scheduler -I/usr/include/libnl3 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -fdiagnostics-color=3Dalways -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -std=3Dc11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-zero-length-bounds -Wno-pointer-to-int-cast -D_GNU_SOURCE -fcommon -Werror -march=3Darmv7-a -mfpu=3Dneon -DALLOW_EXPERIMENTAL_API -Wno-format-truncation -fno-strict-aliasing -DALLOW_INTERNAL_API -MD -MQ app/dpdk-test.p/test_test_ptr_compress.c.o -MF app/dpdk-test.p/test_test_ptr_compress.c.o.d -o app/dpdk-test.p/test_test_ptr_compress.c.o -c ../app/test/test_ptr_compress.c [ 395s] FAILED: app/dpdk-test.p/test_test_ptr_compress.c.o [ 395s] cc -Iapp/dpdk-test.p -Iapp -I../app -Ilib/cmdline -I../lib/cmdline -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/arm/include -I../lib/eal/arm/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Idrivers/net/ring -I../drivers/net/ring -Ilib/ethdev -I../lib/ethdev -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/acl -I../lib/acl -Ilib/argparse -I../lib/argparse -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -Ilib/bitratestats -I../lib/bitratestats -Ilib/bpf -I../lib/bpf -Ilib/compressdev -I../lib/compressdev -Ilib/cryptodev -I../lib/cryptodev -Ilib/security -I../lib/security -Ilib/dispatcher -I../lib/dispatcher -Ilib/eventdev -I../lib/eventdev -Ilib/timer -I../lib/timer -Ilib/dmadev -I../lib/dmadev -Ilib/distributor -I../lib/distributor -Ilib/efd -I../lib/efd -Ilib/fib -I../lib/fib -Ilib/rib -I../lib/rib -Ilib/table -I../lib/table -Ilib/port -I../lib/port -Ilib/sched -I../lib/sched -Ilib/ip_frag -I../lib/ip_frag -Ilib/lpm -I../lib/lpm -Ilib/graph -I../lib/graph -Ilib/pcapng -I../lib/pcapng -Ilib/ipsec -I../lib/ipsec -Ilib/latencystats -I../lib/latencystats -Idrivers/net/bonding -I../drivers/net/bonding -Ilib/member -I../lib/member -Ilib/pdcp -I../lib/pdcp -Ilib/reorder -I../lib/reorder -Ilib/pdump -I../lib/pdump -Ilib/power -I../lib/power -Ilib/ptr_compress -I../lib/ptr_compress -Ilib/rawdev -I../lib/rawdev -Ilib/stack -I../lib/stack -Ilib/pipeline -I../lib/pipeline -Idrivers/crypto/scheduler -I../drivers/crypto/scheduler -I/usr/include/libnl3 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -fdiagnostics-color=3Dalways -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -std=3Dc11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-zero-length-bounds -Wno-pointer-to-int-cast -D_GNU_SOURCE -fcommon -Werror -march=3Darmv7-a -mfpu=3Dneon -DALLOW_EXPERIMENTAL_API -Wno-format-truncation -fno-strict-aliasing -DALLOW_INTERNAL_API -MD -MQ app/dpdk-test.p/test_test_ptr_compress.c.o -MF app/dpdk-test.p/test_test_ptr_compress.c.o.d -o app/dpdk-test.p/test_test_ptr_compress.c.o -c ../app/test/test_ptr_compress.c [ 395s] In file included from ../app/test/test.h:14, [ 395s] from ../app/test/test_ptr_compress.c:5: [ 395s] ../lib/ptr_compress/rte_ptr_compress.h: In function =C3=A2=E2=82=AC=CB=9Crte_ptr_decompress_32_shift=C3=A2=E2=82=AC=E2=84=A2: [ 395s] ../lib/eal/include/rte_common.h:404:30: error: cast to pointer from integer of different size [-Werror=3Dint-to-pointer-cast] [ 395s] 404 | #define RTE_PTR_ADD(ptr, x) ((void*)((uintptr_t)(ptr) + (x= ))) [ 395s] | ^ [ 395s] ../lib/ptr_compress/rte_ptr_compress.h:219:33: note: in expansion of macro =C3=A2=E2=82=AC=CB=9CRTE_PTR_ADD=C3=A2=E2=82=AC=E2=84=A2 [ 395s] 219 | dest_table[i] =3D RTE_PTR_ADD(ptr_base, ptr_diff); [ 395s] | ^~~~~~~~~~~ [ 395s] cc1: all warnings being treated as errors Please have a look. Thanks. --=20 David Marchand