Re: [EXTERNAL] [PATCH v2] app/graph: fix destination buffer too small

[David Marchand <david.marchand@redhat.com>]

On Thu, Jun 27, 2024 at 2:44 AM Kiran Kumar Kokkilagadda
<kirankumark@marvell.com> wrote:
> > On 06/25, Kiran Kumar Kokkilagadda wrote: > > > From: Mahmoud Maatuq
> > <mahmoudmatook. mm@ gmail. com> > Sent: Tuesday, June 25, 2024 1: 31
> > AM > To: Sunil Kumar Kori <skori@ marvell. com>; Rakesh Kudurumalla
> > <rkudurumalla@ marvell. com>;
> > On 06/25, Kiran Kumar Kokkilagadda wrote:
> > > Subject: [EXTERNAL] [PATCH v2] app/graph: fix destination buffer too
> > > small
> > >
> > > as sizeof(config. rx. mempool_name) is < sizeof(res->mempool) we
> > > should copy at most sizeof(config. rx. mempool_name) and replace memcpy
> > with strlcpy as mempool name is a null terminated string Coverity issue:
> > 415430 Fixes: 3850cb06ab9c ("app/graph:
> > >
> > >
> > > as sizeof(config.rx.mempool_name) is < sizeof(res->mempool) we should
> > >
> > > copy at most sizeof(config.rx.mempool_name) and replace memcpy with
> > >
> > > strlcpy as mempool name is a null terminated string
> > >
> > >
> > >
> > > Coverity issue: 415430
> > >
> > > Fixes: 3850cb06ab9c ("app/graph: add ethdev commands")
> > >
> > > Cc: skori@marvell.com<mailto:skori@marvell.com>
> > >
> > >
> > >
> > > Signed-off-by: Mahmoud Maatuq
> > >
> > <mahmoudmatook.mm@gmail.com<mailto:mahmoudmatook.mm@gmail.co
> > m>>
> > >
> > > ---
>
> Acked-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>

This patch does not pass the CI, please check.


-- 
David Marchand