From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B7D845556; Thu, 4 Jul 2024 17:17:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCF6A410F1; Thu, 4 Jul 2024 17:17:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C01BF4042F for ; Thu, 4 Jul 2024 17:17:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720106254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hFI4ZkEbOr9u1J9qkMJoPxaRmzw9oL6sdpf8UhPqHFw=; b=AP+CWb9KAKO1im919NcLNl2jocdrMHfgtFtZdpC6pm89rCwxmWwjBaqnpvJAtnZ5P1KA1v 2aoaHNEm3Y8IBxC3ElhKiTh+CMkqOmKfQvMHZKtCbx9sSMkoH91n5OjslG1WkCRO2I+BTG gmcrtw8UIH8jTRyuW4WiA2Xo3nDkh7w= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-2Q9BG-opMnijAIZwnX5Zmg-1; Thu, 04 Jul 2024 11:17:32 -0400 X-MC-Unique: 2Q9BG-opMnijAIZwnX5Zmg-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-52ce42bb0efso787095e87.2 for ; Thu, 04 Jul 2024 08:17:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720106251; x=1720711051; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hFI4ZkEbOr9u1J9qkMJoPxaRmzw9oL6sdpf8UhPqHFw=; b=sdUuDB6sUU2biioEWyHGTX+LEOblXQVsD0zUg6b2brUG75Yt3jHHlWCjINXtl05x0N qVQZfbgs5yZ3PmIxx8R4l25DE5s2SeBdWgRg+mY/ls1BxvB4BNYZ2/aa80VJW0QfReNM lMnXrQxn725jJHYBAIpi9Mt6BptoxVfw+tIrYZgLQrk2LcE88SUJ+FzyNwZWZUbI/rG3 Qqxdhi8Ap6J94tD5Feq1wBTMhP8lw3wQd/kOCaPnTPuPLnL6Mh4iUFV7LFjcBqQeXmai wf6tKwwqu6Mr4AbFMFkryy4VZP04+5+dBt1F9F6DfVgcrl2m+DcTJBTA8UNE4lXadGMn EO2g== X-Forwarded-Encrypted: i=1; AJvYcCXbOn1CcWq/+Z/4kO63zP+E6z4KBOaJ0EgksQu83zGydgThtrdA7gDHsOY64/mljraCcef8DWRAZ+1CaeM= X-Gm-Message-State: AOJu0YyGKEqpfQPwgvCVrEgMrYlXNwol2PKwe5Tqt/Mt/fvlTl3KtRLI /N1MTExqQLxwSUat1g46MBT3bX6ObMpUG+VCuvEC3uhVDHFRcJSe9ULpTL8o5xm9jmM1qWlHsru 4IkvuCOGtHhS1JCZqQFDVFgq2SV0VR2YEw12Fn+NwWZr3iqjPyUUBM28j/kyp7lv9qqUdhLWLrD 9vuxOOEi2DBUcfN3k= X-Received: by 2002:a19:2d18:0:b0:52c:e030:1450 with SMTP id 2adb3069b0e04-52ea061fae2mr1176668e87.14.1720106251265; Thu, 04 Jul 2024 08:17:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHner2YIt6WF094uEMUOJRvQZ7VSoAb/LDM7P1mbBwWObm7N17SNLll3xSUYlHF6581z9yzKvg6xq9QAl+SrFs= X-Received: by 2002:a19:2d18:0:b0:52c:e030:1450 with SMTP id 2adb3069b0e04-52ea061fae2mr1176654e87.14.1720106250863; Thu, 04 Jul 2024 08:17:30 -0700 (PDT) MIME-Version: 1.0 References: <20240623200921.1715890-1-mahmoudmatook.mm@gmail.com> <20240624200114.1792214-1-mahmoudmatook.mm@gmail.com> In-Reply-To: From: David Marchand Date: Thu, 4 Jul 2024 17:17:19 +0200 Message-ID: Subject: Re: [EXTERNAL] [PATCH v2] app/graph: fix destination buffer too small To: Kiran Kumar Kokkilagadda , Mahmoud Matook Cc: Sunil Kumar Kori , Rakesh Kudurumalla , Nithin Kumar Dabilpuram , Jerin Jacob , "dev@dpdk.org" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 27, 2024 at 2:44=E2=80=AFAM Kiran Kumar Kokkilagadda wrote: > > On 06/25, Kiran Kumar Kokkilagadda wrote: > > > From: Mahmoud Maatuq > > > Sent: Tuesday= , June 25, 2024 1:=E2=80=8A31 > > AM > To: Sunil Kumar Kori ; Rakesh= Kudurumalla > > ; > > On 06/25, Kiran Kumar Kokkilagadda wrote: > > > Subject: [EXTERNAL] [PATCH v2] app/graph: fix destination buffer too > > > small > > > > > > as sizeof(config.=E2=80=8Arx.=E2=80=8Amempool_name) is < sizeof(res->= mempool) we > > > should copy at most sizeof(config.=E2=80=8Arx.=E2=80=8Amempool_name) = and replace memcpy > > with strlcpy as mempool name is a null terminated string Coverity issue= : > > 415430 Fixes: 3850cb06ab9c ("app/graph: > > > > > > > > > as sizeof(config.rx.mempool_name) is < sizeof(res->mempool) we should > > > > > > copy at most sizeof(config.rx.mempool_name) and replace memcpy with > > > > > > strlcpy as mempool name is a null terminated string > > > > > > > > > > > > Coverity issue: 415430 > > > > > > Fixes: 3850cb06ab9c ("app/graph: add ethdev commands") > > > > > > Cc: skori@marvell.com > > > > > > > > > > > > Signed-off-by: Mahmoud Maatuq > > > > > > m>> > > > > > > --- > > Acked-by: Kiran Kumar Kokkilagadda This patch does not pass the CI, please check. --=20 David Marchand