From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C999A32A2 for ; Thu, 24 Oct 2019 18:02:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 755611EB5A; Thu, 24 Oct 2019 18:02:44 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 9828D1EB53 for ; Thu, 24 Oct 2019 18:02:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571932956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IBPWjd53c/pmRvjevXT7JeptGZFPFnhT7JFRyLesgb0=; b=a6k/djQy124HlqB/457LV43me887DxrxbvXFrhkvbn40shTp67uraszbG6dw1XbBlAuOcE LfL5xSwaMJZs2mJdU+AwCtum5+EVSipromkOvI9SxmkXi8NugmIrVPce9ikc/iUfDNS+9T RhGDN5aIqnxRRzjtH6EfT2YXebOJ54I= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-W26z_9H5MXWGla0Yz-gDQw-1; Thu, 24 Oct 2019 12:02:09 -0400 Received: by mail-vk1-f200.google.com with SMTP id n6so7833825vke.22 for ; Thu, 24 Oct 2019 09:02:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HDhXJbK6Ddi270Jkj9k5Jx0r2dmaxoUnTeIYp4QyIvk=; b=Xg27mF3HRyDht/3U0hNCWaGjinUZc/dkZvNFcZ9jGGSQmo+Y81SeZsltfr7RphZvWL wmj+P3krngALYYXrULyWchoosP562YzXEzecQ5b+JNlJAD3XkxbPGs+FI84OOhncPw7o BJS0zgEWHR1WK1OA7CC0Hp1hYFmNmVTAB4tKCFgUxN+Dnxawf/z4gt2w3r2JH+FnpL/C ue0/DRBnAydJjlLk34iJ27J0lcpOdWpiRJPz4dwWi10pWnQKVltm5k4Muj2aF2p3R/gZ QX9+gUFH9R1oGWil1b/MMgMXKux82upPiNQwRmczCiWrUe42nYGSLMvBP1+Xnr+C8qEY lUVg== X-Gm-Message-State: APjAAAUN2rd4aE1T+aGmK3CfEQ9TedXMdhlfttIA96gmAlxK3aznmZvq G/f4XyTHJjCprqtNoYjb2T/aP8YTDKZ9x8nM58sjBW4jLOaNTMdYQIL3ZlIVc7UXXlsnTNlugY2 X86h6GHF3GUs1+bcD/Ao= X-Received: by 2002:a1f:3811:: with SMTP id f17mr8828504vka.56.1571932928173; Thu, 24 Oct 2019 09:02:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqwoMJuWGcHiKY4/y0kIoNT2zjLUFYtN73rLkaNIRheSV6O0j649AgW9XCg9PLNQ++O/7SAAWhXHMVtoSrQAZ3k= X-Received: by 2002:a1f:3811:: with SMTP id f17mr8828467vka.56.1571932927669; Thu, 24 Oct 2019 09:02:07 -0700 (PDT) MIME-Version: 1.0 References: <1571736761-32134-1-git-send-email-david.marchand@redhat.com> <1571856864-8779-1-git-send-email-david.marchand@redhat.com> <20191023141001.2450e0ce@hermes.lan> <20191024083734.6b07f99c@hermes.lan> In-Reply-To: <20191024083734.6b07f99c@hermes.lan> From: David Marchand Date: Thu, 24 Oct 2019 18:01:56 +0200 Message-ID: To: Stephen Hemminger Cc: Thomas Monjalon , dev , "Burakov, Anatoly" X-MC-Unique: W26z_9H5MXWGla0Yz-gDQw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 00/12] EAL and PCI ABI changes for 19.11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 24, 2019 at 5:37 PM Stephen Hemminger wrote: > > > > rte_logs could be hidden, but I am not that confortable about > > > > doing it right away: I added an accessor to rte_logs.file, but I am= fine > > > > with dropping the last patch and wait for actually hiding this in t= he next > > > > ABI break. > > > > > > 19.11 is an api/abi break so maybe do it now. > > > > I went and hid more internals, I did not see an impact on really basic = bench. > > > > I would appreciate other opinions. > > These all look good. There is probably a lot more that could be > done, adding more accessors in 20.02 could help but more hiding won't hap= pen > again until 20.11 Yes, I went with the low hanging fruits. It is a long term effort in any case, when reviewing too. --=20 David Marchand