From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E2E6A0093; Tue, 4 Jan 2022 16:02:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E523240042; Tue, 4 Jan 2022 16:02:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EFC8940040 for ; Tue, 4 Jan 2022 16:02:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641308575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u8qmefVKRghCN55LunHP8pdZ+quf/yNfT/DWz1T523M=; b=eNm6bfPBI7ZOGIPxiJusmMqDyQ+ZK9iH4/deHlgDo83+UUgbEYHRMY/06h4gaYlzAUm1gU Ql+ut57kOh9v99VcQPY9/G7K8tgldCTkeTnXlw3BTwRg8BaLrUjFetrgFKyLSRQjCTIhAk wsVKo7SVXdZVt5YR985D+phVDZkpoUw= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-260-zqnA_9U8NwKK25PK1DJwzg-1; Tue, 04 Jan 2022 10:02:54 -0500 X-MC-Unique: zqnA_9U8NwKK25PK1DJwzg-1 Received: by mail-lj1-f197.google.com with SMTP id j15-20020a2e6e0f000000b0022db2724332so9410359ljc.3 for ; Tue, 04 Jan 2022 07:02:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u8qmefVKRghCN55LunHP8pdZ+quf/yNfT/DWz1T523M=; b=05GHjj8IG3sR7IkrUswhNHhFJdteQonVpeBWsMgwEK0HxlVvKxURVfKhxyr9vtPif7 Od3FcJ04Diwuwy1jzfVC5F5Wod4OS4rvn1pB+eaBI/hEYxdEVYqnPTc5HqEmHBhQjBQ9 5JYHM9vKRR8vyD5Utu+LLxzBzGnIJP4PYVdX8+16MBPrNrEHhkS77caSCfslNKKiLBJp KKJLiqyn4g5oTdbhbrR7LN7l3Sp6Jc+bpPOZQWL1fBB7iARpgx1jr19XXiN2avI+Q0+X vVl6tdynyMCn7rBrpNVDuGoxV5ZCPnGbyCCVJ914nnBNCWhdANV3w7nFXdYBVkzUNIIH wHSw== X-Gm-Message-State: AOAM532OvZ7RKcLga/APvKM9v9Y+PfuStOyzjgy4pR2bPXXUhYWk9aXi FZ8u76Ht0PC3QMEcCSB5tu22fb7HX7c0+XCgYc13pHhXQ1APSkaG8/IruE6z0XPLVE8o12nxtbM kwZfoEJDgNr+ErqR5Utw= X-Received: by 2002:a05:651c:98c:: with SMTP id b12mr40773082ljq.81.1641308572729; Tue, 04 Jan 2022 07:02:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzeCVUGm96rOTcSFGt/JbpJfy+juuL6DgDGnFTA8hARwBE4aOsHlcciNpF4yQsG3UIE2IwBn837Pos5rfZEhIA= X-Received: by 2002:a05:651c:98c:: with SMTP id b12mr40773069ljq.81.1641308572495; Tue, 04 Jan 2022 07:02:52 -0800 (PST) MIME-Version: 1.0 References: <20211223083659.245766-1-maxime.coquelin@redhat.com> <20211223083659.245766-4-maxime.coquelin@redhat.com> In-Reply-To: <20211223083659.245766-4-maxime.coquelin@redhat.com> From: David Marchand Date: Tue, 4 Jan 2022 16:02:41 +0100 Message-ID: Subject: Re: [PATCH 3/7] vhost: improve socket layer logs To: Maxime Coquelin Cc: dev , "Xia, Chenbo" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 23, 2021 at 9:37 AM Maxime Coquelin wrote: > @@ -471,16 +468,14 @@ vhost_user_client_reconnect(void *arg __rte_unused) > sizeof(reconn->un)); > if (ret == -2) { > close(reconn->fd); > - VHOST_LOG_CONFIG(ERR, > - "reconnection for fd %d failed\n", > - reconn->fd); > + VHOST_LOG_CONFIG(ERR, "(%s) reconnection for fd %d failed\n", > + reconn->vsocket->path, reconn->fd); > goto remove_fd; > } > if (ret == -1) > continue; > > - VHOST_LOG_CONFIG(INFO, > - "%s: connected\n", reconn->vsocket->path); > + VHOST_LOG_CONFIG(INFO, "%s: connected\n", reconn->vsocket->path); Another nit that I caught when testing in OVS. For consistency, we can have () around the socket path. dpdk|WARN|VHOST_CONFIG: (/var/lib/vhost_sockets/vhost0) failed to connect: No such file or directory dpdk|INFO|VHOST_CONFIG: (/var/lib/vhost_sockets/vhost0) reconnecting... dpdk|INFO|VHOST_CONFIG: /var/lib/vhost_sockets/vhost4: connected dpdk|INFO|VHOST_CONFIG: (/var/lib/vhost_sockets/vhost4) new device, handle is 0 dpdk|INFO|VHOST_CONFIG: /var/lib/vhost_sockets/vhost5: connected dpdk|INFO|VHOST_CONFIG: (/var/lib/vhost_sockets/vhost5) new device, handle is 1 dpdk|INFO|VHOST_CONFIG: /var/lib/vhost_sockets/vhost6: connected dpdk|INFO|VHOST_CONFIG: (/var/lib/vhost_sockets/vhost6) new device, handle is 2 dpdk|INFO|VHOST_CONFIG: /var/lib/vhost_sockets/vhost7: connected dpdk|INFO|VHOST_CONFIG: (/var/lib/vhost_sockets/vhost7) new device, handle is 3 > vhost_user_add_connection(reconn->fd, reconn->vsocket); > remove_fd: > TAILQ_REMOVE(&reconn_list.head, reconn, next); -- David Marchand