From: David Marchand <david.marchand@redhat.com>
To: dev <dev@dpdk.org>
Cc: Kevin Laatz <kevin.laatz@intel.com>,
Ciara Power <ciara.power@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Keith Wiles <keith.wiles@intel.com>
Subject: Re: [dpdk-dev] [PATCH] telemetry: fix build for armv7
Date: Mon, 11 May 2020 17:21:00 +0200 [thread overview]
Message-ID: <CAJFAV8wLb50Y6eya6O1AOBM-oUEOdx3FGS+yCpyoy+bn2-LvAA@mail.gmail.com> (raw)
In-Reply-To: <20200511133212.21444-1-david.marchand@redhat.com>
On Mon, May 11, 2020 at 3:32 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> telemetry can not depend on EAL anymore but it still wants to get arch
> headers.
> We directly point at the right source directories by using the same logic
> than EAL. However the special case of armv7 has been missed.
>
> Fix this by defaulting ARCH_DIR to RTE_ARCH.
>
> Caught on OBS:
> [ 162s] SYMLINK-FILE include/rte_telemetry.h
> [ 162s] CC telemetry.o
> [ 162s] CC telemetry_data.o
> [ 162s] CC telemetry_legacy.o
> [ 162s] .../lib/librte_telemetry/telemetry.c:15:10: fatal error:
> rte_spinlock.h: No such file or directory
> [ 162s] #include <rte_spinlock.h>
> [ 162s] ^~~~~~~~~~~~~~~~
> [ 162s] compilation terminated.
>
> Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied.
--
David Marchand
prev parent reply other threads:[~2020-05-11 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 13:32 David Marchand
2020-05-11 13:47 ` Bruce Richardson
2020-05-11 13:58 ` David Marchand
2020-05-11 14:23 ` Bruce Richardson
2020-05-11 15:21 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wLb50Y6eya6O1AOBM-oUEOdx3FGS+yCpyoy+bn2-LvAA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).