From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7ED5A0528; Thu, 9 Jul 2020 12:30:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 945991D9FD; Thu, 9 Jul 2020 12:30:27 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 38C3F1D9DA for ; Thu, 9 Jul 2020 12:30:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594290624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=llx4j5mOo7ZZ06d1sOW2PeTpSDFLGNXqRqmKvu2eA0U=; b=L0cixykFjeyWT2pe4hXVMbSfAB5CcIxSVefxhWqpn8bXHvUc9dMyjs207UlujeFCWgwZjN ABZ3w3WwiHy9z9nforXHceGJpiPkE5uQBLehLCLm98zQzHdUgGbJBoxuweBVJ2L8tYWNiF 93k3/TN7sfmxrcrUYF4VBlTlxN3X33w= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-40-hzAfh8MCPBavKYp-Ul6qow-1; Thu, 09 Jul 2020 06:30:21 -0400 X-MC-Unique: hzAfh8MCPBavKYp-Ul6qow-1 Received: by mail-ua1-f69.google.com with SMTP id b25so708130uaj.2 for ; Thu, 09 Jul 2020 03:30:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=llx4j5mOo7ZZ06d1sOW2PeTpSDFLGNXqRqmKvu2eA0U=; b=LbLnEXpqE9ff5Z9vjK2WuqZpNDZB/0x8Aqi3Kt3aB0aoy7F3zT5RTmryZwpeA/oDge uiKgAgx0wYIthczYgSvweF5a5lZ63rm3Dfhzc5W/XIoHOvvTZW1ZP7zk148oQEbkVqeJ G0izEBSTopzFxI/V1T8GWIAEnDIu50l8+9AkUIaAIKCHel5RIszRMAMt9FFWlq4CHpTc ZS6DMP/Kj8hVf9LrwY4fwH7jImZd36J/z4Vbq/3EDE783h6DiZcdLDPHwSTuK82jxVep OF7lyvJtY1BmtRRPuue/jHK77b7ondNiCvtD6eAnRitcafkKaFfDMWxIOCjJR/sTNcfV PQig== X-Gm-Message-State: AOAM531QMVHuSgT1lxSUzOFHnopw4PZagN5iEm+XDM/iP/Ymys0gsI53 9uKWtG++e/tl8dJ1XhKZOffSAZ5g3uIEgbn715vjoU8aTEAviK91YuOMxIz6tK3FwifWuoMYtWS Ty/B3JXJ2rOzWmPCpFeo= X-Received: by 2002:a67:b741:: with SMTP id l1mr48094445vsh.180.1594290620498; Thu, 09 Jul 2020 03:30:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAZqtpyxx5UqaJoPajQv3YY2tyioOnPUaPaWq6qQcsgIKeL26i43tM4G4MnFPTkH7U6MAqqVERCab72GVt1O0= X-Received: by 2002:a67:b741:: with SMTP id l1mr48094416vsh.180.1594290620198; Thu, 09 Jul 2020 03:30:20 -0700 (PDT) MIME-Version: 1.0 References: <1594277162-15021-1-git-send-email-phil.yang@arm.com> <1594283675-15965-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1594283675-15965-1-git-send-email-phil.yang@arm.com> From: David Marchand Date: Thu, 9 Jul 2020 12:30:09 +0200 Message-ID: To: Phil Yang , Ray Kinsella , Harman Kalra Cc: dev , stefan.puiu@gmail.com, Aaron Conole , David Christensen , Honnappa Nagarahalli , "Ruifeng Wang (Arm Technology China)" , nd , Dodji Seketeli , Neil Horman Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] eal: use c11 atomic built-ins for interrupt status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 9, 2020 at 10:35 AM Phil Yang wrote: > > The event status is defined as a volatile variable and shared between > threads. Use c11 atomic built-ins with explicit ordering instead of > rte_atomic ops which enforce unnecessary barriers on aarch64. > > The event status has been cleaned up by the compare-and-swap operation > when we free the event data, so there is no need to set it to invalid > after that. > > Signed-off-by: Phil Yang > Reviewed-by: Ruifeng Wang > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Harman Kalra > --- > v3: > Fixed typo. > > v2: > 1. Fixed typo. > 2. Updated libabigail.abignore to pass ABI check. > 3. Merged v1 two patches into one patch. > > devtools/libabigail.abignore | 4 +++ > lib/librte_eal/include/rte_eal_interrupts.h | 2 +- > lib/librte_eal/linux/eal_interrupts.c | 48 ++++++++++++++++++++--------- > 3 files changed, 38 insertions(+), 16 deletions(-) > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index 0133f75..daa4631 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -48,6 +48,10 @@ > changed_enumerators = RTE_CRYPTO_AEAD_LIST_END > [suppress_variable] > name = rte_crypto_aead_algorithm_strings > +; Ignore updates of epoll event > +[suppress_type] > + type_kind = struct > + name = rte_epoll_event In general, ignoring all changes on a structure is risky. But the risk is acceptable as long as we remember this for the rest of the 20.08 release (and we will start from scratch for 20.11). Without any comment from others, I'll merge this by the end of (my) day. Thanks. -- David Marchand