From: David Marchand <david.marchand@redhat.com>
To: Sunil Kumar Kori <skori@marvell.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] bus/pci: optimise scanning with whitelist/blacklist
Date: Fri, 17 Apr 2020 10:44:29 +0200 [thread overview]
Message-ID: <CAJFAV8wLnUAeaied=X2qjHwQR6BN5dnwL5ifj1momGSLXpf2sA@mail.gmail.com> (raw)
In-Reply-To: <20200407092856.554-1-skori@marvell.com>
On Tue, Apr 7, 2020 at 11:29 AM Sunil Kumar Kori <skori@marvell.com> wrote:
>
> rte_bus_scan API scans all the available PCI devices irrespective of white
> or black listing parameters then further devices are probed based on white
> or black listing parameters. So unnecessary CPU cycles are wasted during
> rte_pci_scan.
>
> For Octeontx2 platform with core frequency 2.4 Ghz, rte_bus_scan consumes
> around 26ms to scan around 90 PCI devices but all may not be used by the
> application. So for the application which uses 2 NICs, rte_bus_scan
> consumes few microseconds and rest time is saved with this patch.
>
> Patch restricts devices to be scanned as per below mentioned conditions:
> - All devices will be scanned if no parameters are passed.
> - Only white listed devices will be scanned if white list is available.
> - All devices, except black listed, will be scanned if black list is
> available.
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
> v2:
> - Added function to validate ignorance of device based on PCI address.
First you objected to Stephen comment, and later announced there was
no objection.
Now, it seems you ignored what I replied without any explanation.
So tell me, what was wrong with
https://github.com/david-marchand/dpdk/commit/e7860231ecdce91f9f70027d4090a7057b8fd5f7
?
> - Marked device validation function as experimental.
Useless, this symbol is internal and not exported.
--
David Marchand
next prev parent reply other threads:[~2020-04-17 8:44 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 7:55 [dpdk-dev] [PATCH] bus/pci: restricted bus scanning to allowed devices Sunil Kumar Kori
2019-12-16 16:13 ` Stephen Hemminger
2019-12-17 11:00 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-01-21 8:39 ` Sunil Kumar Kori
[not found] ` <MN2PR18MB327936807460D9F2AE4894F3B40F0@MN2PR18MB3279.namprd18.prod.outlook.com>
2020-02-27 8:30 ` Sunil Kumar Kori
2020-03-09 6:06 ` Sunil Kumar Kori
2020-04-06 9:32 ` Sunil Kumar Kori
2020-04-06 13:21 ` David Marchand
2020-04-07 9:21 ` Sunil Kumar Kori
2020-04-07 9:28 ` [dpdk-dev] [PATCH v2 1/1] bus/pci: optimise scanning with whitelist/blacklist Sunil Kumar Kori
2020-04-17 8:30 ` Sunil Kumar Kori
2020-04-17 8:44 ` David Marchand [this message]
2020-04-17 11:15 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-04-17 13:25 ` David Marchand
2020-04-17 15:12 ` Sunil Kumar Kori
2020-04-17 15:35 ` David Marchand
2020-04-17 16:00 ` Sunil Kumar Kori
2020-04-20 6:59 ` Sunil Kumar Kori
2020-04-20 6:55 ` [dpdk-dev] [PATCH v3 " Sunil Kumar Kori
2020-04-21 15:18 ` Gaëtan Rivet
2020-04-22 6:17 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-04-22 9:38 ` Gaëtan Rivet
2020-04-23 7:47 ` Sunil Kumar Kori
2020-04-27 18:43 ` [dpdk-dev] " Gaëtan Rivet
2020-04-28 13:52 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-05-01 11:39 ` [dpdk-dev] [PATCH v4 " Sunil Kumar Kori
2020-05-01 12:40 ` Sunil Kumar Kori
2020-05-01 21:00 ` Gaëtan Rivet
2020-05-02 7:20 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-05-02 7:42 ` [dpdk-dev] [PATCH v5 " Sunil Kumar Kori
2020-05-02 11:27 ` Gaëtan Rivet
2020-05-04 14:17 ` David Marchand
2020-05-05 5:57 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-05-06 12:54 ` [dpdk-dev] " David Marchand
2020-05-11 14:59 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wLnUAeaied=X2qjHwQR6BN5dnwL5ifj1momGSLXpf2sA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=skori@marvell.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).