From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 357C5A058A; Fri, 17 Apr 2020 10:44:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1AB091DEAB; Fri, 17 Apr 2020 10:44:47 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 245AB1DBB9 for ; Fri, 17 Apr 2020 10:44:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587113085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SKbNnBnediExT8N4IluEm9bQcqyCXeOohOl2E6uiGhE=; b=MP3pGFjtDewqa8s3PkdIgOtZpUIviR5gAgXe6PIzjiV/8XSLRNXKa2fIvRiRR6IPCcoUI6 5qt0J1L1+0RLk+TGv/3MhSYnuBDpy8p55DYCDWwnfXoWwg76AFd/p3r/tvmTmH0actqbhl 5W3TVeJo41spBco5gAPJ02CvE2SYgXY= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-kzCJxwIBMoOBzKhzjOw5Dw-1; Fri, 17 Apr 2020 04:44:42 -0400 X-MC-Unique: kzCJxwIBMoOBzKhzjOw5Dw-1 Received: by mail-ua1-f72.google.com with SMTP id o24so631742uap.13 for ; Fri, 17 Apr 2020 01:44:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hnplhn+ELbvZVi7TUhc0ZflQghfRbvBbksv+18ba3yQ=; b=QWDEKP1LokjQ7s/zgMLGf36ZvbERSWkWt2FYuwheb9bkddu2aO9RdKsXtvzkc8PwR6 qp0KoCnUxlL6lUQw6z2Uxg8UgtaeX2YIGPCPPcrUKj67AlPw+xlO8oIWA9ow5LW0Wbty 5xldJexlQP8i02deua5t0TwNfiTE9UiHnQSnt/MU0SFY5tF5Qj/ODNNF+UvwwMRJxwmM 710GbgSesb9NGXn7StMOHZ1IY+CH4kecPBscswvm0Ef90wl053sMC/+W/tEfXNZe30C+ XaWsGp/8EUIBzVxizYgRcRXQOt5aySrK6+HWuLCKqRkyTWp8iumdK7K4MaWBnT/yy9XP ZLlQ== X-Gm-Message-State: AGi0Pub4z1KCVgx5lg9y1wQwyWnqmLM85VO5mak2NJuQsmoGc2lw/oAy Yow0b8A2YwzVYL8FTBtLkofJIBoOWi5djD2Y6c02+A6xQulJysHwveFQwFi/p42kjrfXqwIkHgE gzDBOVQGIn3Xq0hQ2RMk= X-Received: by 2002:ab0:5ad1:: with SMTP id x17mr1522621uae.126.1587113081516; Fri, 17 Apr 2020 01:44:41 -0700 (PDT) X-Google-Smtp-Source: APiQypKLjmOfbWsaQArZhw+DRwd9PPImZ+lu/T53TNTT0U3UZ5CccRhrSiz/FwDVEINuC+zORepQhbj78tSxrNErDRc= X-Received: by 2002:ab0:5ad1:: with SMTP id x17mr1522605uae.126.1587113081223; Fri, 17 Apr 2020 01:44:41 -0700 (PDT) MIME-Version: 1.0 References: <20191216075501.15669-1-skori@marvell.com> <20200407092856.554-1-skori@marvell.com> In-Reply-To: <20200407092856.554-1-skori@marvell.com> From: David Marchand Date: Fri, 17 Apr 2020 10:44:29 +0200 Message-ID: To: Sunil Kumar Kori Cc: Stephen Hemminger , Jerin Jacob Kollanukkaran , dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 1/1] bus/pci: optimise scanning with whitelist/blacklist X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 7, 2020 at 11:29 AM Sunil Kumar Kori wrote: > > rte_bus_scan API scans all the available PCI devices irrespective of whit= e > or black listing parameters then further devices are probed based on whit= e > or black listing parameters. So unnecessary CPU cycles are wasted during > rte_pci_scan. > > For Octeontx2 platform with core frequency 2.4 Ghz, rte_bus_scan consumes > around 26ms to scan around 90 PCI devices but all may not be used by the > application. So for the application which uses 2 NICs, rte_bus_scan > consumes few microseconds and rest time is saved with this patch. > > Patch restricts devices to be scanned as per below mentioned conditions: > - All devices will be scanned if no parameters are passed. > - Only white listed devices will be scanned if white list is available. > - All devices, except black listed, will be scanned if black list is > available. > > Signed-off-by: Sunil Kumar Kori > --- > v2: > - Added function to validate ignorance of device based on PCI address. First you objected to Stephen comment, and later announced there was no objection. Now, it seems you ignored what I replied without any explanation. So tell me, what was wrong with https://github.com/david-marchand/dpdk/commit/e7860231ecdce91f9f70027d4090a= 7057b8fd5f7 ? > - Marked device validation function as experimental. Useless, this symbol is internal and not exported. --=20 David Marchand