From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by dpdk.org (Postfix) with ESMTP id 24A951B3A8 for ; Tue, 18 Dec 2018 11:38:09 +0100 (CET) Received: by mail-vs1-f54.google.com with SMTP id n13so1755742vsk.4 for ; Tue, 18 Dec 2018 02:38:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tC1gLeQNzVOcPtv5A4mafW/toqWIjjT5WjYDm4gmjlo=; b=Xt1n6otZskV68zmmHQlwq7lF9AJjkin+RsYoABC9TmiWzJlfBfL7065uY2B8Imq3Y0 TSOKfHEiMCW9dxNj1kALMXmWNAIXU8I6+dxMS3y1FZfVD2Jp9/mUulN25rPus/ISl94I SAyy6x2tTSDCsUEhDVO5eA1mhMI4BzYA+6aRcUgwVc6EqiQu0Uey5UJgkveEpJq5j+NN +Q09FojmkXqgmSAsPGXkdU+tkRubdwcOBgOLcPw7nKWyO0Q+z2sXo7zLeii6DFbAsv+8 HwYg9nNXIdiIj9OyvDpzHKzfQS5kp8YIbt53YOlJk9jLcUkp6qtfyeDbTHhtXmJeI13s mdUg== X-Gm-Message-State: AA+aEWbCz+a5e18ApZ5PfUbCkiiP8xkQxzH41qX2RH+asHG8+fB1yWgP EDN0KxsJE9DriTq4RFFXDO/2f4n8Wt0spzxC5w2eqg== X-Google-Smtp-Source: AFSGD/W/rCQg9u3BBH+4bMhYTTbnrgh8Pw7gZeHR/rCyJBws8jC3pssnPHjCLPhT0+zh0ozuL27zRJL7vJ0cZfyJVPg= X-Received: by 2002:a67:c48a:: with SMTP id d10mr1585634vsk.105.1545129488563; Tue, 18 Dec 2018 02:38:08 -0800 (PST) MIME-Version: 1.0 References: <1543957065-20990-1-git-send-email-david.marchand@redhat.com> <20181214123538.GA28669@hmswarspite.think-freely.org> <3D3765A8CDB52A4C8B410430AA19CB23709189AF@IRSMSX104.ger.corp.intel.com> In-Reply-To: <3D3765A8CDB52A4C8B410430AA19CB23709189AF@IRSMSX104.ger.corp.intel.com> From: David Marchand Date: Tue, 18 Dec 2018 11:37:57 +0100 Message-ID: To: Akhil Goyal Cc: Neil Horman , "dev@dpdk.org" , "stable@dpdk.org" , "tredaelli@redhat.com" , "Yigit, Ferruh" , amr.mokhtar@intel.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] bbdev: add missing experimental tags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 10:38:09 -0000 Hello Akhil, On Fri, Dec 14, 2018 at 1:52 PM Mokhtar, Amr wrote: > > > -----Original Message----- > > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > Sent: Friday 14 December 2018 12:36 > > To: David Marchand > > Cc: Akhil Goyal ; dev@dpdk.org; stable@dpdk.org; > > tredaelli@redhat.com; Yigit, Ferruh ; Mokhtar, > > Amr > > Subject: Re: [dpdk-dev] [PATCH] bbdev: add missing experimental tags > > > > On Fri, Dec 14, 2018 at 11:00:17AM +0100, David Marchand wrote: > > > On Fri, Dec 14, 2018 at 10:54 AM Akhil Goyal > > wrote: > > > > > > > Hi David, > > > > > > > > I can see that there are other APIs as well which are not marked as > > > > experimental like rte_bbdev_dec_op_alloc_bulk > > > > rte_bbdev_dec_op_free_bulk, rte_bbdev_enqueue_enc_ops etc. > > > > > > It seems that all APIs defined in rte_bbdev_op.h are missing their > experimental tags. > > > > > > > Well, that's the problem with inlines... > > > I don't think we can detect these easily. > > > > > We can, if the symbols get added to the version map as they should. But > > (as you > > note), because these functions are inlines, theres no error thrown for > not > > following that rule. > > > > Right, there are some APIs missing in the map file. > I am submitting a patch of those functions missing. > Sorry, did not follow up on this. My patch has been marked as "Changes Requested" in pw but Amr volunteered to fix those issues. How do we proceed, do you want a single fix ? or you can already pick mine. -- David Marchand