From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF361A0A0E; Mon, 10 May 2021 15:35:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98AB140140; Mon, 10 May 2021 15:35:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2645B4003E for ; Mon, 10 May 2021 15:35:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620653707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AkQHIVC/LXoAS6y4l+fekjuOSzUXDN3Tu7pZIT2KGJI=; b=JKQ4HRqZvCxqfyfLEalEC3Hwap8qA5z9w7HUW1r8MyMbD2YvIewRIPaOrcLFfPUcE/Vlgc /AIjNCT0Yxvphx0y4ML1xrpUkcOyxg+tdSqj0OCZK7vTflKhIBgATC2KuE9KL+PVHUh7Sg VGyG+t3IsqyaBPXgOYCgh3J1+qCHuc4= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-468-4XW97xDuOWO_Kv1rJuEkBw-1; Mon, 10 May 2021 09:35:05 -0400 X-MC-Unique: 4XW97xDuOWO_Kv1rJuEkBw-1 Received: by mail-vs1-f69.google.com with SMTP id r2-20020a67c3020000b029022a851392d7so3554177vsj.7 for ; Mon, 10 May 2021 06:35:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AkQHIVC/LXoAS6y4l+fekjuOSzUXDN3Tu7pZIT2KGJI=; b=o5qtwP2+vQDBkzLAP3tviFriCrTCCHm8DiK5oYHufvhyukkuQxeXNHn9OL8Pcqv3pB 9d6v3rghZOVCgEa363phxyjegiZnn1IqWvu/YFlOtLSJ1sfpr7LViRDavaEjY9IOTrFk bwdfybUme5G5tuLLTSYYLhmuEIoVAIhwD9zq1UanoF+hPSvmZDujyF7wSbIHzYqVI1XS lkPchZZBBdk72wWUYwhzrUCxR/8RkH8eL4qnUa3v5oKtGHDTPQe1cQp19hk8qPPYYmbH 7BOefPzG0P/hDt6XlDu4N3abk8oPCUamX4KN5MCw8eX8Cz1qoJ8EVS/7zHZtpUyT2lIv 8BOg== X-Gm-Message-State: AOAM533re3ZOfq9SS9D3WKqabVu/U8pY1UuzSfMz/3jyqi3YeoGrUVXM SbNk2LGkn0iBcHl3Z5N39ggWCbruEqjWz2dNebyHyUb0/Kw1TDNmdThPHOVJzPkA74k9ihpGEWI GrrZixKMdpSzeEEhiIxI= X-Received: by 2002:a1f:a681:: with SMTP id p123mr17486517vke.22.1620653705130; Mon, 10 May 2021 06:35:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLGdBku6USKMVsKJ89bh1uNZOjQmH1LXKR9pgPkGUkWoJlulAgYHAb79ogQbmJThdrOoKSxTyFNvTgyeyTmjM= X-Received: by 2002:a1f:a681:: with SMTP id p123mr17486352vke.22.1620653703453; Mon, 10 May 2021 06:35:03 -0700 (PDT) MIME-Version: 1.0 References: <20210509171803.1385-1-pbhagavatula@marvell.com> <20210509171803.1385-2-pbhagavatula@marvell.com> <20210509123931.463d6861@hermes.local> In-Reply-To: From: David Marchand Date: Mon, 10 May 2021 15:34:52 +0200 Message-ID: To: Pavan Nikhilesh Bhagavatula Cc: Stephen Hemminger , Haiyue Wang , Jiawen Wu , Jian Wang , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , "stable@dpdk.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] eal: fix side effects in ptr align macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Pavan, On Mon, May 10, 2021 at 11:50 AM Pavan Nikhilesh Bhagavatula wrote: > > >On Sun, 9 May 2021 22:48:02 +0530 > > wrote: > > > >> From: Pavan Nikhilesh > >> > >> Avoid expanding parameters inside RTE_*_ALIGN macros. > >> Update common_autotest to detect macro side effects. > >> Workaround static arrays relying on RTE_ALIGN macros. > >> > >> Fixes: af75078fece3 ("first public release") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Pavan Nikhilesh > >> Signed-off-by: David Marchand > > > >Why not split these up? It looks like the Intel driver and common part > >could be separate? > > The common changes break intel/mlx5 driver compilation can't separate them. Thanks for working on this. The CI still reports a build error in mlx5. -- David Marchand