From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57334A0A0A; Thu, 20 May 2021 11:59:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DBF7F40143; Thu, 20 May 2021 11:59:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 43D0F40041 for ; Thu, 20 May 2021 11:59:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621504773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ajqZek7pqZgBI2Kdq5r5uuSEehoDtn9UgRCSDSQvtCQ=; b=ixThJIvLpx6IR2vULkpWExDuRR+X8YTAFLn7MiW5gShxaIT9BHFayStv4LaCDwkJhNyoC0 4xf1WBDKvrefyGySSKnV0yVxTAnNm2aJEq2RGxz1v1tIOG4XgGJudkJXAEQs4qJE7scJMA D9lfI1tywdgDOUrJ5I62D5vDa/FuB8w= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-117-5pEdnEu5PtSwT3pGrn2kzA-1; Thu, 20 May 2021 05:59:30 -0400 X-MC-Unique: 5pEdnEu5PtSwT3pGrn2kzA-1 Received: by mail-vk1-f200.google.com with SMTP id 14-20020a056122070eb02901fc32082ad4so1890949vki.12 for ; Thu, 20 May 2021 02:59:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ajqZek7pqZgBI2Kdq5r5uuSEehoDtn9UgRCSDSQvtCQ=; b=PXzvvadebydAcrHIH8dOtIu+LG+SIT3g9WBKfV7DA3G2JKD/sl6sLZSt8y682k8vwP H6kdsIiFoPLTCE88jmCywQg18RPNjMYVp7SQjlsP1yMDkYy8FMs/vp3ysUw/hAh5ZR6M o/7gJeiGuosuMs3BB08upWalMOKjJMBtoNe+U/tIZGfM7Xyx7r+LN1KzNdWHei5GZaAi 6orKNG1X/9FVK8qJ3BwOPUx1iEJulfIIPHeer6PX8ls8W8RqiuH2VbLSQSHmWzXgzVQo 2IS6TTuF5CeDZxO7RvWhhAOze8kKlTDdWmlkDpwKl3PDUlUCTlBwKjVg8llppLs7SfKF HZ0A== X-Gm-Message-State: AOAM533UTBx7xGwderoMnzkDVzgML2xkPfDsv9q4yrEqIDOI90ekQKdZ uIXBux/yzBxI9W2Jr+nEcp0lg+4sMMvYv+lVsYXWrxfoZtCikcYJnho7jSw9hg83usjDlFHbenB ERHPakVX8LusUAwQ1uUU= X-Received: by 2002:a67:7cc4:: with SMTP id x187mr2822878vsc.17.1621504770463; Thu, 20 May 2021 02:59:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYkzJLcPjCx68m67NLgwHTfUX9GG7E+azBc6JXTrUNnXiKihcuZWYdrQziDbuT7bBar8IvkCQdF+Pke8bhKSo= X-Received: by 2002:a67:7cc4:: with SMTP id x187mr2822869vsc.17.1621504770156; Thu, 20 May 2021 02:59:30 -0700 (PDT) MIME-Version: 1.0 References: <20210520075837.30954-1-david.marchand@redhat.com> <7723733.VEPnZyPds5@thomas> In-Reply-To: <7723733.VEPnZyPds5@thomas> From: David Marchand Date: Thu, 20 May 2021 11:59:18 +0200 Message-ID: To: Thomas Monjalon Cc: dev , "Yigit, Ferruh" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] devtools: warn about release notes updates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 20, 2021 at 11:47 AM Thomas Monjalon wrote: > > 20/05/2021 09:58, David Marchand: > > Touching release notes should only be for the current version. > > > > Signed-off-by: David Marchand > > --- > > -VALIDATE_NEW_API=$(dirname $(readlink -f $0))/check-symbol-change.sh > > +ROOTDIR=$(readlink -f $(dirname $(readlink -f $0))/..) > > +VALIDATE_NEW_API=$ROOTDIR/devtools/check-symbol-change.sh > > +FORBIDDEN_TOKENS_SCRIPT=$ROOTDIR/devtools/check-forbidden-tokens.awk > > This change is an unrelated cleanup. > Do we keep it in this patch? I'm fine with it, just asking for clarification. I thought I had dropped it before sending. Yes this is unrelated, will drop in v2. > > > # Enable codespell by default. This can be overwritten from a config file. > > # Codespell can also be enabled by setting DPDK_CHECKPATCH_CODESPELL to a valid path > > @@ -58,7 +60,7 @@ check_forbidden_additions() { # > > -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \ > > -v RET_ON_FAIL=1 \ > > -v MESSAGE='Using rte_panic/rte_exit' \ > > - -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > > + -f $FORBIDDEN_TOKENS_SCRIPT \ > [...] > > +check_release_notes() { # > > + rel_notes_prefix=doc/guides/rel_notes/release_ > > + current_version=$(cat $ROOTDIR/VERSION) > > + major_version=${current_version%%.*} > > + current_version=${current_version##${major_version}.} > > + minor_version=${current_version%%.*} > > A simpler version: > cat VERSION | IFS=. read major minor release Ok with this form. > > > + current_rn=${rel_notes_prefix}${major_version}_${minor_version}.rst > > + > > + ! grep -e '^--- a/'$rel_notes_prefix -e '^+++ b/'$rel_notes_prefix $1 | > > Only the +++ part should matters. It won't catch accidental removals. Besides, something that is not handled with my patch is renames. But if we think those cases would be caught by reviewers, I can simplify this part in v2. -- David Marchand