DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] bus/pci: fix comment explaining device naming
@ 2020-11-16 10:12 Gaetan Rivet
  2020-11-16 11:56 ` Luca Boccassi
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Gaetan Rivet @ 2020-11-16 10:12 UTC (permalink / raw)
  To: dev; +Cc: stephen, Hemant Agrawal, Luca Boccassi, Thomas Monjalon

The original triple negative was hard to read and the attempt
to improve the formulation was commendable, unfortunately the new
comment is the inverse of correct.

Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums")
Cc: stephen@networkplumber.org
Signed-off-by: Gaetan Rivet <grive@u256.net>
---

No Cc:stable as it was not yet released.

 drivers/bus/pci/pci_common.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index b24c069713..d55e5a38cf 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -68,7 +68,9 @@ pci_name_set(struct rte_pci_device *dev)
 	devargs = pci_devargs_lookup(&dev->addr);
 	dev->device.devargs = devargs;
 
-	/* If the device is blocked, no rte_devargs exists for it. */
+	/* When using a block-list, only blocked devices will have
+	 * an rte_devargs. Allowed devices won't have one.
+	 */
 	if (devargs != NULL)
 		/* If an rte_devargs exists, the generic rte_device uses the
 		 * given name as its name.
-- 
2.29.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] bus/pci: fix comment explaining device naming
  2020-11-16 10:12 [dpdk-dev] [PATCH] bus/pci: fix comment explaining device naming Gaetan Rivet
@ 2020-11-16 11:56 ` Luca Boccassi
  2020-11-18 10:46 ` David Marchand
  2020-11-20  9:02 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: Luca Boccassi @ 2020-11-16 11:56 UTC (permalink / raw)
  To: Gaetan Rivet, dev; +Cc: stephen, Hemant Agrawal, Thomas Monjalon

On Mon, 2020-11-16 at 11:12 +0100, Gaetan Rivet wrote:
> The original triple negative was hard to read and the attempt
> to improve the formulation was commendable, unfortunately the new
> comment is the inverse of correct.
> 
> Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums")
> Cc: stephen@networkplumber.org
> Signed-off-by: Gaetan Rivet <grive@u256.net>
> ---
> 
> No Cc:stable as it was not yet released.
> 
>  drivers/bus/pci/pci_common.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
> index b24c069713..d55e5a38cf 100644
> --- a/drivers/bus/pci/pci_common.c
> +++ b/drivers/bus/pci/pci_common.c
> @@ -68,7 +68,9 @@ pci_name_set(struct rte_pci_device *dev)
>  	devargs = pci_devargs_lookup(&dev->addr);
>  	dev->device.devargs = devargs;
>  
> -	/* If the device is blocked, no rte_devargs exists for it. */
> +	/* When using a block-list, only blocked devices will have
> +	 * an rte_devargs. Allowed devices won't have one.
> +	 */
>  	if (devargs != NULL)
>  		/* If an rte_devargs exists, the generic rte_device uses the
>  		 * given name as its name.

Acked-by: Luca Boccassi <bluca@debian.org>

Thanks for fixing my mistake - at least it became readable enough to
understand it was the other way around :-)

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] bus/pci: fix comment explaining device naming
  2020-11-16 10:12 [dpdk-dev] [PATCH] bus/pci: fix comment explaining device naming Gaetan Rivet
  2020-11-16 11:56 ` Luca Boccassi
@ 2020-11-18 10:46 ` David Marchand
  2020-11-20  9:02 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2020-11-18 10:46 UTC (permalink / raw)
  To: Gaetan Rivet
  Cc: dev, Stephen Hemminger, Hemant Agrawal, Luca Boccassi, Thomas Monjalon

On Mon, Nov 16, 2020 at 11:12 AM Gaetan Rivet <grive@u256.net> wrote:
>
> The original triple negative was hard to read and the attempt
> to improve the formulation was commendable, unfortunately the new
> comment is the inverse of correct.
>
> Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums")
> Cc: stephen@networkplumber.org
> Signed-off-by: Gaetan Rivet <grive@u256.net>
> ---
>
> No Cc:stable as it was not yet released.
>
>  drivers/bus/pci/pci_common.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
> index b24c069713..d55e5a38cf 100644
> --- a/drivers/bus/pci/pci_common.c
> +++ b/drivers/bus/pci/pci_common.c
> @@ -68,7 +68,9 @@ pci_name_set(struct rte_pci_device *dev)
>         devargs = pci_devargs_lookup(&dev->addr);
>         dev->device.devargs = devargs;
>
> -       /* If the device is blocked, no rte_devargs exists for it. */
> +       /* When using a block-list, only blocked devices will have

Nit: I don't think we need a -, I would go with blocklist.

> +        * an rte_devargs. Allowed devices won't have one.
> +        */
>         if (devargs != NULL)
>                 /* If an rte_devargs exists, the generic rte_device uses the
>                  * given name as its name.
> --
> 2.29.2
>

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] bus/pci: fix comment explaining device naming
  2020-11-16 10:12 [dpdk-dev] [PATCH] bus/pci: fix comment explaining device naming Gaetan Rivet
  2020-11-16 11:56 ` Luca Boccassi
  2020-11-18 10:46 ` David Marchand
@ 2020-11-20  9:02 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2020-11-20  9:02 UTC (permalink / raw)
  To: Gaetan Rivet
  Cc: dev, Stephen Hemminger, Hemant Agrawal, Luca Boccassi, Thomas Monjalon

On Mon, Nov 16, 2020 at 11:12 AM Gaetan Rivet <grive@u256.net> wrote:
>
> The original triple negative was hard to read and the attempt
> to improve the formulation was commendable, unfortunately the new
> comment is the inverse of correct.
>
> Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums")

Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Gaetan Rivet <grive@u256.net>
Acked-by: Luca Boccassi <bluca@debian.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>

Thanks Gaëtan, applied.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 10:12 [dpdk-dev] [PATCH] bus/pci: fix comment explaining device naming Gaetan Rivet
2020-11-16 11:56 ` Luca Boccassi
2020-11-18 10:46 ` David Marchand
2020-11-20  9:02 ` David Marchand

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox