From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31A76A034C; Mon, 14 Nov 2022 11:03:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B213640DFD; Mon, 14 Nov 2022 11:03:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C497D4014F for ; Mon, 14 Nov 2022 11:03:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668420200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yIAD4BsMLY5DGoVCHwWXsRnkbhltXaI4SrHQ8iTEbkg=; b=aNonoB0uHrsxL8yaGjJgOgsKiAZhlthaePBhq8Yl1OmatKxLVpfjQ/g6AtB2qrirWBUEXP 7yBbv7mj3CAkGZ/DYNCvuLen9IVIYDEItKZEnmJL/OnosjXwYqNuwsA70xQn2bgM7s6LkW oVWFI289wW43DLKd1KMwRgCmaNjBzZQ= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-572-MMbIKHmeM1OC72WQ1jF7bg-1; Mon, 14 Nov 2022 05:03:18 -0500 X-MC-Unique: MMbIKHmeM1OC72WQ1jF7bg-1 Received: by mail-pl1-f198.google.com with SMTP id u8-20020a17090341c800b0018731b83fe4so8666199ple.16 for ; Mon, 14 Nov 2022 02:03:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yIAD4BsMLY5DGoVCHwWXsRnkbhltXaI4SrHQ8iTEbkg=; b=XNdujacA1Rypxp42prfXZTZvZFgiXIVC76iQ3kdInGo91W8+bnRremyEjzPCO04zLs sQycPS66bImgZXOTfhauK6GZALRYEFtrSVlVCAHOzSHVEVVnxUYDsoZ0HgBMcCJZKZqi ZNHF4VY8Dj/qgG7E8bByVEGnPn5TB+TfETi9ZuTadvlxjBD0QtDlZLft9ehSP/KeekBc UgUBXUUKVtQtl7e5aL8m1i1ZrAMrH6fyxjqUi+AgUhK5e+2Yi7oG8h69SMFNpYkF2ts0 eN9e33vTjuXKaGrkZrGhsd36P12p+xA73lN27CNuyaavVm83SLFL+Z/dMj2gQWtZ076Y sjHQ== X-Gm-Message-State: ANoB5pmhXLmteYtt/SRVQmoE4/MyeRc5j2HfigB02+NacDaV0M90D6SJ dw14YEtqU5X+pUtWAve2i2pC0nBMMGCnBKOx4lyJxJ32Wboce17UNcHVverHftNKi8g9rSWVT6x 5ENSgIoAsIFuZ6XzYgx4= X-Received: by 2002:a17:90b:795:b0:212:c877:e948 with SMTP id l21-20020a17090b079500b00212c877e948mr13392340pjz.39.1668420197760; Mon, 14 Nov 2022 02:03:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf75K4hQa4dGvL7oJyh/uIvG9qStWOqZQV/UdQAw3kc5FyPzKfillqTLIlmNpsd5iPjYfwY/PfvRMIIx5/Dxxe4= X-Received: by 2002:a17:90b:795:b0:212:c877:e948 with SMTP id l21-20020a17090b079500b00212c877e948mr13392320pjz.39.1668420197514; Mon, 14 Nov 2022 02:03:17 -0800 (PST) MIME-Version: 1.0 References: <20221104095123.487630-1-jun.qiu@jaguarmicro.com> In-Reply-To: <20221104095123.487630-1-jun.qiu@jaguarmicro.com> From: David Marchand Date: Mon, 14 Nov 2022 11:03:06 +0100 Message-ID: Subject: Re: [PATCH] hash: fix memory leak of hash_rcu_cfg To: Jun Qiu Cc: dev@dpdk.org, yipeng1.wang@intel.com, lei.cai@jaguarmicro.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 4, 2022 at 10:52 AM Jun Qiu wrote: > > The memory of h->hash_rcu_cfg which is allocated in > rte_hash_rcu_qsbr_add was leaked. > > Fixes: 769b2de ("hash: implement RCU resources reclamation") Please, use 12 chars format for commit hash, as documented. git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'" > Cc: stable@dpdk.org > > Signed-off-by: Jun Qiu Reviewed-by: David Marchand Applied, thanks. -- David Marchand