From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AA8E42672; Fri, 29 Sep 2023 16:10:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85ED7402AD; Fri, 29 Sep 2023 16:10:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8294440287 for ; Fri, 29 Sep 2023 16:10:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695996612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uVpWqVOtE4Pz7Tp20bjHLQ1JvOKh7MCqXQlgev66dW0=; b=BAcFN5SkPLcyF377urOJpE2LAHHJgZpogCCl54dyno9kSGju8e8MW76MJ9u5c9JNceYhfg LbTZ9Oqr7sWY3KdeYo6e42tpiuy7zxXUa8o7I0dI/cI0Kaby6x6wBUkqDZxvMoyyzcKDNl zrcBWNApE9qQT5v/o794qR7j/luXKig= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-501-SbbU2IdPMembw8MxfNqLzg-1; Fri, 29 Sep 2023 10:10:10 -0400 X-MC-Unique: SbbU2IdPMembw8MxfNqLzg-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5041ae34ce4so19465090e87.0 for ; Fri, 29 Sep 2023 07:10:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695996609; x=1696601409; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uVpWqVOtE4Pz7Tp20bjHLQ1JvOKh7MCqXQlgev66dW0=; b=eKIqYwg4TnRiFbUvHXRi0aTLhbfCcYzO46/bW2bJ0fqca6UUY1Qxtz+iNwQmrcAw1I qSLlOZ/ZrwfdUPCghKzdK4BfGr6mPFMwhmhCy1WylVM+A25uUf2vwaDYNtyjeYjibzTR 5/VW3RLtpWndPEHPH+ecTDwM1DAsL7E5UeIMVcCN5V4wttNbvjJpFZNUhe1azL2jMX0q AlIW7Ttjk8ijDoezbLof6MmDHJJB0G2IwhhR1kEqoFXT0vXWTdiSsu9E6zvY4kmkKxxa VMiHUusi0EZRJIFfcctSqqHgPfD2NUE58F1F5HbdvugXjrUHvsgaWJF6axTXI2PyJK/h VJ2g== X-Gm-Message-State: AOJu0YwoU7sV9ZuwVvGwvtfEnzuZgqN2v/CUtiPA7qxJeVoRPjd/Q17E OdXYUB+vZU8ofM6JvJm5bZw0Bu2vYijXDjULN3wnnawMEz+SVzyfTwbthLC/FMkObNWFIAyvF8J 4YH1CJRmv63M+KL0RTbs= X-Received: by 2002:a19:4f09:0:b0:501:a583:e49a with SMTP id d9-20020a194f09000000b00501a583e49amr3443364lfb.69.1695996608935; Fri, 29 Sep 2023 07:10:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4akrPemYgtSN2vCtRU7hAiAKoG5VG9pr3OP024ULsbJ4r2n01eKPaVgTR2pt6nwhDccpNemW2HVfj0DuiQr0= X-Received: by 2002:a19:4f09:0:b0:501:a583:e49a with SMTP id d9-20020a194f09000000b00501a583e49amr3443346lfb.69.1695996608569; Fri, 29 Sep 2023 07:10:08 -0700 (PDT) MIME-Version: 1.0 References: <1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com> <1692738045-32363-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1692738045-32363-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Fri, 29 Sep 2023 16:09:56 +0200 Message-ID: Subject: Re: [PATCH v6 0/6] rte atomics API for optional stdatomic To: Tyler Retzlaff Cc: dev@dpdk.org, techboard@dpdk.org, Bruce Richardson , Honnappa Nagarahalli , Ruifeng Wang , Jerin Jacob , Sunil Kumar Kori , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Joyce Kong , David Christensen , Konstantin Ananyev , David Hunt , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Tue, Aug 22, 2023 at 11:00=E2=80=AFPM Tyler Retzlaff wrote: > > This series introduces API additions prefixed in the rte namespace that a= llow > the optional use of stdatomics.h from C11 using enable_stdatomics=3Dtrue = for > targets where enable_stdatomics=3Dfalse no functional change is intended. > > Be aware this does not contain all changes to use stdatomics across the D= PDK > tree it only introduces the minimum to allow the option to be used which = is > a pre-requisite for a clean CI (probably using clang) that can be run > with enable_stdatomics=3Dtrue enabled. > > It is planned that subsequent series will be introduced per lib/driver as > appropriate to further enable stdatomics use when enable_stdatomics=3Dtru= e. > > Notes: > > * Additional libraries beyond EAL make visible atomics use across the > API/ABI surface they will be converted in the subsequent series. > > * The eal: add rte atomic qualifier with casts patch needs some discussio= n > as to whether or not the legacy rte_atomic APIs should be converted to > work with enable_stdatomic=3Dtrue right now some implementation depende= nt > casts are used to prevent cascading / having to convert too much in > the intial series. > > * Windows will obviously need complete conversion of libraries including > atomics that are not crossing API/ABI boundaries. those conversions wil= l > introduced in separate series as new along side the existing msvc serie= s. > > Please keep in mind we would like to prioritize the review / acceptance o= f > this patch since it needs to be completed in the 23.11 merge window. > > Thank you all for the discussion that lead to the formation of this serie= s. I did a number of updates on this v6: - moved rte_stdatomic.h from patch 1 to later patches where needed, - added a RN entry, - tried to consistently/adjusted indent, - fixed mentions of stdatomic*s* to simple atomic, like in the build option name, - removed unneded comments (Thomas review on patch 1), Series applied, thanks Tyler. Two things are missing: - add doxygen tags in the new API (this can be fixed later in this release, can you look at it?), - add compilation tests for enable_stdatomic (I'll send a patch soon for devtools and GHA), --=20 David Marchand